From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id D6A483858434 for ; Fri, 25 Feb 2022 14:13:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D6A483858434 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2051.outbound.protection.outlook.com [104.47.10.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-9kN7NNKfPPiM41-IZkB9og-1; Fri, 25 Feb 2022 15:13:03 +0100 X-MC-Unique: 9kN7NNKfPPiM41-IZkB9og-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WRka/rU1dBKM+EooYmPGDTee39YxqM/96coHQYiqpdGZDi873RHdtLlPIDMXY/78Y/IjLLVBy0CX+3u/lU973lTpm50fK+GLnLn1ei29mJXyMBuA7YGt0hiJHxElDaBBV3dYDaotl5APyscF80QSk9YgnALNdxVEnP2TbetIbxY63O3+1ugSFhKUpsEmGYYEj1JSANWCGcmKQlXoy0y2v5rVIIhDr1bpUfTI2oXa+OfFnlSj/amTQkC5Xu2NTi6XKMWPiZ0tv3FS4XJFl0BmEg+txADoA1pkmGVxsBOxTKoO8V2TA6j6LVIIwP0BIdAslEdr8JRaGBveprOsQmuMsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H0esVUB8e4Ioulf/JClpeDsHDeNXDG468EORcXZ2M1c=; b=AxpUVYQkFiLbmC3qMghJgIRTlZKhcIAw8UMOoFtABkYfIS8mtF23eQxXu2Zc4u0Vb8nX1lMeN+BlCHe/VoLmmdWKzN0AZDrXuOzwKrYqCg0d2jy41DSxGFSiLUHombjzhqPZKwWLyNqKUZncCaQoS9u97QLk6zg9RVfSU0OMoX34Ftsxlpio5OLl9fRngFssUYGQix3oueWCmBNa+lKEdx4PJm0a5KiVb2FVhp0ydOf64h+BzaqvoGs+aRmRVxOSj/xSFy93zdoL27mW4JBAFwETCK+SuFpHkS/m7SjmMM1vmREv8MVc/AVW5ej4eh6vPlWG7dAJ5pTReJU8lnLmzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM6PR04MB4120.eurprd04.prod.outlook.com (2603:10a6:209:4b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb 2022 14:13:02 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022 14:13:02 +0000 Message-ID: <0d00a96c-f6af-0a86-b2ca-153da98bed1f@suse.com> Date: Fri, 25 Feb 2022 15:13:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: Jan Beulich Subject: [PATCH] RISC-V: correct FCVT.Q.L[U] To: Binutils Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0402CA0021.eurprd04.prod.outlook.com (2603:10a6:203:90::31) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1f99c09-8ce3-4335-4a3a-08d9f868eef3 X-MS-TrafficTypeDiagnostic: AM6PR04MB4120:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iwKYSfXatlt+zx7yti+uBFYRDsZk8S9O9OBoH1FzLjtMw3r1yMLGuSglqSS4E7xE/n9EZpMdSOwQko7zTG1Hh6LZxdvZEam8nKi/x98qXL7a0NuMUnXPL4YNl+j5yYq5F7FvrZ1oNtmtNpdu2Ou7XyN0ReCkXxZLiiP4sEXbsk645XNHcIPqll0s9qop3qA0c0dwMJk6NttZdJ9z4+CanDuabN7D7ZbU9mOLiaCbFNFWOQPs9UbWgBYm7Mb58paSKJjhSCKEc1cwfPu8BDo5TZIwPf5SMd1yVjT+qql0Yiz/IHK4aKqoTHswEJcThgBRYoMBSFAl4nnbh5R8wzJEFY6NzYHC3YsWzGpSiGNNR1btqsv3pUF0RTJvOUPG+B+ggm77B7Ew70ON25rVyM7HpB6tza2FB+A8vyzhYwtzPAfXINSke3OyUdtxGceQ8Q+yuygRoTi6MPeUdLa7gdGcQXiy1XtmIHdSprkK+iY5ahk18ZDXux2ajRngU+3b1FQwi2+MO7rj+2n+/L+5d4+uBSJYTPFJfX1xm85ApqEgniyDx/1PnIQE8/VTqPZI0wZ2AO+BUNttgWoEj03UaMA0CDQWkA8236j2wYyBIdTNdRpUuIr36XSD5GIqczLuCnuwxvKzxsBFhVVT491zIbeUdGycTu8atUhYGSuSsBZwBsjKpzdIZZ6FAPHXwi9eqhxGLwmAW/A69N01XzeHEXXaib6VN/wJvc3Qn8NEzoiFVac= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(2906002)(5660300002)(26005)(186003)(66476007)(54906003)(316002)(6486002)(8936002)(2616005)(31686004)(36756003)(8676002)(4326008)(66946007)(66556008)(38100700002)(83380400001)(6506007)(6916009)(6512007)(31696002)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YS9BNUdnRjhUOXJrbTBKSTZBL2xPbVZsNFRWN291VWJ6K1E5cHRzT2FsaHBm?= =?utf-8?B?K0kzUmtFN0l6UENwdDhUSzR1aGxsWkpXM1dlOGp6YkRaOGRsYlFvZFhER2Fo?= =?utf-8?B?RGtXMlkzQ0ZFQ25UOWh0OFgxblFGem4xMDNqY1RGRC9yVTRaOFVRa0VYT1VQ?= =?utf-8?B?L09VcG1OcVJnelNoYmw4L3JTT2I3VE9GOWJrbjNKeEdGbWd3ZGtEOHNEOVlk?= =?utf-8?B?Mzhyd3NTcGI3Rlp0MnpKMjRvb21ONW92VlU5S203cG1GQkUxVCtiN2luQW1M?= =?utf-8?B?RGoxa25HcmM2YVF5dU5la2RmNk55WUhyLzhXRTFuY2wwNGtvWllNY1BKb3JG?= =?utf-8?B?Y01OSFhpVXkrNHR3NktpUzFPQjIxempkcDhyLzFpaHlTaVRFeWkwU2lKNFND?= =?utf-8?B?WlNVKzlSdE5tRlFhNTllRlk1NTdpZmJTZGpnaE12ZWJPRFlIZzVvQnJiMkJ3?= =?utf-8?B?N0NQeUlQZk9vZC8zRXNBLzE3anlwNmVPUFZWT0NBMUpJNGV4WjA4azlwYjBV?= =?utf-8?B?b3Fmb2RTbXNNNVVkRE92UlMyMU5EdS9XMnVvUldGbGlqVGNRYkh2WkdrU2pH?= =?utf-8?B?cjdjS2oxR0ZyNHVBdHRjN213NGZUcDM4cjNKeGljQXJQbmJZNFcrT1dxUFRu?= =?utf-8?B?TFd2RmxEVklhazBRN3JXdHBXMXdzajJ5ZEtLUm9iRUh6SFlxUEZ3ZUZRbUtl?= =?utf-8?B?bjd4QUEwQlEwbmtHY1Y3aDVSaXc5bmdVbzBSdFpFRE1aam84Y2NlSXVlY1Q3?= =?utf-8?B?MmVBTEpsSkJVYXBXdFY4TkhQcWtDMTJreUQvR2NIYVBTdktpbE9OY3FWTU9X?= =?utf-8?B?bjZMR1JOSmgyNlJUYWtFdVRWYmMzZy9YVWZpM1BZaFAxTXBlbThGNFhOMmVI?= =?utf-8?B?a0JlYTRmREVIN0ZvRUo3Vk45RHZSWTdiU3lOS1kxd21SOEZpSnM2OGNMNm5B?= =?utf-8?B?UklSL1NweGR3S2t1TzE1akRyVW95ZjMyTU1hZVF6TVZ0RjRMYjdsaDhYcHhi?= =?utf-8?B?Yk0zRFV4d1hHWnI2YVp6ZThlT2kyeVlJb0hwcDk4N2RkSlBxcWRVUkJEQVdU?= =?utf-8?B?Tk9mZzFMOFIxa1U2UDJ3THlzcjVZb1pNV0pzdkRsSTZPclRkb0xhUDJWQ2FE?= =?utf-8?B?OGgxR2dRa2tRbHJwNTB0UmMrWFB6NmV5RDk5NmRIeWlVNm1UVktNSmFSWmVh?= =?utf-8?B?aG9vZDhETHpLRlhXWWV0ZGFQUHp2NEtrcFFFQXN6L25HSHByVVRicTR6YS9l?= =?utf-8?B?UjBtVjVmV1MyTFFXcmpxVFgrdVcyc3VqOU1BT1ZtUzYzNGxnazBPL00xem1V?= =?utf-8?B?MFkvTFhLOGJQZ3hNN3Z6WE0xbHgrcndBbFpqN1dqRzN6NG5ySExyVUJiV1Fo?= =?utf-8?B?UERZeDRoMnlaSWI5VTJLV24xaG9ZVlU4MzN6cnU1TFcySkdVZEJtTXZ1QVFi?= =?utf-8?B?ZFdVQnR1MjlNYkJxWHh0N3plUHdtUGFlMUYva2c1eS82cHlMY0t4V0VPSGlT?= =?utf-8?B?R21wZkRTOVFiR3pvYVJEcXA5UEU0M29oc1V6NlVta0V5U3VqTHQ0VWoySjJr?= =?utf-8?B?eEFnY2NIcS9XbEtmL01sdmN3ZFFuVmdER0Yxbkg4TkhFamU4N1l5Q2VVRytk?= =?utf-8?B?Wjc3U0szMTQ2R0tZaEdDTUxlY1VtUHEzQVdMZmQ2MmFSQ3EwR3RKblBaUWdR?= =?utf-8?B?dzhTazdjYkZTRjNTZng0QlNWRXNPMi9oZXphYmE1WklOZmpOcDJWK1BlaCsr?= =?utf-8?B?MWJiVGNuTU5JZFJpQ1IzT1JIaHpNcHlMaUJpdXFOR2ZjV0NzUDVtR0lzYmdw?= =?utf-8?B?Mzhwd1R6TjVUSW4zblFOUTRLcW1BMW1TSG5QVkQwWll5aUU4U1drOXRrQU5W?= =?utf-8?B?bThvREQzUzVPY2FyYVlyenFQOVJSbXFhUzZhcXg4V25pR0hCVmR4d2VHN1pj?= =?utf-8?B?TW96a2RkbXZPRFMrQXZZeUFrSlVRQWFMV0dBa3RsMkxURmszVWdlMTVKVi85?= =?utf-8?B?ZnQ2OTlNZUVlWVg1dlRGRSs1eEVKejhxWFRSYTVHZVRBLzJpVTFRU3kwTjNW?= =?utf-8?B?SHVDbFBZRlBJSTlGcXozM3BqbkthYnJHVU0vbFcvUWVuQXhFYWozK0c3dFFh?= =?utf-8?B?SnZLTDBRTHcwaTR0S0EvaHZmVVFCaFdlN3JqMnVJcEN4VWwwd01ObnFuM0dE?= =?utf-8?Q?tu2y4cVZf1ndjoGhq1lpTcI=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1f99c09-8ce3-4335-4a3a-08d9f868eef3 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 14:13:01.9938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QQKcFUs6dOaqS21QAbCDWFX8k9Jaa5GZu9nG/olBI0VZ7lZjHYoakI3kNRsBKsVb6iUad9cC0UdS0MzgZb8tlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4120 X-Spam-Status: No, score=-3032.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2022 14:13:07 -0000 While the spec isn't explicit about this, it pointing out the similarity with the D extension ought to extend to the ignoring of a meaningless rounding mode: "Note FCVT.D.W[U] always produces an exact result and is unaffected by rounding mode." Hence the chosen encodings also ought to match. Note that to avoid breaking existing code the forms with a 3rd operand are not removed, which means there continues to be a difference to FCVT.D.W[U]. --- Oddly enough there's looks to be no testing of the Q (or D/F) extension beyond what was recently added for Zqinx (Zdinx/Zfinx). --- a/gas/testsuite/gas/riscv/zqinx.d +++ b/gas/testsuite/gas/riscv/zqinx.d @@ -28,8 +28,8 @@ Disassembly of section .text: [ ]+[0-9a-f]+:[ ]+46158553[ ]+fcvt.q.d[ ]+a0,a1 [ ]+[0-9a-f]+:[ ]+d6058553[ ]+fcvt.q.w[ ]+a0,a1 [ ]+[0-9a-f]+:[ ]+d6158553[ ]+fcvt.q.wu[ ]+a0,a1 -[ ]+[0-9a-f]+:[ ]+d625f553[ ]+fcvt.q.l[ ]+a0,a1 -[ ]+[0-9a-f]+:[ ]+d635f553[ ]+fcvt.q.lu[ ]+a0,a1 +[ ]+[0-9a-f]+:[ ]+d6258553[ ]+fcvt.q.l[ ]+a0,a1 +[ ]+[0-9a-f]+:[ ]+d6358553[ ]+fcvt.q.lu[ ]+a0,a1 [ ]+[0-9a-f]+:[ ]+26c58553[ ]+fsgnj.q[ ]+a0,a1,a2 [ ]+[0-9a-f]+:[ ]+26c59553[ ]+fsgnjn.q[ ]+a0,a1,a2 [ ]+[0-9a-f]+:[ ]+26c5a553[ ]+fsgnjx.q[ ]+a0,a1,a2 --- a/opcodes/riscv-opc.c +++ b/opcodes/riscv-opc.c @@ -763,9 +763,9 @@ const struct riscv_opcode riscv_opcodes[ {"fcvt.l.q", 64, INSN_CLASS_Q_OR_ZQINX, "d,S,m", MATCH_FCVT_L_Q, MASK_FCVT_L_Q, match_opcode, 0 }, {"fcvt.lu.q", 64, INSN_CLASS_Q_OR_ZQINX, "d,S", MATCH_FCVT_LU_Q|MASK_RM, MASK_FCVT_LU_Q|MASK_RM, match_opcode, 0 }, {"fcvt.lu.q", 64, INSN_CLASS_Q_OR_ZQINX, "d,S,m", MATCH_FCVT_LU_Q, MASK_FCVT_LU_Q, match_opcode, 0 }, -{"fcvt.q.l", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_L|MASK_RM, MASK_FCVT_Q_L|MASK_RM, match_opcode, 0 }, +{"fcvt.q.l", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_L, MASK_FCVT_Q_L|MASK_RM, match_opcode, 0 }, {"fcvt.q.l", 64, INSN_CLASS_Q_OR_ZQINX, "D,s,m", MATCH_FCVT_Q_L, MASK_FCVT_Q_L, match_opcode, 0 }, -{"fcvt.q.lu", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_LU|MASK_RM, MASK_FCVT_Q_L|MASK_RM, match_opcode, 0 }, +{"fcvt.q.lu", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_LU, MASK_FCVT_Q_L|MASK_RM, match_opcode, 0 }, {"fcvt.q.lu", 64, INSN_CLASS_Q_OR_ZQINX, "D,s,m", MATCH_FCVT_Q_LU, MASK_FCVT_Q_LU, match_opcode, 0 }, /* Compressed instructions. */