From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114535 invoked by alias); 20 Jun 2017 09:03:44 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 114515 invoked by uid 89); 20 Jun 2017 09:03:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=forbid, UD:W, Best X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 09:03:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6CD4180D; Tue, 20 Jun 2017 02:03:40 -0700 (PDT) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4CA7F3F587; Tue, 20 Jun 2017 02:03:39 -0700 (PDT) Subject: Re: [PATCH, GAS/ARM, ping] Fix expansion of ldr pseudo instruction To: Ramana Radhakrishnan References: <0a39721c-906b-677d-b156-81daa05fac09@foss.arm.com> Cc: Nick Clifton , Richard Earnshaw , Alan Modra , "binutils@sourceware.org" , gingold@adacore.com From: Thomas Preudhomme Message-ID: <0d306b9d-dcd7-085c-8b84-55fa90ffb4d1@foss.arm.com> Date: Tue, 20 Jun 2017 09:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00207.txt.bz2 Ping Tristan? Best regards, Thomas On 14/06/17 10:25, Thomas Preudhomme wrote: > > > On 14/06/17 10:11, Ramana Radhakrishnan wrote: >> On Wed, Jun 14, 2017 at 9:49 AM, Thomas Preudhomme >> wrote: >>> Patch applies cleanly on binutils-2_28-branch and shows no testsuite >>> regression. Is this ok to commit to binutils 2.28? >>> >> >> can you mark this as fixing PR21590 in your changelog for 2.28 ? > > Sure, please ignore the ChangeLog in the patch, this is coming from the > cherry-pick. The proposed ChangeLog would be: > > 2017-06-14 Thomas Preud'homme > > Backport from mainline > 2017-04-24 Thomas Preud'homme > > PR 21590 > * config/tc-arm.c (move_or_literal_pool): Remove code generating MOVS. > Forbid MOV.W and MOVW if destination is SP or PC. > * testsuite/gas/arm/thumb2_ldr_immediate_highregs_armv6t2.s: Explain > expectation of LDR not generating a MOVS for low registers and small > constants. Add tests of MOVW generation. > * testsuite/gas/arm/thumb2_ldr_immediate_highregs_armv6t2.d: Update > expected disassembly. > >> >> However you need an ACK from Tristan about 2.28. > > Yes indeed, my mistake. > >> >> Also could you please note the sha1 which fixed this on trunk on the >> bz for posterity ? > > Done. > > Best regards, > > Thomas > >> >> regards >> Ramana >> >> >>> Best regards, >>> >>> Thomas >>> >>> >>> On 24/04/17 14:07, Nick Clifton wrote: >>>> >>>> Hi Thomas, >>>> >>>>> 2017-04-20 Thomas Preud'homme >>>>> >>>>> * config/tc-arm.c (move_or_literal_pool): Remove code generating >>>>> MOVS. >>>>> Forbid MOV.W and MOVW if destination is SP or PC. >>>>> * testsuite/gas/arm/thumb2_ldr_immediate_highregs_armv6t2.s: Explain >>>>> expectation of LDR not generating a MOVS for low registers and small >>>>> constants. Add tests of MOVW generation. >>>>> * testsuite/gas/arm/thumb2_ldr_immediate_highregs_armv6t2.d: Update >>>>> expected disassembly. >>>> >>>> >>>> Approved - please apply. >>>> >>>> Cheers >>>> Nick >>>> >>>