public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <li@livegrid.org>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: GNU Binutils 2.41 release
Date: Tue, 1 Aug 2023 19:15:59 +0900	[thread overview]
Message-ID: <0daf32ff-4c8e-e5af-69ec-59b19268bd9e@livegrid.org> (raw)
In-Reply-To: <da9ffeba-c1bb-4ca6-b9ac-3008ae7cb215@redhat.com>

On 2023/08/01 18:43, Nick Clifton via Binutils wrote:
> Hi H.J.
> 
>> The binutils-2_41 tag points to the wrong commit:
>>
>> d3cc73ee4a (HEAD -> binutils-2_41-branch, origin/binutils-2_41-branch)
>> Updated Spanish translation for the gprof directory
>> ae85bd64903 Automatic date update in version.in
>> 7872e3bdb0d Reset 2.41 branch back to development mode
>> 2c73aeb8d2e (tag: binutils-2_41) The 2.41 release!
>>
>> The binutils-2_41 tag has
>>
>> m4_define([BFD_VERSION], [2.40.90])
> 
> Darn.  I am not sure that I can do anything about this.
> 
> I must have missed running "git commit; git push" after changing
> bfd/version.m4 to:
> 
>   m4_define([BFD_VERSION], [2.41])
> 
> And then making the source release tarballs.  So the tarballs are
> OK but the tag points to an earlier version of the sources, just
> before the release happened.  The problem is, there is no commit
> that exactly corresponds to the released sources, so I cannot create
> a new tag for the release point.
> 
> Any ideas ?
> 
> Cheers
>   Nick

If we don't have to stick to the "binutils-2_41-branch", we could just
create real 2.41 commit, making the commit 2c73aeb8d2e0 ("The 2.41
release!") parent, then change the tag (the resulting commit will not be
a part of any branch).  That should create a duplicate diff to commit
7872e3bdb0de ("Reset 2.41 branch back to development mode") in the 2.41
branch but far better than "no real 2.41 on the repository".

Alternatively, we have an option to release 2.41.1 and yank the original
2.41(.0) (the SemVer way).  But that's probably overdoing.

Thanks,
Tsukasa

> 
> PS.  I have updated the README-how-to-make-a-release file to add
>   a note to check for pending commits just before creating the source
>   tarballs, so hopefully this issue will not happen again in the
>   future.
> 
> 

  reply	other threads:[~2023-08-01 10:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-30 14:57 Nick Clifton
2023-07-31 17:25 ` H.J. Lu
2023-08-01  9:43   ` Nick Clifton
2023-08-01 10:15     ` Tsukasa OI [this message]
2023-08-04 10:37   ` Nick Clifton
2023-08-04 18:02     ` H.J. Lu
2023-08-04 19:57 ` ASSI
2023-08-05  0:38   ` Sam James
2023-08-05 10:08     ` ASSI
2023-08-06  3:00     ` Tsukasa OI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0daf32ff-4c8e-e5af-69ec-59b19268bd9e@livegrid.org \
    --to=li@livegrid.org \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).