From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id C7CD13858D28 for ; Tue, 1 Aug 2023 10:16:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7CD13858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=livegrid.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=livegrid.org Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id AD0FA300089; Tue, 1 Aug 2023 10:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=livegrid.org; s=2015s04; t=1690884959; bh=/T7SgEtJYLtzsAmBtPv9YbMo1KgOXzoZAOx2pnQH7hM=; h=Message-ID:Date:Mime-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Dfp358Ii1mBu2oJKJovdM2p7uw4vsI3GZMqscw39BSNlSzUJs3HT2HLQr61/ZeXWC +NUoHDU5vbGvv415ubnm7MJs5zUqD6//FjEi53QjkcYBKTviiLZP9xSBlTIo07MOtj 7X+RexcD/gKXy9J2CZDNfUzXojHCByUinfuRtU+1nK23dmyoSa4Bz9J3hdh4TtdvEY ktmzVo/6BGkJKWrUBZQuDc6uaeqIZbkdx5Fj3mWS2xPT0qssLgI8tMItvqVKvrB36S 80uDMtyM24D9Hrl/y55kim42iEtbq7qBYq13m7tRruIVUOBprxiKmb0j2qABB514GR cDItmofpuHsFw== Message-ID: <0daf32ff-4c8e-e5af-69ec-59b19268bd9e@livegrid.org> Date: Tue, 1 Aug 2023 19:15:59 +0900 Mime-Version: 1.0 Subject: Re: GNU Binutils 2.41 release Content-Language: en-US To: Nick Clifton Cc: binutils@sourceware.org References: <87bkfta1mf.fsf@redhat.com> From: Tsukasa OI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023/08/01 18:43, Nick Clifton via Binutils wrote: > Hi H.J. > >> The binutils-2_41 tag points to the wrong commit: >> >> d3cc73ee4a (HEAD -> binutils-2_41-branch, origin/binutils-2_41-branch) >> Updated Spanish translation for the gprof directory >> ae85bd64903 Automatic date update in version.in >> 7872e3bdb0d Reset 2.41 branch back to development mode >> 2c73aeb8d2e (tag: binutils-2_41) The 2.41 release! >> >> The binutils-2_41 tag has >> >> m4_define([BFD_VERSION], [2.40.90]) > > Darn.  I am not sure that I can do anything about this. > > I must have missed running "git commit; git push" after changing > bfd/version.m4 to: > >   m4_define([BFD_VERSION], [2.41]) > > And then making the source release tarballs.  So the tarballs are > OK but the tag points to an earlier version of the sources, just > before the release happened.  The problem is, there is no commit > that exactly corresponds to the released sources, so I cannot create > a new tag for the release point. > > Any ideas ? > > Cheers >   Nick If we don't have to stick to the "binutils-2_41-branch", we could just create real 2.41 commit, making the commit 2c73aeb8d2e0 ("The 2.41 release!") parent, then change the tag (the resulting commit will not be a part of any branch). That should create a duplicate diff to commit 7872e3bdb0de ("Reset 2.41 branch back to development mode") in the 2.41 branch but far better than "no real 2.41 on the repository". Alternatively, we have an option to release 2.41.1 and yank the original 2.41(.0) (the SemVer way). But that's probably overdoing. Thanks, Tsukasa > > PS.  I have updated the README-how-to-make-a-release file to add >   a note to check for pending commits just before creating the source >   tarballs, so hopefully this issue will not happen again in the >   future. > >