From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2087.outbound.protection.outlook.com [40.107.6.87]) by sourceware.org (Postfix) with ESMTPS id 2B34C3858D28 for ; Mon, 24 Apr 2023 10:39:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B34C3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GQPbntqOIIIPbrk4eMInr+/GaAisBBLstMDlWemHepdEWNxO8mlZD6z5sAmypvJ/O79q6WfEqa9aADq2n2hI9g5HTorWWQoit39ZyWvfftu+c2K69B2xSKOrJMZF8c7yqmd9YVoaed6BSboInyyQG49cM0SG1Xc9x3pzPMsMgTiKedQ+c3YVy996MjJJNfEAw5stM+mjRxCHYTythjEyyIcuC4rPXW0SyjXnhmJIzPqlKF6FN3KihdQN4yoNXuhuFL4Umo/32a1knj/kR/exOmTu7Bsm1FDh4aLOj+3Xs+gQTYk+WfGzAz0Uq7NIraMQqYfSZbsacrVc1jzrx9w7cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aG3427YCj2xkQSKwuzHScBp4MIy3VlEwZbhI7u0VwF8=; b=YCL5XsQMgtFtZw9WTWg91IG7aJ/Wl5vkkExtvsHr+tGsqTV6X5WlJdtmSiIB2KtLLJOhWBXnwqRz31y6hQJL2UgnCjBGyJQp0ZaU0S3dzYy1rs8VJ676XoZG8F45W3IPqzG1TrcS8FfR4syVCuQUbqih4SSGQi+Q/BQ++nBzsaebdtr4I0aMRi5flq8vOSgCmwC+CaBAsXeqDscXRIDigzmk0+v8bijAlCUl+se+NhNmPYROZQ3mSbyFTpfJQuUoPdUwlPFQm5DKRIvei8gHF2N1QfDFh86rgEheIBOePdxlHidASfhwVkks9JvhIujxG7J1ApLWC9FsiF4kJnNaDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aG3427YCj2xkQSKwuzHScBp4MIy3VlEwZbhI7u0VwF8=; b=qSRzNvyfFmtjYDuiRlcOCDI+Tgida7vm7CUpSM+ZfMMLuW1/Vk70a2X1TGncHE01OfrIBkMOzA1h9dvuL6r04eHfGvvaZMTbBQFf4G9RN+CYjXlkhY/4QJLh3hcreKbUrwK8uJU1GXJOHRWotjTt/00xsYo6ztDsJb8xwW7bTIhEXYlBGKlczMSXFgHM8qdRFo/AWLRmHGTRvtNQHCGj/rzeZfzJAtwzcRDxiQP6tn4++65fkTpFV0btSJJZvQ6KzBDi7ToG7OonH6GGAnpAx2UvM43SSq0s7BTVKxaSL7vYTg7DeB5YZAl1TbR11E9s/cuK4E+FkKJfKh1rRCDLYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6811.eurprd04.prod.outlook.com (2603:10a6:10:fa::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 24 Apr 2023 10:39:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6319.033; Mon, 24 Apr 2023 10:39:45 +0000 Message-ID: <0e957eb3-f117-a454-93f6-423f75cb1f2f@suse.com> Date: Mon, 24 Apr 2023 12:39:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: =?UTF-8?Q?Re=3a_=e2=98=a0_Buildbot_=28Sourceware=29=3a_binutils-gdb?= =?UTF-8?Q?_-_failed_compile_=28failure=29_=28master=29?= Content-Language: en-US To: Alan Modra Cc: binutils@sourceware.org, "H.J. Lu" References: <20230424003151.E975B3858C83@sourceware.org> <50b2bc1b-71f6-25a6-27d3-7d018b98389b@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6811:EE_ X-MS-Office365-Filtering-Correlation-Id: 749f65f6-2099-49a8-0395-08db44b03860 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: skbg1jR1J/NZpt/Xf+mLE7SfzqVMDw+DH36WZNMhycwC5Za/x54DqBQSwm09oM69u8X9tE9oNvoqFr3X4fR+5njBJmhuO7ro8MJdmQFzCsC6Mou116w7imydpppql63gSyOlYznYuJG9znGWzUgf7Zd2cNpg1rGxPX7kljIU5PdaGymMLv6g0AwhEUNxws+gb5hsbaAR3/FwevDv4Ue51uah6dxveoZbqxWoRd8MKK0PLoYqE+017guJISZfcGo6r4TB31VQX3+IpgIOU/cPJyOODUF0cQpavTuPyGPKrSzudYNsBg5LRqrZAUlEMIzptnR6nJUg2QqPFo1C1YhoxrXSyibEFEV/VIUnWMwePXl6E3fU970NYV/U5O+UHvyo1QNrFiv2GIgfiOdmICKNOKETptFgqEjwnh8vN2lu/USccuDnU+yQlP91bUXc7/H/F2aLZbZwiqdpOLqSSSUPIBJBabB8+Ru1rT3JQcj7VdOu24kEZGyuJDTSXdKXv44+Ny7ltAz54hb7Ny4+R3QXdK+akha3cXwramsoNOw5QsSktwzSdDHcKDJRAw7KOSSIa1zD+Rk7I6vITxbVncvp4AYyOTq8YMPVDLQOoQyzyY3uMe9gjxSqPmRI0msGlyIoIJ7QnRZhrGp6pj+IXF6LKA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(39860400002)(136003)(396003)(451199021)(478600001)(31696002)(86362001)(966005)(36756003)(186003)(53546011)(6486002)(26005)(6506007)(6512007)(4326008)(6916009)(66476007)(66556008)(316002)(83380400001)(66946007)(2906002)(38100700002)(41300700001)(8936002)(31686004)(5660300002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjRCTFdGdUZ5WHhsK21ZMUxSK0tCMGN0VCtQZENaT0hxcno2SkhsamEvQm1i?= =?utf-8?B?RXM2Y0hOSnNuaEl6ZSs3V2RRSE90Qk5kUE9CdzEyRFZDZmlXK3ZjWkFvRFZz?= =?utf-8?B?MENQZW43Q3VPR1JNQjNyRW96OUJrbFJucndiM20wSXVLWlFXeEpGdHVuK1ZL?= =?utf-8?B?dks2aWNsRFZrbTdxNEdWUW96dSs4OEYrSWNpWWhGS3U4d1B4NEJpOGY1Q0VT?= =?utf-8?B?THN4dHN4NkxTSGpPYUY1SlY0V1RqMFFOQ3BRZHVjRXlOOW9zVGZGOUJmbGt0?= =?utf-8?B?LzZiLy9nWnhyWTdMVGVORzVEMTBibDkwMmhHMkFKZ1hFaVNQdkdUZDZmdmUv?= =?utf-8?B?QldtbUtxVmJuNmpBTmFGOGZhUjQ0Vmc1Rmpra3RBclh4SFZXWk0rQnExbXFX?= =?utf-8?B?VlFhMktaU2JYTHFyT1JWeUsrcDEzSEJaL1BZeVhzd0Q4ZUhQcmJTdDRWYTdk?= =?utf-8?B?YXVHd0N3UERaczZJSWE1NUhEZzJnREw0MmVGRExzWG4wRkJwd3VSSFZCMU0z?= =?utf-8?B?VXN3TzQ0ejRWTW5YNTlvN0VFQm4waHYwS1l1dzhzTHRtZnJRTnFqTHY0bVJo?= =?utf-8?B?bmVaYUU3NGM0RndwVDJvKytxRFN4L05RR0hFVlRrTElmeDE4Q2duUjJLaXpr?= =?utf-8?B?aE9vZzZZRnlqYlNqVHNoRUdlM1Bqb3EyNk1seXUxdWVXck1HQXFWNTJ2Umda?= =?utf-8?B?Szl3ZlU1Vk9UTlVnOGtwZWNTWUtrVElnYms2dnJBbUNRUk9OQVVoTmNpcXFC?= =?utf-8?B?MHBYNDJwT25tUjUvaFJZbnV2Z3pEMFdGckNtdTlqM2RsNTk0QWFHdVVJVmNP?= =?utf-8?B?NitBRm44VnZHcHhnd3llSTZkQXIzUGZQVXRaZXc2M050SXBTVks1R01BTzUr?= =?utf-8?B?Nkt2V1htRVQzSUFYdm5PTjRWUEsyVnFSSVpFdFNlUlpwU0x5M0htaFFxRjdF?= =?utf-8?B?aGNWMG53UjRMUDlUb2s3c2Ryaks5SjdDM2RDQXEveDNnaXI1dnFrVEhEQlVP?= =?utf-8?B?STRNUmlwU29Jc0FMYWsyam1YNzRoWGVJa1RKQXgwbVVDY3phK1NrM2VOeUNH?= =?utf-8?B?WS9QbjVSbStZV1dpUkJpNmNGTEpoNlV3dXFpYm1HTk1FOEFIaTR2Wko1ZXhv?= =?utf-8?B?UzBDZ09CTzIzb2toS2FvbUJKSGptY25JdG5SbnY4NkVtcGs1a1YybjJPRHA3?= =?utf-8?B?MnVGR1N0Q0VlTHdwRkIwdkZlM21DNUdCWVIxbGExbU85RHgwWWc5bEJsOEVW?= =?utf-8?B?NitLVnJTSTNkT2lhNUdHMllJdGxCZTVJV25GNmpRakZaL1JGQ1NuUWE4ME9U?= =?utf-8?B?MHNwcVNVY2lPdm1abm51WHRYYXhmYmVVVXkrbGxhd3BkRlpBdnZBUUZHbldk?= =?utf-8?B?RjdVOW1VK0lmNEJlWFdlOE84eHNYd1p0RG9lMlQvQlBhSnQvdWNQNHdQZnV3?= =?utf-8?B?UVdha3N3L0MrYXVSZlNXZ2U0SkdrcUkyZXpqR0RGb2hrNm1odTNnSkRONzVT?= =?utf-8?B?WkVLZm1BRGJyb09RRHI4TEJ1Yk16anNhcDgxSjY2MjRiVHdmT3E5eE4xM2FM?= =?utf-8?B?NUVOblJkbEwyUXdYOHFpS25SUFpMS3l0WXdWZVkxS0IrK2ZHT3F6RnZRTUZV?= =?utf-8?B?d1BRb3hXdWI5bHJJdVg3emRUT0xwakc0VmFBZXJ6a0k1OFNpcDNKSjV1aDB4?= =?utf-8?B?T05pS1dINnhkZWUzRWs2bFNEYzBnQmZ5UUdETS9ncXprcWRzS2V6Tk1kbmRW?= =?utf-8?B?S0FFbHVtM3JMV1d2TXorYThlaC9xREo0VEJVbityMHYrcDFOeEY4UU02aGxt?= =?utf-8?B?VTdoT3NWdHptakgyWDdPWnNZcDJrTG1xU1RpN2RUSktabGJxRERUK1BXL0JE?= =?utf-8?B?VU9USkxlKzRGdUdFb3psa2JQcEJDemxsUVNqVW5LaHFoZTdOTEV1YUVEeTEz?= =?utf-8?B?TzRLRDdDUnpKOG9Va0hURC92ZFRtZ3JNdGNOcVNkL3MzRlZZdTRsWkJiVFNk?= =?utf-8?B?aU8ySkRxRTh5ZTQ5ZzN3cGJzQVZVRm9VYTNESFJzcVM1SjhzeWV2ZmFxUVpY?= =?utf-8?B?SXY3N0JvTUw4bGN6eGl4azRvcjlIek0wSXozcVBSK3dqZ1hDR2ZIdW9wdDMv?= =?utf-8?Q?+eInwzKjEViy3ovFVEXDQEsrt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 749f65f6-2099-49a8-0395-08db44b03860 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 10:39:45.5391 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BMioRCFuCw2dsKD7lqXH4vtxkuWFf5qfYSyczXcTrH6Ph72Rc482TZkwuEwY8tZWFp7U0CONrm6LwjfZn5TdLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6811 X-Spam-Status: No, score=-3028.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.04.2023 12:33, Alan Modra wrote: > On Mon, Apr 24, 2023 at 08:04:35AM +0200, Jan Beulich via Binutils wrote: >> On 24.04.2023 02:31, builder--- via Binutils wrote: >>> - 4: make ( failure ) >>> Logs: >>> - stdio: https://builder.sourceware.org/buildbot/#builders/77/builds/1931/steps/4/logs/stdio >>> - warnings (8): https://builder.sourceware.org/buildbot/#builders/77/builds/1931/steps/4/logs/warnings__8_ >> >> ../../binutils-gdb/opcodes/i386-dis.c: In function ‘print_insn’: >> ../../binutils-gdb/opcodes/i386-dis.c:9865:22: error: storing the address of local variable ‘priv’ in ‘*info.private_data’ [-Werror=dangling-pointer=] >> 9865 | info->private_data = &priv; >> | ~~~~~~~~~~~~~~~~~~~^~~~~~~ >> ../../binutils-gdb/opcodes/i386-dis.c:9739:22: note: ‘priv’ declared here >> 9739 | struct dis_private priv; >> | ^~~~ >> ../../binutils-gdb/opcodes/i386-dis.c:9739:22: note: ‘info’ declared here >> cc1: all warnings being treated as errors >> make[3]: *** [Makefile:1071: i386-dis.lo] Error 1 >> >> Which, given that this hasn't changed in a while, makes me think that a >> new compiler was recently installed, which now diagnoses this supposed > > gcc-13, I expect. After having experimented a little with godbolt.org's help (before making the patch that you're now about to revert), I found that gcc12 is giving this warning, too (at least in simple cases). So it may really have been the removal of the unconditional OPCODES_SIGSETJMP() which has triggered the warning to appear - in my playing, any unconditional function call between the setting of the field and returning ended up masking the warning. Jan >> issue (and, btw, mis-diagnoses where "info" is declared). We can't do >> away with the assignment; it's unclear to me whether overwriting the >> field with NULL before returning would make a difference. > > It does. See my other email. > >> Dynamically >> allocating "priv" would be a theoretical option, but I don't view this as >> a good one in practice. >> >> Thoughts, anyone? >> >> Jan >