From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 8C11F3858D38 for ; Mon, 22 Apr 2024 07:15:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C11F3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8C11F3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713770130; cv=none; b=rfVU6ekpuZ2h0Xo3BecKyrlm4cUjmw5WOD5DEP7IsGUJ3iO5VC0D+FNxtQYDTPaD+3TB+F1P9IHSu8P0VG17WEHdts+ioAk4LtwKDEz6bU8BevrpI0ZT0Rm5p7DsCnYufWFD2Hyfqcmhjrfjg/NwfZY4uurpBTGbQ+CyD64hSuA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713770130; c=relaxed/simple; bh=AyAc1sSrMW3Znu0u65sPdBcP2h9XqZZFk2DwvZbjS7k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Jjmw3xciAane3QGiID1nGWlAUzyL1l9noJul2TIQmF/EdecjLEl0CvxNBrWP7HBBFQovEgR4b5css2SQqozpZt3wfTFUGvnq46o7VOM0TScogkXXW8rBNq3Uei51CMwBEbe4gzmieh8gZS9ccToEXQxL7PAps5jL2fKK1mgV11w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-41a7b6f22ebso2202795e9.0 for ; Mon, 22 Apr 2024 00:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1713770127; x=1714374927; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cW97IxxTofwdf49HM5CaRFA3M6dhxA+ThB+MdLHLQKc=; b=GoUFru3UMsBsN0YCgg6Oe41M/VjA0NSR1HGi6bejJVStZBYtqR/5cNVbtCx2dsQnmf YQtQYuiPmaoMWyhXabJb8WS819qJlF5ZaO6Pe8Kvdyp5WmVxLMDijc8mijNOtFKW3gSK 4aolTh6vHnYUC6T7+QuanSxkrhrlXLIB6qv4OfspFk9+CZWsN88J4J8UkcFX/06Jugb0 Vj14ZAJQDNcAaA1DtqiSBJNpOj5krH79nqApGQglZyKQ3+iWMG4L46h8m8k0Nm38Jyrt j6ZUGHlcaRqMiJVnInnjElJYkzCvEzQO+K7Aa1x1UQ06S/ndS3Ls5QzIsSBJR3voHOaB DE/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713770127; x=1714374927; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cW97IxxTofwdf49HM5CaRFA3M6dhxA+ThB+MdLHLQKc=; b=rEWSK3SHqjBAV9TOmWMljH/v8zstEUqxCfpoFZ3ofkya9WDsvU7eXkzMgJDADewfnR wnic4pD8eq9TMTsBWrLuRaTfVad+nyUd52B0dj6cQidrm136e/9V8L4WosEUhow9aN4T WGX4lu/i0JxLqh6EEBexRJ9mEdKOsNeLDGkOHxfM0B9/zwWN4UUGBdE630Jki0r3GzzV joQyumr6LWpDhzr0yE+jZqZ05nsHowPcE5ouX2UYEjjhvXJ+eJbIVBe8LK3MQJXNrmWB ZmW1uKunXOCWiAsvbkdUR97ejOpdQW7Mw3qBNoEp2cOq1YKdVwaV/Uf22oKoljxJmSd2 HUcQ== X-Gm-Message-State: AOJu0YwVgAZKXFv+RgknB2cTfpwMtT0Zigzbnb9Q1mH8haB9PMWInBbG BeKWPFioGwCkHs9thCS4avcrksSrxrBAjK32/NdhOwgBwEzwu2950J/pvKEAuA== X-Google-Smtp-Source: AGHT+IFrfZGsSy9pPR6njY92zT6iDe+0Wg5RqFvIa/7+SUlR4nx6CN3bFUd+BIkjyNeb+zuchjm2KQ== X-Received: by 2002:a05:600c:1e11:b0:415:540e:74e3 with SMTP id ay17-20020a05600c1e1100b00415540e74e3mr6038553wmb.40.1713770127000; Mon, 22 Apr 2024 00:15:27 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ay39-20020a05600c1e2700b0041a7a923502sm878420wmb.3.2024.04.22.00.15.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 00:15:26 -0700 (PDT) Message-ID: <0e96f101-0205-4644-98be-9e75528affe5@suse.com> Date: Mon, 22 Apr 2024 09:15:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] objcopy: check input flavor before setting PE/COFF section alignment Content-Language: en-US To: Nick Clifton References: Cc: Binutils From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.04.2024 12:37, Nick Clifton wrote: >> coff_section_data() and elf_section_data() use the same underlying >> field. The pointer being non-NULL therefore isn't sufficient to know >> that pei_section_data() can validly be used on the incoming object. >> Apparently in 64-bit-host builds the resulting memory corruption is >> benign, whereas in 32-bit-host builds a segmentation fault occurs upon >> de-referencing pei_section_data()'s return value. >> --- >> Of course the value (first) being set on the input bfd is suspicious >> in the first place: When copying e.g. ELF to PE/COFF, the option ought >> to be similarly respected, yet clearly it can't be set like this then on >> the incoming object. The change here is merely to address the testsuite >> failures observed for Arm64 and RISC-V ("Check if efi app format is >> recognized") as well as the (latent) memory corruption. > > Thanks for fixing my oversight! Well, before putting it in - any thoughts on the post-commit-message remark above? Is it really meant to stay the way of the input bfd's data is being altered, rather than keeping that intact and fiddling only with the output? And thus - afaict - rendering the command line option (silently) useless when copying ELF to PE? Jan