From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from t01.bc.larksuite.com (t01.bc.larksuite.com [209.127.231.13]) by sourceware.org (Postfix) with UTF8SMTPS id 3BEB33858C52 for ; Wed, 16 Aug 2023 06:15:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BEB33858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=oss.cipunited.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2303200042; d=oss.cipunited.com; t=1692166537; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=AJsE6cb5a2QYSnvL6FQd1a/PsCLZYWZp6dYz7KVffhU=; b=xb5oY2ecWI3XbHW7+HtTtwcixL31mfy6hdGJ/DDdprEmjbwMXOE7jvJN7+1A862bRrw1Mz dvByIhOUPHhoFAv3NPvlt4NmyITSmJ38sQrZzs2pM6R7E/Pt8Ud0E76hITbkWLqp4qAJf1 lsOAFo9t4SRI91XAaFAnf7Re1Y3rKtm7JH4wOxoDaLchgzfj77sK69WP37nmzJ4ONsNHZV 3CvvSmN/F5f8v5VQ+CEzzSaV0LpOMQPu4Uwn2KH27NU8ZqM7qPJpjh5lXUjp5AJ2aY/3zz 71v/2/r+TKELWNBlrJ9URwv8Mn2Dy1OdG1EJdJR1rMpdNAWoOYhUazirQRgmhw== From: "Ying Huang" Subject: Re: [PATCH v7] MIPS: Sync elf.h from binutils User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 In-Reply-To: Content-Transfer-Encoding: 8bit To: "Maciej W. Rozycki" , "Florian Weimer" Message-Id: <0e97b2ee-7116-8b86-8db9-8a438285af0b@oss.cipunited.com> Content-Language: en-US Content-Type: multipart/alternative; boundary=a9c9d2b4d96195a80862f687246433d055020b1440dcc44e0a8ba593c664 Date: Wed, 16 Aug 2023 14:15:33 +0800 X-Lms-Return-Path: X-Original-From: Ying Huang Mime-Version: 1.0 References: <20230807020524.2031213-1-ying.huang@oss.cipunited.com> <87leemerwd.fsf@oldenburg.str.redhat.com> <4d3d1518-364c-8374-9d3d-86d1afe25d62@oss.cipunited.com> <87r0odeust.fsf@oldenburg.str.redhat.com> <3d7f6d51-7d7f-cc7c-31b9-744dc06010fa@oss.cipunited.com> <87cyzxfugb.fsf@oldenburg.str.redhat.com> <87il9oywuh.fsf@oldenburg.str.redhat.com> Cc: "Richard Sandiford" , "libc-alpha" , , X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --a9c9d2b4d96195a80862f687246433d055020b1440dcc44e0a8ba593c664 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Maciej=EF=BC=8C =E5=9C=A8 2023/8/12 01:43, Maciej W. Rozycki =E5=86=99=E9=81=93: > Hi Florian, > > Cc-ing binutils now, to get a record of this discussion there. > >>> The EF_* definitions were added on top of preexisting E_* macros back = in=20 >>> 1998 by Ulrich Drepper with commit c3966b88eeb ("Update.") and only thi= s: >>> >>> * elf/elf.h: Add lots of new symbols from Irix and Solaris. >> My concern was adding EF_* constants to glibc that duplicate E_* >> constants that are used in binutils. I think we should either change >> binutils to use the EF_* constants, too, or for these legacy constants, >> use the E_* prefix in glibc as well. > It's not a problem: as long as we reach consensus I can update binutils= =20 > accordingly, and we can discard E_* constants from there at any time if=20 > needed as they are for BFD use only and we don't offer any stable BFD API. =C2=A0 Thanks for your detailed investigation.=C2=A0 If we use EF_MIPS_* in= glibc and update binutils, the places where all E_MIPS_* used would also be changed to EF_MIPS_*=EF=BC=9F Thanks, Ying >> Not sure if this a reasonable position, though. > So I did a little more research on this topic and came across this threa= d=20 > of mine from decades ago, and specifically this message coming from the=20 > lost world: .=20 > Clearly IRIX used to use EF_* macros, just as I thought and just as has=20 > used the Linux kernel (and MTI never came to finishing their promised=20 > psABI spec, where it only says "To be supplied" in the relevant part[1]). > > So while we may have to keep the few already existing in , just=20 > because we were unfortunate enough to make them a part of our API back in= =20 > 1996: > > * elf/elf.h: Add some new constants from recent Cygnus ELF > header files. > > having likely taken them as a Cygnus invention without due consideration,= =20 > I think we ought to refrain from adding new E_* macros and stick to EF_*= =20 > instead. > > NB the whole thread referred above might be worth reviewing for anyone=20 > interested in these matters. Here's a reference for the earlier part: > > as the discussion started on the old MIPS/Linux mailing lists first and=20 > then was carried over to binutils as well. > > References: > > [1] "MIPS ABIs Described", MIPS Technologies, Inc., Document Number:=20 > MD00305, Revision 1.3, 2002/12/02, Chapter 7. "ELF object code", p. 24 > > > Maciej= --a9c9d2b4d96195a80862f687246433d055020b1440dcc44e0a8ba593c664--