From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: Alexandre Oliva <aoliva@sourceware.org>
Subject: [PATCH v2 49/65] SH: use is_whitespace()
Date: Mon, 27 Jan 2025 17:37:37 +0100 [thread overview]
Message-ID: <0eb29372-3033-4687-92dc-9a68c75e7f0f@suse.com> (raw)
In-Reply-To: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com>
Wherever blanks are permissible in input, tabs ought to be permissible,
too. This is particularly relevant when -f is passed to gas (alongside
appropriate input). Also convert open-coded checks as well as an
ISSPACE() use. At the same time use is_end_of_stmt() instead of
(kind-of-)open-coded checks in adjacent code.
---
v2: New.
--- a/gas/config/tc-sh.c
+++ b/gas/config/tc-sh.c
@@ -1232,7 +1232,7 @@ get_operands (sh_opcode_info *info, char
/* The pre-processor will eliminate whitespace in front of '@'
after the first argument; we may be called multiple times
from assemble_ppi, so don't insist on finding whitespace here. */
- if (*ptr == ' ')
+ if (is_whitespace (*ptr))
ptr++;
get_operand (&ptr, operand + 0);
@@ -2151,7 +2151,7 @@ find_cooked_opcode (char **str_p)
unsigned int nlen = 0;
/* Drop leading whitespace. */
- while (*str == ' ')
+ while (is_whitespace (*str))
str++;
/* Find the op code end.
@@ -2159,9 +2159,8 @@ find_cooked_opcode (char **str_p)
any '@' after the first argument; we may be called from
assemble_ppi, so the opcode might be terminated by an '@'. */
for (op_start = op_end = (unsigned char *) str;
- *op_end
- && nlen < sizeof (name) - 1
- && !is_end_of_line[*op_end] && *op_end != ' ' && *op_end != '@';
+ nlen < sizeof (name) - 1
+ && !is_end_of_stmt (*op_end) && !is_whitespace (*op_end) && *op_end != '@';
op_end++)
{
unsigned char c = op_start[nlen];
@@ -2515,10 +2514,11 @@ md_assemble (char *str)
bool found = false;
/* Identify opcode in string. */
- while (ISSPACE (*name))
+ while (is_whitespace (*name))
name++;
- while (name[name_length] != '\0' && !ISSPACE (name[name_length]))
+ while (!is_end_of_stmt (name[name_length])
+ && !is_whitespace (name[name_length]))
name_length++;
/* Search for opcode in full list. */
@@ -2577,7 +2577,7 @@ md_assemble (char *str)
{
/* Ignore trailing whitespace. If there is any, it has already
been compressed to a single space. */
- if (*op_end == ' ')
+ if (is_whitespace (*op_end))
op_end++;
}
else
next prev parent reply other threads:[~2025-01-27 16:37 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 15:23 [PATCH v2 00/65] gas: whitespace handling Jan Beulich
2025-01-27 15:26 ` [PATCH v2 01/65] gas: consolidate whitespace recognition Jan Beulich
2025-01-31 6:02 ` Hans-Peter Nilsson
2025-01-31 8:36 ` Jan Beulich
2025-01-27 15:27 ` [PATCH v2 02/65] gas/obj-*.c: use is_whitespace() Jan Beulich
2025-01-27 15:43 ` [PATCH v2 03/65] Alpha/EVAX: use is_whitespace() / is_end_of_stmt() Jan Beulich
2025-01-27 15:44 ` [PATCH v2 04/65] arc: use is_whitespace() Jan Beulich
2025-01-27 15:50 ` [PATCH v2 05/65] Arm: " Jan Beulich
2025-01-27 16:31 ` Richard Earnshaw (lists)
2025-01-27 16:55 ` Jan Beulich
2025-01-27 17:05 ` Richard Earnshaw (lists)
2025-01-27 15:50 ` [PATCH v2 06/65] aarch64: " Jan Beulich
2025-01-27 16:31 ` Richard Earnshaw (lists)
2025-01-27 16:06 ` [PATCH v2 07/65] avr: " Jan Beulich
2025-01-27 16:07 ` [PATCH v2 08/65] bfin: " Jan Beulich
2025-01-27 16:08 ` [PATCH v2 09/65] bpf: " Jan Beulich
2025-01-28 9:21 ` Alan Modra
2025-01-28 10:31 ` Jan Beulich
2025-01-27 16:09 ` [PATCH v2 10/65] CR16: " Jan Beulich
2025-01-27 16:10 ` [PATCH v2 11/65] cris: " Jan Beulich
2025-01-27 16:22 ` Hans-Peter Nilsson
2025-01-27 16:12 ` [PATCH v2 12/65] CRx: " Jan Beulich
2025-01-27 16:13 ` [PATCH v2 13/65] C-Sky: " Jan Beulich
2025-01-27 16:14 ` [PATCH v2 14/65] d10v: " Jan Beulich
2025-01-27 16:14 ` [PATCH v2 15/65] d30v: " Jan Beulich
2025-01-27 16:15 ` [PATCH v2 16/65] dlx: " Jan Beulich
2025-01-27 16:16 ` [PATCH v2 17/65] Epiphany: " Jan Beulich
2025-01-27 16:17 ` [PATCH v2 18/65] fr30: " Jan Beulich
2025-01-27 16:19 ` [PATCH v2 19/65] ft32: " Jan Beulich
2025-01-27 16:20 ` [PATCH v2 20/65] H8/300: " Jan Beulich
2025-01-27 16:20 ` [PATCH v2 21/65] HP-PA: " Jan Beulich
2025-01-27 22:50 ` John David Anglin
2025-01-28 7:19 ` Jan Beulich
2025-01-28 18:19 ` John David Anglin
2025-01-27 16:21 ` [PATCH v2 22/65] kvx: " Jan Beulich
2025-01-31 12:34 ` Paul Iannetta
2025-01-27 16:22 ` [PATCH v2 23/65] LoongArch: " Jan Beulich
2025-01-27 16:23 ` [PATCH v2 24/65] m32c: " Jan Beulich
2025-01-27 16:23 ` [PATCH v2 25/65] m32r: " Jan Beulich
2025-01-27 16:24 ` [PATCH v2 26/65] M68HC1x: " Jan Beulich
2025-01-27 16:25 ` [PATCH v2 27/65] M68k: " Jan Beulich
2025-01-27 16:25 ` [PATCH v2 28/65] M*Core: " Jan Beulich
2025-01-27 16:26 ` [PATCH v2 29/65] metag: " Jan Beulich
2025-01-27 16:26 ` [PATCH v2 30/65] MicroBlaze: " Jan Beulich
2025-01-29 23:56 ` Michael Eager
2025-01-27 16:28 ` [PATCH v2 31/65] MIPS: " Jan Beulich
2025-02-03 14:07 ` Maciej W. Rozycki
2025-02-03 15:52 ` Jan Beulich
2025-02-03 17:50 ` Maciej W. Rozycki
2025-02-10 22:17 ` Maciej W. Rozycki
2025-01-27 16:28 ` [PATCH v2 32/65] MMIX: " Jan Beulich
2025-01-31 6:18 ` Hans-Peter Nilsson
2025-01-31 6:33 ` Hans-Peter Nilsson
2025-01-31 6:54 ` Jan Beulich
2025-01-31 7:05 ` Hans-Peter Nilsson
2025-02-03 6:54 ` Hans-Peter Nilsson
2025-02-03 7:30 ` Jan Beulich
2025-02-05 6:22 ` Hans-Peter Nilsson
2025-02-05 7:14 ` Jan Beulich
2025-01-27 16:29 ` [PATCH v2 33/65] mn10200: " Jan Beulich
2025-01-27 16:29 ` [PATCH v2 34/65] mn10300: " Jan Beulich
2025-02-07 6:55 ` Alexandre Oliva
2025-01-27 16:30 ` [PATCH v2 35/65] Moxie: " Jan Beulich
2025-01-27 16:31 ` [PATCH v2 36/65] msp430: " Jan Beulich
2025-01-27 16:31 ` [PATCH v2 37/65] nds32: " Jan Beulich
2025-01-27 16:32 ` [PATCH v2 38/65] NS32k: " Jan Beulich
2025-01-27 16:32 ` [PATCH v2 39/65] PDP11: " Jan Beulich
2025-01-27 16:33 ` [PATCH v2 40/65] PicoJava: " Jan Beulich
2025-01-27 16:33 ` [PATCH v2 41/65] PPC: " Jan Beulich
2025-01-27 22:36 ` Peter Bergner
2025-01-27 16:34 ` [PATCH v2 42/65] pru: " Jan Beulich
2025-01-27 16:34 ` [PATCH v2 43/65] RISC-V: " Jan Beulich
2025-01-27 16:35 ` [PATCH v2 44/65] rl78: " Jan Beulich
2025-01-27 16:35 ` [PATCH v2 45/65] rx: " Jan Beulich
2025-01-27 16:36 ` [PATCH v2 46/65] s12z: " Jan Beulich
2025-01-27 16:36 ` [PATCH v2 47/65] S/390: " Jan Beulich
2025-01-30 8:38 ` Jens Remus
2025-01-30 9:11 ` Jan Beulich
2025-01-27 16:37 ` [PATCH v2 48/65] Score: " Jan Beulich
2025-01-27 16:37 ` Jan Beulich [this message]
2025-02-07 6:54 ` [PATCH v2 49/65] SH: " Alexandre Oliva
2025-01-27 16:38 ` [PATCH v2 50/65] Sparc: " Jan Beulich
2025-01-27 16:38 ` [PATCH v2 51/65] spu: " Jan Beulich
2025-01-27 16:39 ` [PATCH v2 52/65] C30: " Jan Beulich
2025-01-27 16:40 ` [PATCH v2 53/65] C4x: " Jan Beulich
2025-01-27 16:40 ` [PATCH v2 54/65] C54x: " Jan Beulich
2025-01-27 16:41 ` [PATCH v2 55/65] C6x: " Jan Beulich
2025-01-27 16:42 ` [PATCH v2 56/65] v850: " Jan Beulich
2025-01-27 16:42 ` [PATCH v2 57/65] VAX: " Jan Beulich
2025-01-27 20:46 ` Jan-Benedict Glaw
2025-01-27 16:43 ` [PATCH v2 58/65] Visium: " Jan Beulich
2025-01-27 16:43 ` [PATCH v2 59/65] wasm32: " Jan Beulich
2025-01-27 16:44 ` [PATCH v2 60/65] x86: " Jan Beulich
2025-01-27 16:45 ` [PATCH v2 61/65] xgate: " Jan Beulich
2025-01-27 16:45 ` [PATCH v2 62/65] Xtensa: " Jan Beulich
2025-01-27 16:46 ` [PATCH v2 63/65] Z80: " Jan Beulich
2025-01-27 16:46 ` [PATCH v2 64/65] Z8k: " Jan Beulich
2025-01-30 10:16 ` Christian Groessler
2025-01-27 16:47 ` [PATCH v2 65/65] gas: suppress use of ISSPACE() / ISBLANK() Jan Beulich
2025-01-28 2:50 ` [PATCH v2 00/65] gas: whitespace handling Hans-Peter Nilsson
2025-01-28 7:40 ` Jan Beulich
2025-01-28 14:47 ` Richard Earnshaw (lists)
2025-01-28 15:00 ` Jan Beulich
2025-01-28 15:27 ` Richard Earnshaw (lists)
2025-01-28 15:25 ` Hans-Peter Nilsson
2025-01-28 9:59 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eb29372-3033-4687-92dc-9a68c75e7f0f@suse.com \
--to=jbeulich@suse.com \
--cc=aoliva@sourceware.org \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).