public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Takis Psarogiannakopoulos <takis@XFree86.Org>, kevinb@redhat.com
Cc: msnyder@redhat.com, gdb@sources.redhat.com, binutils@sources.redhat.com
Subject: Re: RE:Re: GDB 5.1/Core files and ptids (CONT)
Date: Mon, 21 Jan 2002 16:20:00 -0000	[thread overview]
Message-ID: <1020121183542.ZM1640@localhost.localdomain> (raw)
In-Reply-To: Takis Psarogiannakopoulos <takis@XFree86.Org> "RE:Re: GDB 5.1/Core files and ptids (CONT)" (Jan 20,  9:19am)

On Jan 20,  9:19am, Takis Psarogiannakopoulos wrote:

> [...] Below is what I worked out for GDB 5.1.
> It will patch elf.c and corelow.c. according to your suggestions.
> If this is acceptable someone should check it in at least for
> the upcoming GDB 5.x.x.

Takis,

I looked your patch over and it looks pretty good except that it's
reversed.  (When you did the diff, you did ``diff -c new old'' rather
than ``diff -c old new''.)  Could you please resend your patch in
the non-reversed form.  It'll make it easier to review.

Oh... also, could you include ChangeLog entries this time?

Thanks,

Kevin

P.S.  I'm not the maintainer of any of the files in question, so
someone else will need to approve Takis' changes.

  reply	other threads:[~2002-01-21 18:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-20 11:20 Takis Psarogiannakopoulos
2002-01-21 16:20 ` Kevin Buettner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-01-18  9:06 Takis Psarogiannakopoulos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1020121183542.ZM1640@localhost.localdomain \
    --to=kevinb@redhat.com \
    --cc=binutils@sources.redhat.com \
    --cc=gdb@sources.redhat.com \
    --cc=msnyder@redhat.com \
    --cc=takis@XFree86.Org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).