From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 14AF93858D32 for ; Mon, 7 Nov 2022 11:13:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14AF93858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667819616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a3iCcS5cboIXMAhGYs8OYNb1YbKGq/vo+8LVEYhribQ=; b=Q3sKwNCfgJDBRBYCTzAPSmkXWuMNQgFcpLZVMDFyPSbhEz8RQkHEB2bjpxFR7MhZyqqZhh /9mw/deNWC6SO1OuU3I1hkAsiwVumD69e7DwtgQMMzJ3ilunjyIoVgVqIphgTXF9hYC9k/ dmoaISPBDUGCqlmBtyQ9hsBn2NCQIy8= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-596-ycLJUdCiPj-uKSidkBM-Rg-1; Mon, 07 Nov 2022 06:13:35 -0500 X-MC-Unique: ycLJUdCiPj-uKSidkBM-Rg-1 Received: by mail-qt1-f198.google.com with SMTP id f4-20020a05622a114400b003a57f828277so2867904qty.22 for ; Mon, 07 Nov 2022 03:13:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a3iCcS5cboIXMAhGYs8OYNb1YbKGq/vo+8LVEYhribQ=; b=Cjt6ywhqfOle1N43aNSMhcvQw/M53X5wQnI+S0GpZVYSHr4eBBLQiNC7kRBmiugnXp yFS1Dders4Ez6awwx0LK2ixZ4YQLUia+HzvjiOdbseyDr/3ixpFvznpPZuhyUmsVDwFG 3GlCxbzMppI3gJPzChdVXjmR/KTF+bjk9E+W42vScFSG696ryH4k70RKr2glCfNBDH1P LfvOlPQg0gHzlhdmFj3BMjdx8TTQG4tbbG2CSDPLHhhFrIeo3nc5/69gFY2pezr3FIv+ 7oaWXNYl4eVcOH6yxQGzhbDXWB3rAFZ7qp5g7dRGgA3zAVhUI6/szR56kcWXU7aR6nN/ e82A== X-Gm-Message-State: ACrzQf1w9PutBMGjaAyB4QDJ2jWnQM8QGo38PKXdqgaqVNrgVhkqXzm6 MD09UKf3hPN5UzbB5D/WiaVCoimBLwKua9/szqOssLalkrFOp/ZfFfTYTfYQdKA6HMoj92z+N1x GkE0mPiXi9YxGtOiK+A== X-Received: by 2002:ac8:7493:0:b0:3a5:287b:d6c8 with SMTP id v19-20020ac87493000000b003a5287bd6c8mr31501344qtq.241.1667819614594; Mon, 07 Nov 2022 03:13:34 -0800 (PST) X-Google-Smtp-Source: AMsMyM6xduysAMVDUHfOESSPoaeBCPRPdYyBFayLnzKoi3OOShEHnBQVflSFcqXW2qtMSqnhILXAsw== X-Received: by 2002:ac8:7493:0:b0:3a5:287b:d6c8 with SMTP id v19-20020ac87493000000b003a5287bd6c8mr31501338qtq.241.1667819614419; Mon, 07 Nov 2022 03:13:34 -0800 (PST) Received: from [192.168.1.18] (adsl-164-85.freeuk.com. [80.168.164.85]) by smtp.gmail.com with ESMTPSA id fw9-20020a05622a4a8900b003a56d82fd8csm5790534qtb.91.2022.11.07.03.13.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 03:13:34 -0800 (PST) Message-ID: <1023be3d-a0ea-7c0a-c7a7-956c80e4ec35@redhat.com> Date: Mon, 7 Nov 2022 11:13:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] ld/testsuite: skip tests related to -shared when disabled To: =?UTF-8?Q?Cl=c3=a9ment_Chigot?= , binutils@sourceware.org References: <20221104163328.2274371-1-chigot@adacore.com> From: Nick Clifton In-Reply-To: <20221104163328.2274371-1-chigot@adacore.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Clément, > Call the helper function "check_shared_lib_support" to ensure -shared > is enabled before launching ld-shared, ld-elfweak and ld-elfvers. > This allows to catch custom targets explicitly disabling it. > > ld/ChangeLog: > > * testsuite/ld-elfvers/vers.exp: Call check_shared_lib_support. > * testsuite/ld-elfweak/elfweak.exp: Likewise. > * testsuite/ld-shared/shared.exp: Likewise. Approved, please apply. Cheers Nick