From: Luis Machado <luis.machado@arm.com>
To: "Nick Clifton" <nickc@redhat.com>,
"Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
binutils@sourceware.org
Subject: Re: [PATCH] bfd: Define func prototype for old mingw
Date: Tue, 16 Aug 2022 18:09:43 +0100 [thread overview]
Message-ID: <10331827-6341-3bed-103c-6d8b55f82c4f@arm.com> (raw)
In-Reply-To: <7492551a-3f20-1a37-5c8e-6152d1df15fd@redhat.com>
On 8/16/22 15:18, Nick Clifton wrote:
> Hi Torbjörn,
>
>> diff --git a/bfd/bfdio.c b/bfd/bfdio.c
>> index a7c7d5bd363..59f79203b88 100644
>> --- a/bfd/bfdio.c
>> +++ b/bfd/bfdio.c
>> @@ -29,6 +29,11 @@
>> #if defined (_WIN32)
>> #include <windows.h>
>> #include <locale.h>
>> +
>> +#if defined(__MINGW64_VERSION_MAJOR) && __MINGW64_VERSION_MAJOR < 9
>> +/* This prototype was added to locale.h in version 9.0 of MinaGW-w64. */
>> +_CRTIMP unsigned int __cdecl ___lc_codepage_func(void);
>> +#endif
>> #endif
>> #ifndef S_IXUSR
>
> Approved - please apply.
>
> Cheers
> Nick
>
Pushed on Torbjörn's behalf.
Thanks for the patch.
prev parent reply other threads:[~2022-08-16 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 8:49 Torbjörn SVENSSON
2022-08-15 10:01 ` Luis Machado
2022-08-15 10:19 ` Torbjorn SVENSSON
2022-08-16 14:18 ` Nick Clifton
2022-08-16 17:09 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10331827-6341-3bed-103c-6d8b55f82c4f@arm.com \
--to=luis.machado@arm.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).