From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2087.outbound.protection.outlook.com [40.107.20.87]) by sourceware.org (Postfix) with ESMTPS id A4A6F3858C56 for ; Fri, 1 Jul 2022 10:18:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4A6F3858C56 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HbH6/EiMZgD0qMP78SKCE9WcrXlnXZuHPIKIMTC0JUWCn0BsStUgReP6mfFNS7xmnClzDtVQnJxC11MO1xf2eMIMj09+/ETotB4QfGcPaLK9g82kmT8L0d3MNa3azha0szcFWsZGPUfNO8Sax4p7Wp8o0DUbGtVLrZHVouWfRvuVndl0ANkTMDgrOeYpFBWO3GlTDBWiy76qS3rcdBd7fqctZ+7ZSdgctodZixBJ5/Qc+okW6/n3RUK9OiJTYAg4NhvxHY3JLqlQvX9qXdkdLH/GH9G+8Wz+U1DoFvj71mC6PDGQ6XGWen7SSYwEnHiwAagFLeni6vpSAjOLgfOtlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0og5/1hRX5pviJPkYLKqLcbOztLad0ai4BT3K8/jies=; b=NO4qma+1ZTvM0yak7CuRSQHGI0LRtCufVo7+gf7Mvx384NtzB/ZquHrrc8Yr6j4rZ7v+mjzPcvRs9pQ3oHcSdyyvaigXr7WlKBFLwFD4GnYTYJe3Bt/17QVDFxaYD+TrVKx9nSBD/scF65EdWG3L5BKiU677hs9qkBaq+eKXPvWjnU16ZafrBX0lyA+S/d/i7acSeFrwzG6nNRvWQvaosDp3aZzHtIZNR7nP7baJ/j/z/I9AUK28hNxjSlAqvn2Ih+00D1Kemb+AuAckwzGSaYiR2q6zvv6BNLv/Je3/Kgwjjq8Rf2IvjfTj7jAtcHnJYYoLF+Y9fx5W2I15RcGlJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0402MB2759.eurprd04.prod.outlook.com (2603:10a6:4:a2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 10:18:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 10:18:08 +0000 Message-ID: <1041c98c-a2a4-af7d-5872-cded045f1a60@suse.com> Date: Fri, 1 Jul 2022 12:18:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/7] x86: don't leak sub-architecture accumulated strings Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <01f502ff-5b51-86d3-ed54-646df7d22037@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bc48ee7-0983-45c5-974f-08da5b4afeb0 X-MS-TrafficTypeDiagnostic: DB6PR0402MB2759:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kap77oYlC9QPteayGolkL7+RMbCbxqlR7IQLHq1dgFSGELuVMtlbS0ZfJo0MXAnPQp4O0BNjzlgomFHsJ1wuWOxsCyhRPg1pk1b+Rg25cxIbQBM4iFTELGCiZS5IdplWDjY5XHcImdCmxZ2cHuEpxdi2ldglbX3aWHHDOjqh/Mn4Y0TRMREBn4ymy5F3WSOGTdvkY5va9U6DW6w8pNO8eRPkgE9kEUtu+kr7E3K/h/5myvN9EhDF1pWy+F8YVx6QUINKdq0w/WgfL0hmEYC+tqkgvTgeR8d5D0YNGek7slZqVe7yrSVqxVyqPjAROEwrk0n1MwVmUXecMJqeKM2yDkeCr98uK2ybx5zWgH66yu+Qc/IvFEzY2auGTNMcm+vG/qNXgHq09nNBFef4yDx5n6+czfgsS5zKMKuh3tOVvo9Zcgprb2ye8s2a4plgDXi2/z1OXf/0lR++PQ9FLEwD/KpTPT3zn176EeTl1KG0uZ3Vqf+wBrKbfFyXcrqt76GMEdizw95bcmSyWbUbXBh+prAoHT58Ltq62RlgK1VeidW+3PngSw4PPp7Q/AeZInW+PliJctSOjDDCKRO0wH8GwDRa/pEWyvAr1duperRLMJuXUt8FmzJLdRKEa8S3v8b/MvhG+GrtNBEakGLOgGUK/Nd/NyJfYtmxbZqECvBdcHYx5wwAenMflfmEbV4/ltdPQOc/MItHkQV3y0Kzmrf+xmK3xkGyhWLuWwG6/NxpEkKL92FIwv6RAGdf6CtPlhaLllYPb7+aoVNCwVYX7N9GY7t3Hg/d7XHkIrI2KiLZf7lOnzqO2exkHwomeh9Ms7fG3magzOKq+3jAr9P+cc5ScAC7REJbGPRg7oROqYfSiLk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(136003)(396003)(366004)(39860400002)(376002)(5660300002)(6486002)(478600001)(8936002)(83380400001)(186003)(2616005)(41300700001)(2906002)(26005)(6512007)(31696002)(53546011)(86362001)(36756003)(316002)(66946007)(38100700002)(31686004)(6506007)(8676002)(6916009)(66476007)(66556008)(4326008)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmdqdU9HRHlBSnhqbFVhRDN0NWVSWlN0N29pY3JqZ0R3Um80dlRxdjYvYmpG?= =?utf-8?B?WE4zcEVrSDBzUitXa01TdkNIRkVxZysvNS9nYXVkWFVoYlRGUmhvZ2ZFaTBJ?= =?utf-8?B?cStIMXd5WEJ4UHNMQ0U3YUVmQUZiY2twSHhJbWhadXZVUjhpZC9KRjdJQlAy?= =?utf-8?B?eFZrcENIM3pLLzlMVlp0TEs3RHYraWhEZm5IZ2VJK1QzRWZLMEl3d3oxbEE5?= =?utf-8?B?dTljYWlBSUtBUm9EMnRYOWtiUEN4YjUyZ2FMWWYvcXlSSnluT1BzUngraFAz?= =?utf-8?B?WDZ3MXkwRUlSakpOM0M0aUFrUTJ2K0RJLzNET0k4Q1ZmdXZNZnBWd2NzTzFV?= =?utf-8?B?MTNGRmV1VXZnYnl4UmQrQmpIdll5NXhWVk9FazQ5NTdqUVVtUnJlS0lzejYw?= =?utf-8?B?QVZPdVdpQXlmRGxycU5YYVBNQXNCa2h2Ym5jZEJzSEhqOWo4TjVNRVlKcHNy?= =?utf-8?B?NldhMHVmbFVoYUhCVG1KbGJhdVNVZUFxNk9CTWt4QTBaZHlnYTdBTFR2RnlY?= =?utf-8?B?TU0xbTI5SUlTaVBHZG5TKzRtVXQ1ZGFMQ3duQUdBMnRVWlZFUlFpeXpMc0ZW?= =?utf-8?B?RmRiaE5HTjJJZzBoTGpYV0NJL0IySjExd0V6U0o1VVowTkVFbzRaTFRQUE5n?= =?utf-8?B?M0k1NUp4M0NpbTNSS1ZTZVljQjFKOUxXLzk1S25kaElvZHNEaVdRNUgzSHVM?= =?utf-8?B?bzlOR1AvNTRiVzlDVkZwcDM5d0dlUFdCTnJCRzVvU3IxMGNTYjhCRWluWFNY?= =?utf-8?B?dExpaUkrUFlGeWJ5eCtSOUhuVTFady8xWFRKNDNCOEFzZGt6T3pFTjVJKzhO?= =?utf-8?B?M2xoOWppMVMyaGR1L1JBa1h0UkMrWFZyKzRBVnJ4aFlVNlFpcWJZRkJka3dr?= =?utf-8?B?bEdwejViY01CNnlMTGI1c3EzdDdnZWhJbEI3UE5zbVc3ek50YnltVGRoNTZj?= =?utf-8?B?K0JsMmdIVW01TXIwT1ZmRm1yUllJOWRkbkpiOTE1OXFzZlEwbDU1WFR2VjRl?= =?utf-8?B?Yktta1VpMnFvN0EwcklRQ3BZbmIvYW9PMTF3TU9GcTRzR2creGNtYWhqbzEx?= =?utf-8?B?cDBzU0ZZbTJLV0VhSGVNeFozQzNmM3daK3I1MEh1aVBHRG1ZMHhyaTVEbzRy?= =?utf-8?B?aWFPb25uSitUSnV4SVJiVVdBYUs4NXIyeUtUZnJnT3ZTSmd1U1d5RHhMeXF2?= =?utf-8?B?YmhGWEpoYk9Obit1YUJCSHl3Y2RadzhVRUo1S2p6K2VQZ1gveVI3eWd1cG5O?= =?utf-8?B?SHViVko1Z1JwSVBPSlRzTlJkbWZsQzdjRnlsYm11d1lNV3NDMmNaRlYrZ21R?= =?utf-8?B?dlBMRFY4M1ZidGYrN3EvZWM0S0M2b0ZxUzVEeDdxVFRZaDNZVUZnN1RKMGpU?= =?utf-8?B?bHVxekFSTmR3azE1SURQYlplZnpVdnVZalJndHlDemUvQ3gyL0JZdkFvell1?= =?utf-8?B?M1d5c0FCMW5ScDVMRWhTZlhOd1dCRlJHczAwTnFnME9kSCtqaWh2MDBia29N?= =?utf-8?B?UTVTQTRsdllYcElnVmlveENvbzNWRWp3OWMydDU3RUJ0WUtqbU1tR0dhUk04?= =?utf-8?B?d2I0MUtjcUtzTnQyMkJObkFDU0tudkRvbk9YWVVuUDg1ZzlaVTlmYy8vRWhi?= =?utf-8?B?R1JHWmNZeFVjUGFKTCtZVVlyVWU4Mmd4OVZsVGNSRDcxblk4ZUlyQUE0RHlL?= =?utf-8?B?cHdKalBxanBzOHZwTFBNUUJPZC9MM3duVFlnMnRCUUFjdWQrK0ozZUlLUUgx?= =?utf-8?B?eGliTUFGN05oeHpDZDhLakVTMldiVUhPcURJa1ZoLy9rdVl6RVlDUGRTT0xn?= =?utf-8?B?TTU5aUVrajd2M2RmSFo5cEY2UmswMEZWRGJicHZEblVwQzRpVnZwdEQxNGlG?= =?utf-8?B?Ty9QZHlVanRaeS9MdTljYzlFVFNscmVocEVCYml3MlN6SXBDNjN4WnJjKzlS?= =?utf-8?B?SmJBUjBVREtsQjBSaU96T2NYSytTaUZuVTgwSzRxeXp6SGY0V1dQWVVuT2pD?= =?utf-8?B?MXp4U1dUYVBUSm5iOHNsdDI5Mm5zZkFUTXlZNCtLTFRVSDB4UFp6YlBQdDhM?= =?utf-8?B?YW94anRMN3lsaTJGZkMxUTFtMWs1a2tsNFk4Yi9mQWhZTGcxMUN0d2dVOUFX?= =?utf-8?Q?2UKRsh50z/QRe7JwHSIM0J88f?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bc48ee7-0983-45c5-974f-08da5b4afeb0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 10:18:08.8164 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aoCVO9bbnMLM0+HlPL7onan4Ni+MHMecrn7Zu/4QbUNubd2cwflUcBJGQIkbdVRpqwJbyyiUF8Jbwifi26Gdtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2759 X-Spam-Status: No, score=-3030.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2022 10:18:13 -0000 On 01.07.2022 00:54, H.J. Lu wrote: > On Thu, Jun 30, 2022 at 5:53 AM Jan Beulich wrote: >> --- a/gas/config/tc-i386.c >> +++ b/gas/config/tc-i386.c >> @@ -2871,6 +2871,7 @@ set_cpu_arch (int dummy ATTRIBUTE_UNUSED >> check_cpu_arch_compatible (string, cpu_arch[j].flags); >> >> cpu_arch_name = cpu_arch[j].name; >> + xfree (cpu_sub_arch_name); >> cpu_sub_arch_name = NULL; >> cpu_arch_flags = cpu_arch[j].flags; >> if (flag_code == CODE_64BIT) >> @@ -13406,6 +13407,7 @@ md_parse_option (int c, const char *arg) >> continue; >> >> cpu_arch_name = cpu_arch[j].name; >> + xfree (cpu_sub_arch_name); >> cpu_sub_arch_name = NULL; >> cpu_arch_flags = cpu_arch[j].flags; >> cpu_arch_isa = cpu_arch[j].type; >> @@ -14086,6 +14088,7 @@ i386_target_format (void) >> { >> static const i386_cpu_flags iamcu_flags = CPU_IAMCU_FLAGS; >> cpu_arch_name = "iamcu"; >> + xfree (cpu_sub_arch_name); >> cpu_sub_arch_name = NULL; >> cpu_arch_flags = iamcu_flags; >> cpu_arch_isa = PROCESSOR_IAMCU; >> > > Can we just use free? In principle yes, but I view using free() as inconsistent when the allocation used xmalloc() or alike. These should pair, even if right now xfree() simply aliases to free() - this could change down the road, and then cause unnecessary code churn just to update all such instances. Jan