* [PATCH] MIPS gas: Remove non-BFD_ASSEMBLER cases
@ 2003-03-02 23:29 Thiemo Seufer
2003-03-02 23:37 ` Thiemo Seufer
0 siblings, 1 reply; 3+ messages in thread
From: Thiemo Seufer @ 2003-03-02 23:29 UTC (permalink / raw)
To: binutils
Hello All,
the MIPS gas is always a BFD Assembler.
2003-03-03 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
/gas/ChangeLog
* config/tc-mips.c (s_mips_end): Remove !BFD_ASSEMBLER case.
(s_mips_ent): Likewise.
--- source-orig/gas/config/tc-mips.c Mon Mar 3 00:23:15 2003
+++ source/gas/config/tc-mips.c Mon Mar 3 00:20:39 2003
@@ -14252,17 +14252,10 @@ s_mips_end (x)
else
p = NULL;
-#ifdef BFD_ASSEMBLER
if ((bfd_get_section_flags (stdoutput, now_seg) & SEC_CODE) != 0)
maybe_text = 1;
else
maybe_text = 0;
-#else
- if (now_seg != data_section && now_seg != bss_section)
- maybe_text = 1;
- else
- maybe_text = 0;
-#endif
if (!maybe_text)
as_warn (_(".end not in text section"));
@@ -14346,17 +14339,10 @@ s_mips_ent (aent)
|| *input_line_pointer == '-')
get_number ();
-#ifdef BFD_ASSEMBLER
if ((bfd_get_section_flags (stdoutput, now_seg) & SEC_CODE) != 0)
maybe_text = 1;
else
maybe_text = 0;
-#else
- if (now_seg != data_section && now_seg != bss_section)
- maybe_text = 1;
- else
- maybe_text = 0;
-#endif
if (!maybe_text)
as_warn (_(".ent or .aent not in text section."));
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS gas: Remove non-BFD_ASSEMBLER cases
2003-03-02 23:29 [PATCH] MIPS gas: Remove non-BFD_ASSEMBLER cases Thiemo Seufer
@ 2003-03-02 23:37 ` Thiemo Seufer
2003-03-06 17:45 ` Eric Christopher
0 siblings, 1 reply; 3+ messages in thread
From: Thiemo Seufer @ 2003-03-02 23:37 UTC (permalink / raw)
To: binutils
Thiemo Seufer wrote:
> Hello All,
>
> the MIPS gas is always a BFD Assembler.
.. and a bit of code cleanup is good also.
Thiemo
2003-03-03 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
/gas/ChangeLog
* config/tc-mips.c (s_mips_end): Remove !BFD_ASSEMBLER case.
(s_mips_ent): Likewise.
--- source-orig/gas/config/tc-mips.c Mon Mar 3 00:23:15 2003
+++ source/gas/config/tc-mips.c Mon Mar 3 00:34:27 2003
@@ -14238,7 +14238,6 @@ s_mips_end (x)
int x ATTRIBUTE_UNUSED;
{
symbolS *p;
- int maybe_text;
/* Following functions need their own .frame and .cprestore directives. */
mips_frame_reg_valid = 0;
@@ -14252,19 +14251,7 @@ s_mips_end (x)
else
p = NULL;
-#ifdef BFD_ASSEMBLER
- if ((bfd_get_section_flags (stdoutput, now_seg) & SEC_CODE) != 0)
- maybe_text = 1;
- else
- maybe_text = 0;
-#else
- if (now_seg != data_section && now_seg != bss_section)
- maybe_text = 1;
- else
- maybe_text = 0;
-#endif
-
- if (!maybe_text)
+ if ((bfd_get_section_flags (stdoutput, now_seg) & SEC_CODE) == 0)
as_warn (_(".end not in text section"));
if (!cur_proc_ptr)
@@ -14336,7 +14323,6 @@ s_mips_ent (aent)
int aent;
{
symbolS *symbolP;
- int maybe_text;
symbolP = get_symbol ();
if (*input_line_pointer == ',')
@@ -14346,19 +14332,7 @@ s_mips_ent (aent)
|| *input_line_pointer == '-')
get_number ();
-#ifdef BFD_ASSEMBLER
- if ((bfd_get_section_flags (stdoutput, now_seg) & SEC_CODE) != 0)
- maybe_text = 1;
- else
- maybe_text = 0;
-#else
- if (now_seg != data_section && now_seg != bss_section)
- maybe_text = 1;
- else
- maybe_text = 0;
-#endif
-
- if (!maybe_text)
+ if ((bfd_get_section_flags (stdoutput, now_seg) & SEC_CODE) == 0)
as_warn (_(".ent or .aent not in text section."));
if (!aent && cur_proc_ptr)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS gas: Remove non-BFD_ASSEMBLER cases
2003-03-02 23:37 ` Thiemo Seufer
@ 2003-03-06 17:45 ` Eric Christopher
0 siblings, 0 replies; 3+ messages in thread
From: Eric Christopher @ 2003-03-06 17:45 UTC (permalink / raw)
To: Thiemo Seufer; +Cc: binutils
>
> Thiemo
>
>
> 2003-03-03 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> /gas/ChangeLog
> * config/tc-mips.c (s_mips_end): Remove !BFD_ASSEMBLER case.
> (s_mips_ent): Likewise.
>
OK.
-eric
--
o/~ Cry havoc... o/~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-03-06 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-02 23:29 [PATCH] MIPS gas: Remove non-BFD_ASSEMBLER cases Thiemo Seufer
2003-03-02 23:37 ` Thiemo Seufer
2003-03-06 17:45 ` Eric Christopher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).