From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10058.outbound.protection.outlook.com [40.107.1.58]) by sourceware.org (Postfix) with ESMTPS id 3DFD13856DC8 for ; Tue, 28 Jun 2022 10:16:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3DFD13856DC8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OlhRBq9vBcwfDEyzIOtnkg1CNzIwWRM1IuhHjmzneL0QK5X6zsaPOHWaWwwdFirdav+HzeExso4RrgIoZzdOp2Xf+dZZf829SG4nKMDjgYs8tB97wZXBFrwo3SmENrWwHPyikxZUEApuk07eB5u7nYuc7w1+mZIZllwkkPQ/+Srl3w3/2JCmAnzP2vW0BE6i+9Hjpl7d/DD6ms5M5Gln8FoAAMRpAj/JKil8Wd5C3WkBRUqHkLSOEViqmcmApPMwRmc22wqKxe1/LQgBBOY7ae+zuH6/oGbhu56LvVEQicB+JlTeZ9A3N6DlD5vR4MmCnmNAGxaLWtRb9ONrXxNjFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oSC19ZaH5znedEJOee1mfFER9s5zVCb6PwWurgJXDrw=; b=cndRFex1Q+d6oHZ70PyxfKwvYxuufiC/89EfFLL015OsmJcbSTVzmEzNJvh1tIfEd2ZBdtevF7VSin/PUKZ2OJYhFbiP2QlU+sZI4KOTBOs6AaE9ZUwiaXyZ7ZI10DFopxpiCSPLjlK98v5xYn3uY04YqgOFRJj8eO3PZGBIkei1/MpopuJe6X4V9JP6yR9ZmuHsICBTPeinL95ztseCRrJB1R5TS5TxkuEwI8OvMYWt+kwLUyhXyipAW3xA3zpazjv3bgc1UN7MLlzJ1lnBqud4r1wcVj4WveWPuC5WDqOfxfxSTi+XTz6ePcs5MMXcJ1JBmuPMq3j+D55Sary8GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR0402MB3704.eurprd04.prod.outlook.com (2603:10a6:209:1f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Tue, 28 Jun 2022 10:16:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 10:16:51 +0000 Message-ID: <10734bc9-6686-0426-c2c8-9dc8173392fe@suse.com> Date: Tue, 28 Jun 2022 12:16:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] windres: add quotes around preprocessor cmd if needed Content-Language: en-US To: =?UTF-8?Q?Cl=c3=a9ment_Chigot?= Cc: binutils@sourceware.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM5PR0701CA0003.eurprd07.prod.outlook.com (2603:10a6:203:51::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee10deab-ad43-4dc5-2f9b-08da58ef513c X-MS-TrafficTypeDiagnostic: AM6PR0402MB3704:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iLm9Zupj6Hv0SXaljqJAUjSJuCF+uOll+SYDbvVqHx1y1D6UVeJECPJ1qk3utj9RlOp+vjIc7pfyHa0F3u3y7I8pikRRn12Oe4jZK9BfnI4l/VhXqRdHmK8ZjwIfED+Czfrg0NKGLIagEIJRXwKY7bZgTD3nvQGFPrQ26nCojpbw12ofdq1S/+CF4Fcz0S490HiDzxIjaZoJp1IjInadZx34r5ICf81bEeYoPBripBkJlItUH1coKUXTZiLcn28dIwjmjPI1PE3r2d7vQTR3/9BEQYdZSFwQ8wvjTQIYSSNkt4HQGoI9rB9zARDFtOMGsM0k/rGtDNrPBBLMbOUIQf01FJvdUoZC1LCIXMj4NqO00O22/8OzauqPxggdxdjdvZozRPKMFfKeyqxJAlGBT7Ey276kLeyOuuRzKVr6vFYUoPx0XTAXjS0SeGvBS283TXdzDTQyhMLlRRJRT6aTSBFDXASqWGA3jGbTqNnyPjs9UxmEQItjg+FydOr1EVTC1+qQNYnGHMem0WmMA3LswK9hZ2Lq9kq1EFE5soTRPGl181Et7MjxpEgiXOiCPXb6HCt2z9oYwuGRQNG6kpQXOMW+BiLVy70k/MV2ARE8dY0k23dvHs8LI3hmdeB5JbNxJgztm9FyRHBUU1/z3g+6NrSPFUqcGbyxa7oFz6f35ziT+nPYEPpAVPEX5k6HQqqCbU1C1EWMmWLe/YT7ScUJ36L0E4q1k8gA1iavlFf6kv/SlhLvjVmAyRu8YGeNmO6aXZV4VNLWImkpAcFztsHwWyLydtXNZ9bdhf191RQWAOARjXGllfFZy87DySuDGKw+GEAtqU0Qevb4Gbao4dy18w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(376002)(396003)(346002)(136003)(366004)(6486002)(41300700001)(36756003)(4326008)(6916009)(2616005)(186003)(66556008)(478600001)(26005)(6512007)(5660300002)(31686004)(316002)(2906002)(53546011)(6506007)(8936002)(66476007)(86362001)(66946007)(38100700002)(8676002)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MitKRjh2WTArMlFaZmtiMThVd3lpVWhpcm90ZUc3WVBGWDB4c0djbVh5RXQr?= =?utf-8?B?WGRCc1VhUGRXbkpaRTdKbkF5WXZ4dmpVUDlqR2F0SElNeEUxY0toeHhJRExZ?= =?utf-8?B?bXREdnk1b0xHQWM3QmtwRkE4NTdtYXlnZ3V3NG1FZ0psMi9hUUwvQ042RHZX?= =?utf-8?B?bzJRUWpoZkZmQVh3WERXZ081YjZRZjBaVTRUc1hmQnNlQ25FMG9vU1p0Q2Vz?= =?utf-8?B?UEM5N3JMdjRVUHduSGROYzVOclJGTWJ1UURPdlRrY1ZUejY4c24wWkhjamdj?= =?utf-8?B?ZXh6a29OLzRaaWcvQnFYbmpGQ2gzcUQ5WEtoYlBkZmFuZ0YwUlJTUjN0NVc2?= =?utf-8?B?MFNrdWNncC9ndGYvZTlZNTR0NkNiOE1xTVhrbXJiMkdjV3A4VEFCbStEZmJ4?= =?utf-8?B?T1oybWhTWlZFMHRjd0RUQ2FaSVoxMEE1YW84OW85WUtLbDdacWZuMTlKKzBs?= =?utf-8?B?Ync3TG5aaTlDVkR3WEU2VkdBTmN0ZnZjSzhzT21WWE50ME1LZVZyd1luZzFx?= =?utf-8?B?OVBHTkE0b1kvREdZMmw4WE1ha29leEpHc1licW5LUDkzeENsS3AzTS9GZGxx?= =?utf-8?B?SlJRUTZSQXU3VExTb3UyN0orS1BORzRMaHZ3S29hUzZ2RDM3S29aYnhsTDIv?= =?utf-8?B?UXg2S1h1aVNZd21DSzNML1RuVThSZHg3UHFsYnVQSkxRYlN3UFNTWUlHeTcz?= =?utf-8?B?WGVxSE05NXJSRld6bTQ1U0ptekZJN1BiYVp0eFRtTlVlcm5zQjVTMmhoekZ4?= =?utf-8?B?QitGOWFMeTlxRWFkRUhuT09yQ2JiS3dLajQ2enVkOG5yQlRBSG5nOEloK2wz?= =?utf-8?B?elF6dVVqbjc3TURvT2NYNE9nSE9HSXd4YkpiQ0ZEUC9wZVIzbHdaN29xckx1?= =?utf-8?B?Y1V5cVNseGVBTkhFbWp3ZVdPS3hBS09Bbis3MHc3a3dDcjZCTVBrejFXR3Rm?= =?utf-8?B?NG45NWR2UFpneU1SVmxHQ3Rrc2tQSnNQd2lSODdCdEJrNlJyMHU0N0dlc3k5?= =?utf-8?B?WGErWGNpT1J5azhZZ1FQTnRmZm5tVVlZZ3JINEZldWFvNm1nRURNWmo2dU5t?= =?utf-8?B?RXFNRGZHQUZiVmVwUTNSNFZ3djhFQ09OTXlnNG8vWTJiTy9IZk1CaDZVV1pW?= =?utf-8?B?a2lucVZva1U4bTFoSkVlOFZkNzBBbDAwQzI3ZkxvaGtLNy9xUC9DMnNCeThI?= =?utf-8?B?dEhjQVZTQmdKblRmaERxcUxHQWVYRThDMzlxVDdESUpsT1JORHVOWnBuOEx1?= =?utf-8?B?ak5FK3JOZGkrVDVMZFA2UnkwcjJJQ0tiMnFjZEx6OTZNbnNlU1BNZzR5M0hO?= =?utf-8?B?UHRPL1JDa3ZGY1UxL25aSzFZRXBTQmxJYkVDMjNjQzhzcWZ1eXRMMFpIRnB1?= =?utf-8?B?UTFna0xWRzB0TE1GYXdNNXdpNHhWMC9Oemw4SFZlMndCUmtraVcwRXQ0OXQ1?= =?utf-8?B?a0ZaU3ErM0dPRUxKalRBSXc5ZGZSamRoTUpIVUpQM091UzBuQ1dHTHIxUUky?= =?utf-8?B?ZUZnK3FaZHlidjZNbjhGQ3NZQ1FPdEoxK01GRHl4SnU1MFE1dThBVnpJMGk0?= =?utf-8?B?cFM5RHcwQ0hsd1VvYThzeW1OOHNJRkcvcFRDQnltQ3lINXRBemx2L1dSaFlZ?= =?utf-8?B?dHluTVR4b0dUaUFXaFNPbDFtYnQzc1ZtQVBLSEFSMURnWFRaSFRBUG5LazFx?= =?utf-8?B?OGd5bzBOMHF5OEJnSjhSODkxNU9PRENXMy9wanlnaTMyRnNrVm1jbHdvZDdp?= =?utf-8?B?VVRVbHhFWVU3V3Fob3JRZk55djAzdmhVQy85c0ZiOC9Od0h1aitpRzdOTXk3?= =?utf-8?B?b29TUnVzVGR5QU9NTDFGR0U1OE1xcDV4bXBLOEc4bkpmQ1NqbGxXTVdybkY4?= =?utf-8?B?YUJCN0gvS295emV5S3doTmxjU0JXMThhWGlKU0gyZ0wvWmNyalkyZXVwTmtY?= =?utf-8?B?NmJzTFdWSTNQZk5hb2J2L1FkY0Q5UXpkM1RHS0hEYXFCdSt0ek9qWG9QRVR4?= =?utf-8?B?QW5kOWdKNjdTM3M3VGJWeE5NNG1VcXBTTkVxL00xdi9oOHdWRXRjVDVRUWxo?= =?utf-8?B?aTVORXVtME5lekhlSEFHMFUvd3hReVo2Z0JPMjlqMDY5TkYyNXNhTXNqdUkv?= =?utf-8?Q?YUvICHx8BK/UX4Ush6X9ym1xI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee10deab-ad43-4dc5-2f9b-08da58ef513c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 10:16:51.1235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Mp0k1PojTUhPDz+srKaPDy0zdiwIFeDQfr5oYeLH+pkWnCsJS1MfU0tkyDSYuBKPDy2XUxOl/PmzGUNR7XePAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3704 X-Spam-Status: No, score=-3030.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 10:16:56 -0000 On 28.06.2022 11:37, Clément Chigot wrote: > On Tue, Jun 28, 2022 at 11:00 AM Jan Beulich wrote: >> >> On 28.06.2022 09:35, Clément Chigot via Binutils wrote: >>> This patch ensures that the gcc binary called by windres is quoted if >>> needed. Otherwise, errors can occur if the gcc is under a folder having >>> a name containing a space (eg "Program Files"). >>> >>> binutils/ >>> * resrc.c (DEFAULT_PREPROCESSOR): Split into... >>> (DEFAULT_PREPROCESSOR_CMD): that... >>> (DEFAULT_PREPROCESSOR_ARGS): and that. >>> (look_for_default): Add quotes around the command if needed. >>> (read_rc_file): Adapt to new defines. >> >> Commenting is a little difficult without you providing the patch (also) >> inline: > > IIRC, it should be done directly but the "é" in my name makes the > mailservers think my patches are binaries... I don't think that's what is the issue. There may be mail clients which display text attachments, but then it's still an attachment, and other clients may only ever handle attachments as such (mine, for example, might display such an attachment, but would not consider it part of the reply context when first setting up a reply mail, yet having it there is what is the primary goal when talking about commenting on patches). If you can't configure your client such that inlined patches make it through ungarbled, it would still be helpful if you could _also_ inline the patch, indicating that it may not be well-formed and hence for applying the attached variant should be used. Jan