From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 11570384AB55 for ; Thu, 18 Apr 2024 20:37:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11570384AB55 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 11570384AB55 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713472654; cv=pass; b=Q0eTsliORM+J3I2I+hnKmSVEDhJ6JmMN9gGzS9w+3oyklc8erdg+DAVVri77BIiWxISv5VgMZrbOkhFYCI69QkxELZDemHRCMHRQw6WXdjaWduRVll2UpFMRnGZP1sw+SUHi+wzk0UON/9noqUR1t7BtT6oS1R9K/p0eNCksVFo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713472654; c=relaxed/simple; bh=545BIjAAjnJ8e4gWThtv2rUw+MB/m980EZRNm571tPY=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=qTC7HNC92Xh8kE/RgncFTioeKIOLAWRe8qPXDS6zPVrCce0fk1dbdGdwUZMNeKStAhPpCbSazGEMQH1uO2ibgRpLjQkpRTNR2DyTr9SnwfU3y8F3zzlqGC1ZxPN55YTfXjl43KUe5spG6xb7p3guzjT1wHX4x3qkHk3ZfnLQUgY= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43IJiMMW004555; Thu, 18 Apr 2024 20:37:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=CqmfW1mOdkIZ5zDhEqwR20H43OrdwwcTDS5lCbTbkKg=; b=bK3j2gJhDTNhkWsKo2nzFwWcZTQhHIlKcKeAt2pSKWSFhsfszCcNM6sblLbtOeZ/sc/S JU19G+NqEZpu03fI7Mh50p4X4nyRWDRLNWeyxvWyupEBd6ZXQ9AdrQNejY86NirOYHqR DN/BGQa4Bo5QbisWVGWALE/l5dpx2+aZsI2SSU5BsHsGjZq23iFrWGmukqFudjt/KH6N f9IkOu+49E/68x7Uw7ywBHwSViMEy7zuvp5k5ehxRu1slGh7VQBrM5Eh03kJSRoSSQ6y d9/0BtkGjL4PShdXnvwgAHpZ2+Ria9pIk76CiKWQOXTYYZtezlWjn3aaNpeId3QAqDqo tA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfjkvbgkj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 20:37:29 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43IJFiJ1028900; Thu, 18 Apr 2024 20:37:29 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xfggaya86-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 20:37:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PufrYkJtOl0QOKV3IzXhZjhyp5rFghZk60ntL43ThvoS1K8B1NvVHGEoxUBZW8EvGLKp0jimW6qDEWcoWJJohgqADfPRF0u+KkFDK5OJedWK9u+NlxgEtH/DKVycz9IQKUUytitn5uT/y9rj2xD9wRDFqtvqCM/QD/5AJ1s2+BObayxD/4svycNQWkglYvKXfsnSGN/pDU1Xo81OeUia74tbUoMTpKBJKayFmetlqgkeDlUIyvX1lVl4jDSD5O+vN7qb59c1twiNZtT3DMqKD9W6OFkgMsfb/b1PPdMDHfrTEoM1W9CAPubGNpgzGxRVQhpqs2Tx6M2KekNi/D2Uaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CqmfW1mOdkIZ5zDhEqwR20H43OrdwwcTDS5lCbTbkKg=; b=VxQRAkcM8QlaILnh/Ab4W7fYgneAhKqAWxk/VJ25EaGuJJnrg+vlBv4l4/Nt3I+SRDyEMj51D9B3hCqH0FGFv+hqQTonDY3hZ4EDJmSkJxQY+nnpzspEpU3aXww0Y52rYzd50/kAJCBaGQ8eHhUcb64iXfzjOsiACP5kWRkWg98gdZpHQJKYvPCwXK8yZwZw8lBxPKaCaXYceXW4CJqL4YpyMyXqIq+Xvs5xwsXGjRGFHHTmSyVCJlt3s90U+WiXJugdB6OxU6t8zC187ueKWnkrOq4KMN72CD9aijVzd5OuDiAgl4ren0q6jEL52Pumq6tgQGLpAWboz5u5DuemgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CqmfW1mOdkIZ5zDhEqwR20H43OrdwwcTDS5lCbTbkKg=; b=xyRShW5aZNHLePWKl+v4Mymh4ffTyFaZXP5npto+AiHWWn8BPECnz4EO5SSLFQ9ROjh81oxVHudIazz9+z4ZfZkUJ47vuM0giQxjbk8elkGQg47qECzOGgzb9eHqDweFnH7lBYFPCiKkA42pcGWKQq2BSPCeMav7GnBW8rL1CFY= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CY5PR10MB5913.namprd10.prod.outlook.com (2603:10b6:930:2f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.42; Thu, 18 Apr 2024 20:37:26 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889%5]) with mapi id 15.20.7472.037; Thu, 18 Apr 2024 20:37:26 +0000 Message-ID: <10b620cb-b2c4-4de5-bfe6-dba30a9c88ad@oracle.com> Date: Thu, 18 Apr 2024 13:37:26 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/15] gas: Test predicate whether SFrame RA tracking is used Content-Language: en-US To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20240412144718.4191286-1-jremus@linux.ibm.com> <20240412144718.4191286-15-jremus@linux.ibm.com> From: Indu Bhagat In-Reply-To: <20240412144718.4191286-15-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0162.namprd03.prod.outlook.com (2603:10b6:303:8d::17) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CY5PR10MB5913:EE_ X-MS-Office365-Filtering-Correlation-Id: c427e4c3-cb51-474a-381b-08dc5fe75c28 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sv2GZWhkZ2u+pjY8FgiGtR7xGdCI3ZOJz74hISPUxgJoqmAARCkd2UuRyqFpesTC0ok5XRskFMWfqHazIHLhR90gG8pfF/DqzxKe6bWfKMfnm56pEL5sEoonqptkbyh8ez2cKptThgkWtJtkCSkrpS16Uh+2ykcsMKr3TPaeoNwC430DXVBu5xQabfv4l5O8hWg32WADRAK+1zSziD/Jz8iyRSt7O9ICoLqYSZvFxstvpEE++r4h0IYy5FAmtBwNmneTl3/c7QpWUVVipQrwdREnbyqFjPRkbrYjzPMwxfXkAdwWi0WjHeCG558yYLWcpWPmixESjulKaH9lmhNUDg6GXs1susbWAuRqL1gPXmJd8TedMV2401bljC40KkGE4mUtkV31qPbEsIOIGq+/jIDbDhvQx1f7kx0bI5+Uzj9nCxDJJWVNz5Lcgr0WIQkZMGkYfOFkl5Vpc85DZIqMXEStiE41tWTeqXzMVlvzsNkJ3bM99DM5c4+TY8/eKpldjhIv/GizhLy9apyxMvMJuZCJygg8RX4TM2fvlAHkZQ9hKPrDi53/JyMA0EI6e6PmsrZa8OZgmLOo2vdkq+viHOsA5K1KpMAXrOsvmnBNU8crqvnw1yJZsh9o2tkVw60fs7y3onz3qmyE4pgqMscWcU7e5/HdYjeBIYAufJuMj7U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Si9KUFpiZU8rcExYZWJoM0pIVVljRHRWQVM4RWNqRVBOYlhuakx5cy9jeGRn?= =?utf-8?B?bm9RWnlRZ1FYZXhDR0dnbkpKOHhIRFNJay9oRStrK2ZlQTNScjZjOFVMeG9P?= =?utf-8?B?UXN3aVZxeTdMWmRiYTY5cE95UTVrcUJOY01vMVlMdTJ1L1RFb0pOUHg2MUpI?= =?utf-8?B?ZmQ2MUFURXVkRkFUdVVURzJVR3l4cmZlRy9DQlFoY2NuMlFyVTl2dW9RSjVG?= =?utf-8?B?c01WeXc0WWExVDBwbGtheUVWMVc3dTdhZ25lV0xjVjhrUWZjdFFqNzRIdTVI?= =?utf-8?B?YWYzbEk2ZzMxZXFUT0FVYW1FSjBiZ2VaN1dxTlh2QUp0Ykl1aG82MkxHSW4x?= =?utf-8?B?SURQL3h3Q29ZbmVqYXF5Yy94NmNEclRseWR1MDVCaXM0WGdXQ012RklJdUgy?= =?utf-8?B?THUyVnJXWUQ5empKYk54Um9nLzZMUUkzZlFZUlV6NGU4S1kyeUdKWHZrdlhG?= =?utf-8?B?YlMyNTJTaEVTcFQrZFhBOVQrRmNOQU1ZWWpLc3dLWUsrYXlZaHc1UnhVajdS?= =?utf-8?B?U3NhaHVYYm9HTHpkZ2VpNkNVOTRwYVVSenFxeElXODRLMDVzRHhsMkE2QTZD?= =?utf-8?B?VWxlc1Y3WmxkUUJiZEFkV2krWWovZXZnSUlmWVlSYjljUVl1UTVVSEszUnZI?= =?utf-8?B?dGxHUzJ2V3Y0VU1VYlZMRk43eDVXcFNrRUhLNE1LSnd1bWZMNG5TeUNjdm9l?= =?utf-8?B?bFlGandwUVV6UEhvQmF1TndhbTFtUUxMMW1NRGxnN2s1NVV6TXJ1alo3NXc5?= =?utf-8?B?c0FsMTVZL1c2WE9KMytIR3d2aGwvakVMc3BhazNrM0pWcUZtV3JoTEdyNmMw?= =?utf-8?B?cG1lQ2tjblYwc05rTXBPZDVFVzY2SlllaExFSU40ZlFKajJQVmZTajRqbHdS?= =?utf-8?B?Q2o0cUZsY0pOdDR3WXk5UEh0cGQyYkVXaCtXYUk3ejk2cHJLa25hOTdGWkJR?= =?utf-8?B?eEIyRi9Xcnc0S1F4bWtzWFQzdVVFUUJKb2lpeHkwa1U0YVBVZnRYZ0dQK09o?= =?utf-8?B?cGZLK3AwajhhZlo3UjZTVkFTSTh1cnlzVVVuaEY4UWtXU1hBdFQzU1k1TVdH?= =?utf-8?B?ZlEwWmNVRUlPakVROC83NWlPQ2d2YlF6WHJvR29jZ3R5SkZUSTdNaEJBb2Fa?= =?utf-8?B?QWRrRVdQZ3NKZGIxVUVqSlM4TXFRcFBzM1I1WUpyYmJ0cFN2WTRxNEpiN2lY?= =?utf-8?B?cXF4NjB6SFR0NVBjdFlMMnBFejlDZmhLVHdmSXpQTW5aRTYwaTJ6VVk0bmQy?= =?utf-8?B?TGtIcm9obVl6QnV6RFBKRlljU1N1ODduNms0NE9OVWNLWHNmUHZHSmI1eFJo?= =?utf-8?B?QTAwSzJuR3dFb1I5ODBLZ0Jlekk2VUFrUE1nSEVONzdFRUwxZ3JQUzN2ZFg3?= =?utf-8?B?dGFjaW9UK0hjT0lnYWFkT0VhZXQvUWFBcGpNbHp1QldGTGhaR3QrL3VReHdF?= =?utf-8?B?RUIrWGJJRUtKV3hqMktlRTlRRlFLbmp1TE94eEJud0NXUXZyZ2lpb0ZYUkVC?= =?utf-8?B?YkN0Q3hYeGloMkdyVkJtVnEwVmRjNnN3RS9VRERnbDlZVi84cGRid3VUZTdT?= =?utf-8?B?STUwbXpzVDhDY0FFMCtWQUdkTmY0cDVJcjA4N1ZlZGNhdXJ6N1JJcnNpeEhH?= =?utf-8?B?YU9xN0M5T2pOdTA5UXNyMzlSL04xMU5JRy9XNkszdWdNUEV3TXlYRUNPTGhS?= =?utf-8?B?UGNvbE5kWFVEYzlyb2RmVjNacmJWYWYrMUtXYlRuSmE3Q1JtV0gxOTRVWGhY?= =?utf-8?B?R2V2cytmNGk2VDl4ZndqTkJTMU5wQjIwUi9QYWtnZm5weTVHWXZEYTN3TzJQ?= =?utf-8?B?Slo3cFhGUzRsYmkzSkwyK3QzSU5iZEZQQWFCeFo2ZVBlcmNJOThBa0Z6WUpw?= =?utf-8?B?Ymhydnl3OXcyOGxDU1FKTjlHSFpybkRmMjhVZnJGSHZqdE1OOS9mOFlQOUs0?= =?utf-8?B?U3dRREJpQTdja1RJamgyWHRZWlR1NXJXSzFLeTZid2JtRThmNjdiNGZ2UXdX?= =?utf-8?B?RU15OGtPaUNyQThvTytkOEJCWFB0bjd2TnMvQzdQVkgwT29uR1FxL1VMb0pl?= =?utf-8?B?OHM2aW0ySjdFcTY5Ym44bnE5dCtUTzdmMUNtYU1RZkdYSmdGRlk3NGJFd2tE?= =?utf-8?B?RGtvOUxMdUR5ZE16eXRadVZmNXdlOThETFh1dG95bWRqUU83cVhCVzNkdmk5?= =?utf-8?Q?XfjQtIdmSz4s0IfvjGvagYI=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kyOyYXF92gdRf3gMG2GB0f+sGM+TWx43Y1+Dff3YB2jPgO+8eM5K4CT7cgX6Yj8aQeHD/6jlBwp20YKQ744A9zA4iVqct2VwRYqXgcAAMWED8IjWzH/s453L+2BTGLGsCO4F4MzmpIU1Pom++h5JatAAR0GIACed+M5oIwKrAvOoEUPd1EE/awv6tDW80sNNjuuK6HOxJYb7BhD7z6r7I/IMGgWHIRE60QSf9oZ7/Q3T3Q8/G1BZ4tfFkoWjcuG2EY/MomxJ/RoLSs2vCZa6G+6wZFaJaQZeh37d/Uiifi9fXKimiahOnP6mz/5fgfvo75dA/DiSwozKObk2apLPx9erPkDtnDCyLZWBMxqXyj8c8uWbKpiv/14cwprZfiIU95m75K37E2vvlwXpZCuD3+CfyzEhd3IydMqEH3u4NCEphDw6Smtyfk7lJ1PaN2MOtx23P7Tk8UpJqWBCsXAInm1u/t7pW9r3SjNieYehClTrMoe/dT8xHgDjLoJjhKOJqTsVYNjOmFS40zKN8AxOBfVOY+ombbi6PIWg5M2/3j7Xp92Wv4JP4wDBlTbzZ3TfYgq2HYwv82I451gLNCWrGEWtMczTRNYcWAzUPGdB8oI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c427e4c3-cb51-474a-381b-08dc5fe75c28 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 20:37:26.8720 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pHGSK9/JaOdwdG4I8QQ+aBw6Y3plV/W+tUnkTpgQ6vPWM00S2/VKxffdyajx6NVUjV43gwhhNDnGlzQwnKRiJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB5913 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-18_18,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404180149 X-Proofpoint-ORIG-GUID: Y_V3GlvDURftNyG7Jjl70zuxkDuBgejN X-Proofpoint-GUID: Y_V3GlvDURftNyG7Jjl70zuxkDuBgejN X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 07:47, Jens Remus wrote: > The existence of the macro SFRAME_FRE_RA_TRACKING only ensures the > existence of the macro SFRAME_CFA_RA_REG and the predicate function > sframe_ra_tracking_p. It does not indicate whether SFrame RA tracking > is actually used. > > Test the return value of the SFrame RA tracking predicate function > sframe_ra_tracking_p to determine whether RA tracking is used. > > This aligns the logic in functions get_fre_num_offsets and > output_sframe_row_entry to the one used in all other places. > LGTM. Thanks > gas/ > * gen-sframe.c (get_fre_num_offsets, output_sframe_row_entry): > Test predicate to determine whether SFrame RA tracking is used. > > Signed-off-by: Jens Remus > --- > > Notes (jremus): > Changes v2 -> v3: > - New patch. > > gas/gen-sframe.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c > index 12b523a8d59a..ca6565b0e45e 100644 > --- a/gas/gen-sframe.c > +++ b/gas/gen-sframe.c > @@ -346,7 +346,8 @@ get_fre_num_offsets (struct sframe_row_entry *sframe_fre) > if (sframe_fre->bp_loc == SFRAME_FRE_ELEM_LOC_STACK) > fre_num_offsets++; > #ifdef SFRAME_FRE_RA_TRACKING > - if (sframe_fre->ra_loc == SFRAME_FRE_ELEM_LOC_STACK) > + if (sframe_ra_tracking_p () > + && sframe_fre->ra_loc == SFRAME_FRE_ELEM_LOC_STACK) > fre_num_offsets++; > #endif > return fre_num_offsets; > @@ -536,7 +537,8 @@ output_sframe_row_entry (symbolS *fde_start_addr, > fre_write_offsets++; > > #ifdef SFRAME_FRE_RA_TRACKING > - if (sframe_fre->ra_loc == SFRAME_FRE_ELEM_LOC_STACK) > + if (sframe_ra_tracking_p () > + && sframe_fre->ra_loc == SFRAME_FRE_ELEM_LOC_STACK) > { > fre_offset_func_map[idx].out_func (sframe_fre->ra_offset); > fre_write_offsets++;