From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30080 invoked by alias); 16 Nov 2004 09:58:15 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 29704 invoked from network); 16 Nov 2004 09:57:55 -0000 Received: from unknown (HELO cam-admin0.cambridge.arm.com) (193.131.176.58) by sourceware.org with SMTP; 16 Nov 2004 09:57:55 -0000 Received: from pc960.cambridge.arm.com (pc960.cambridge.arm.com [10.1.205.4]) by cam-admin0.cambridge.arm.com (8.12.10/8.12.10) with ESMTP id iAG9vBso023355; Tue, 16 Nov 2004 09:57:11 GMT Received: from pc960.cambridge.arm.com (localhost.localdomain [127.0.0.1]) by pc960.cambridge.arm.com (8.12.8/8.12.8) with ESMTP id iAG9vqgK027645; Tue, 16 Nov 2004 09:57:52 GMT Received: (from rearnsha@localhost) by pc960.cambridge.arm.com (8.12.8/8.12.8/Submit) id iAG9vph2027643; Tue, 16 Nov 2004 09:57:51 GMT X-Authentication-Warning: pc960.cambridge.arm.com: rearnsha set sender to rearnsha@gcc.gnu.org using -f Subject: Re: PATCH: Correct handling of R_ARM_TARGET2 in elf32_arm_relocate_section From: Richard Earnshaw To: Mark Mitchell Cc: binutils@sources.redhat.com In-Reply-To: <200411160248.iAG2mEji007731@sirius.codesourcery.com> References: <200411160248.iAG2mEji007731@sirius.codesourcery.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: GNU Message-Id: <1100599070.25423.33.camel@pc960.cambridge.arm.com> Mime-Version: 1.0 Date: Tue, 16 Nov 2004 09:58:00 -0000 X-SW-Source: 2004-11/txt/msg00236.txt.bz2 On Tue, 2004-11-16 at 02:48, Mark Mitchell wrote: > We got spurious warnings about uses of the R_ARM_TARGET2 relocation > because we forgot to translate it into the real underlying relocation > in elf32_arm_relocate_section. > > OK? > > -- > Mark Mitchell > CodeSourcery, LLC > mark@codesourcery.com > > 2004-11-15 Mark Mitchell > > * elf32-arm.c (elf32_arm_relocate_section): Use > arm_real_reloc_type. This is OK. And Daniel is right, this is elf32-arm.c, and it only supports the 'new' (!OLD_ARM_ABI) ABI. I haven't seen a patch yet to delete the ifdefs (or if there's been one, I missed it). R.