From: Richard Earnshaw <rearnsha@gcc.gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: binutils@sources.redhat.com, Paul Brook <paul@codesourcery.com>
Subject: Re: RFA: Support for Thumb in dynamic objects
Date: Wed, 17 Nov 2004 17:00:00 -0000 [thread overview]
Message-ID: <1100710750.22014.50.camel@pc960.cambridge.arm.com> (raw)
In-Reply-To: <20041117164853.GA512@nevyn.them.org>
On Wed, 2004-11-17 at 16:48, Daniel Jacobowitz wrote:
> On Wed, Nov 17, 2004 at 01:48:06PM +0000, Richard Earnshaw wrote:
> > > OK? Comments?
> >
> > This is OK once you've addressed the point Paul raised. You might also
> > have to look at the tests when run in big-endian mode too.
>
> I missed some arm-elf vs arm-linux issues, and some big vs little
> endian issues; no one's run the testsuite in big-endian in a while.
> I'm reposting for review. There are two changes in the patch that I
> would like someone else to look at:
>
> - I fixed a big-endian Thumb disassembly bug. It would read past
> the end of the section.
Can you use a macro rather than ~0x3?
> - I updated the patterns in the gas unwind tables test. There's some
> funny byte and nibble swapping going on, so I'd appreciate it if
> someone (Paul?) could tell me whether the big-endian pattern is correct;
> it matches gas's output now.
>
This is clearly OK, the values in the big-endian side of the table
should clearly be the byte-swapped versions of the little-endian side.
> Passes the testsuite on arm-elf, armeb-elf, and arm-linux.
Other than that, OK.
R.
next prev parent reply other threads:[~2004-11-17 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 23:39 Daniel Jacobowitz
2004-11-17 0:22 ` Paul Brook
2004-11-17 0:37 ` Daniel Jacobowitz
2004-11-17 1:37 ` Ian Lance Taylor
2004-11-17 3:02 ` Daniel Jacobowitz
2004-11-17 3:42 ` Ian Lance Taylor
2004-11-17 13:48 ` Richard Earnshaw
2004-11-17 16:49 ` Daniel Jacobowitz
2004-11-17 17:00 ` Richard Earnshaw [this message]
2004-11-17 17:05 ` Daniel Jacobowitz
2004-11-17 17:12 ` Richard Earnshaw
2004-11-17 17:36 ` Daniel Jacobowitz
2004-11-17 17:39 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100710750.22014.50.camel@pc960.cambridge.arm.com \
--to=rearnsha@gcc.gnu.org \
--cc=binutils@sources.redhat.com \
--cc=drow@false.org \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).