From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28278 invoked by alias); 17 Nov 2004 17:12:08 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 27610 invoked from network); 17 Nov 2004 17:11:34 -0000 Received: from unknown (HELO cam-admin0.cambridge.arm.com) (193.131.176.58) by sourceware.org with SMTP; 17 Nov 2004 17:11:34 -0000 Received: from pc960.cambridge.arm.com (pc960.cambridge.arm.com [10.1.205.4]) by cam-admin0.cambridge.arm.com (8.12.10/8.12.10) with ESMTP id iAHHAgso027219; Wed, 17 Nov 2004 17:10:42 GMT Received: from pc960.cambridge.arm.com (localhost.localdomain [127.0.0.1]) by pc960.cambridge.arm.com (8.12.8/8.12.8) with ESMTP id iAHHBOgK023100; Wed, 17 Nov 2004 17:11:24 GMT Received: (from rearnsha@localhost) by pc960.cambridge.arm.com (8.12.8/8.12.8/Submit) id iAHHBKTq023098; Wed, 17 Nov 2004 17:11:20 GMT X-Authentication-Warning: pc960.cambridge.arm.com: rearnsha set sender to rearnsha@gcc.gnu.org using -f Subject: Re: RFA: Support for Thumb in dynamic objects From: Richard Earnshaw To: Daniel Jacobowitz Cc: binutils@sources.redhat.com, Paul Brook In-Reply-To: <20041117170534.GA1189@nevyn.them.org> References: <20041116233909.GA31434@nevyn.them.org> <1100699286.22014.14.camel@pc960.cambridge.arm.com> <20041117164853.GA512@nevyn.them.org> <1100710750.22014.50.camel@pc960.cambridge.arm.com> <20041117170534.GA1189@nevyn.them.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: GNU Message-Id: <1100711480.22014.59.camel@pc960.cambridge.arm.com> Mime-Version: 1.0 Date: Wed, 17 Nov 2004 17:12:00 -0000 X-SW-Source: 2004-11/txt/msg00255.txt.bz2 On Wed, 2004-11-17 at 17:05, Daniel Jacobowitz wrote: > On Wed, Nov 17, 2004 at 04:59:10PM +0000, Richard Earnshaw wrote: > > On Wed, 2004-11-17 at 16:48, Daniel Jacobowitz wrote: > > > On Wed, Nov 17, 2004 at 01:48:06PM +0000, Richard Earnshaw wrote: > > > > > OK? Comments? > > > > > > > > This is OK once you've addressed the point Paul raised. You might also > > > > have to look at the tests when run in big-endian mode too. > > > > > > I missed some arm-elf vs arm-linux issues, and some big vs little > > > endian issues; no one's run the testsuite in big-endian in a while. > > > I'm reposting for review. There are two changes in the patch that I > > > would like someone else to look at: > > > > > > - I fixed a big-endian Thumb disassembly bug. It would read past > > > the end of the section. > > > > Can you use a macro rather than ~0x3? > > I just copied it from a couple of lines up. How about: > ROUND_DOWN (pc + 4, 4) > instead? It would certainly be better than the direct manipulation, but I was really thinking 'why are we doing the masking at this point?' Could it be because we want an ARM instruction address? If it's a Thumb insn address why isn't it ~1? A suitably named macro would convey that information directly... R.