public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [arm] Use prel31 in EH table indices
@ 2004-12-08 16:33 Paul Brook
  2004-12-09 10:17 ` Richard Earnshaw
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Brook @ 2004-12-08 16:33 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

The first word of an Arm exception index table should be an R_ARM_PREL31 
relocation of the function start. We were using R_ARM_REL32.

Tested with cross to arm-none-eabi.
Ok?

Paul

2004-12-08  Paul Brook  <paul@codesourcery.com>

 * config/tc-arm.c (s_arm_unwind_fnend): Use R_ARM_PREL31 relocation
 for function start.
 * testsuite/gas/arm/unwind.d: Expect R_ARM_PREL31 relocations.

[-- Attachment #2: patch.gas_eh_prel31 --]
[-- Type: text/x-diff, Size: 1541 bytes --]

Index: gas/config/tc-arm.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-arm.c,v
retrieving revision 1.186
diff -u -p -r1.186 tc-arm.c
--- gas/config/tc-arm.c	3 Dec 2004 01:22:14 -0000	1.186
+++ gas/config/tc-arm.c	7 Dec 2004 18:02:47 -0000
@@ -14079,7 +14079,7 @@ s_arm_unwind_fnend (int ignored ATTRIBUT
 
   /* Self relative offset of the function start.  */
   fix_new (frag_now, where, 4, unwind.proc_start, 0, 1,
-	   BFD_RELOC_32);
+	   BFD_RELOC_ARM_PREL31);
 
   if (val)
     /* Inline exception table entry.  */
Index: gas/testsuite/gas/arm/unwind.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/arm/unwind.d,v
retrieving revision 1.2
diff -u -p -r1.2 unwind.d
--- gas/testsuite/gas/arm/unwind.d	17 Nov 2004 17:50:24 -0000	1.2
+++ gas/testsuite/gas/arm/unwind.d	7 Dec 2004 18:02:48 -0000
@@ -10,14 +10,14 @@ OFFSET   TYPE              VALUE 
 
 RELOCATION RECORDS FOR \[.ARM.exidx\]:
 OFFSET   TYPE              VALUE 
-00000000 R_ARM_REL32       .text
-00000008 R_ARM_REL32       .text
+00000000 R_ARM_PREL31      .text
+00000008 R_ARM_PREL31      .text
 0000000c R_ARM_PREL31      .ARM.extab
-00000010 R_ARM_REL32       .text
+00000010 R_ARM_PREL31      .text
 00000014 R_ARM_PREL31      .ARM.extab
-00000018 R_ARM_REL32       .text
+00000018 R_ARM_PREL31      .text
 0000001c R_ARM_PREL31      .ARM.extab
-00000020 R_ARM_REL32       .text
+00000020 R_ARM_PREL31      .text
 
 
 Contents of section .text:

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [arm] Use prel31 in EH table indices
  2004-12-08 16:33 [arm] Use prel31 in EH table indices Paul Brook
@ 2004-12-09 10:17 ` Richard Earnshaw
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Earnshaw @ 2004-12-09 10:17 UTC (permalink / raw)
  To: Paul Brook; +Cc: binutils

On Wed, 2004-12-08 at 16:32, Paul Brook wrote:
> The first word of an Arm exception index table should be an R_ARM_PREL31 
> relocation of the function start. We were using R_ARM_REL32.
> 
> Tested with cross to arm-none-eabi.
> Ok?
> 
> Paul
> 
> 2004-12-08  Paul Brook  <paul@codesourcery.com>
> 
>  * config/tc-arm.c (s_arm_unwind_fnend): Use R_ARM_PREL31 relocation
>  for function start.
>  * testsuite/gas/arm/unwind.d: Expect R_ARM_PREL31 relocations.

OK.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-12-09 10:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-08 16:33 [arm] Use prel31 in EH table indices Paul Brook
2004-12-09 10:17 ` Richard Earnshaw

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).