From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7255 invoked by alias); 29 Jan 2005 00:29:38 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 7004 invoked from network); 29 Jan 2005 00:29:24 -0000 Received: from unknown (HELO bluesmobile.specifixinc.com) (64.220.152.98) by sourceware.org with SMTP; 29 Jan 2005 00:29:24 -0000 Received: from [127.0.0.1] (bluesmobile.corp.specifixinc.com [192.168.1.2]) by bluesmobile.specifixinc.com (Postfix) with ESMTP id 15FAA16786; Fri, 28 Jan 2005 16:29:24 -0800 (PST) Subject: Re: [PATCH] ia64 pseudo ops with missing operands From: James E Wilson To: Jan Beulich Cc: binutils@sources.redhat.com In-Reply-To: References: Content-Type: text/plain Message-Id: <1106958563.24728.18.camel@aretha.corp.specifixinc.com> Mime-Version: 1.0 Date: Sat, 29 Jan 2005 00:29:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2005-01/txt/msg00500.txt.bz2 On Thu, 2005-01-27 at 23:57, Jan Beulich wrote: > Still, here as well as in the places you complained about before, I > can't see how else I should describe the change in the ChangeLog entry. That's OK. I'm just being a pedant. > Done. For the simplicity of the change, I didn't re-run the > build/tests... OK. > >You have FULL17 included twice in the mask. > Intentionally. OpX3() expands to two expressions separated by a comma, > and the mask needs to go into both. So it does. Please add a comment so that someone like me won't be tempted to "fix" this code that appears to be obviously incorrect. Or alternatively you could add another macro which makes it obvious that both uses of FULL17 are needed. Either way is fine. Adding a comment is simpler. A new macro would probably be a little cleaner. OK with this change. -- Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com