From: James E Wilson <wilson@specifixinc.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] ia64: accept alternative forms of .pred.rel
Date: Mon, 31 Jan 2005 20:48:00 -0000 [thread overview]
Message-ID: <1107204520.7454.44.camel@aretha.corp.specifixinc.com> (raw)
In-Reply-To: <s1fe5d93.014@emea1-mh.id2.novell.com>
On Mon, 2005-01-31 at 08:32, Jan Beulich wrote:
> Change to allow ias forms of .pred.rel (with @-prefixed designators).
Neither the Intel Assembly Language Reference Guide nor the Intel
Assembler User's Guide mentions this syntax. Where did it come from?
We already have two supported syntaxes. Do we really need a third one?
I do agree that using @ operators here makes sense though, as it makes
it more similar to how other directives work, but I'd like to know more
about why we need it.
Otherwise, this looks OK.
> Also
> eliminate a memory leak in the original code dealing with the quoted
> form.
There are 3 places that call demand_copy_C_string, and only one calls
obstack_free afterwards. The other one is much harder to fix though.
Curiously, I see that tc-ia64.c is not the only config file that calls
demand_copy_C_string, but it is the only one calling obstack_free
afterwards. It does look like the right thing to do though.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com
next prev parent reply other threads:[~2005-01-31 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-31 16:32 Jan Beulich
2005-01-31 20:48 ` James E Wilson [this message]
2005-02-01 8:07 Jan Beulich
2005-02-01 20:27 ` James E Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107204520.7454.44.camel@aretha.corp.specifixinc.com \
--to=wilson@specifixinc.com \
--cc=JBeulich@novell.com \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).