From: Richard Earnshaw <rearnsha@gcc.gnu.org>
To: Paul Brook <paul@codesourcery.com>
Cc: binutils@sources.redhat.com
Subject: Re: [patch] SymbianOS Arm executables
Date: Thu, 10 Feb 2005 19:54:00 -0000 [thread overview]
Message-ID: <1108051026.4376.47.camel@pc960.cambridge.arm.com> (raw)
In-Reply-To: <200502101545.29671.paul@codesourcery.com>
On Thu, 2005-02-10 at 15:45, Paul Brook wrote:
> On Thursday 10 February 2005 10:55, Richard Earnshaw wrote:
> > I'm uncomfortable about the way globals->symbian_p is getting scattered
> > throughout the entire linking process. I think we really need to try
> > and distill that variable into the effects it has on linking (this would
> > then make porting the linker to platforms with similar properties much
> > less painful).
> >
> > In this case you've already identified the abstract property: the
> > executable is relocated at link time. Most of your used of ->symbian_p
> > should therefore be ->exec_reloc_p. There should then be exactly one
> > place where symbian_p is tested, and that is then used to set the
> > exec_reloc_p property.
>
> Modified patch attached. No functional changes.
>
That looks much better.
> Retested on i686-linux, arm-none-elf and arm-none-symbianelf.
> Ok?
The ARM parts are OK, but I can't approve the other bits.
R.
next prev parent reply other threads:[~2005-02-10 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-09 23:38 Paul Brook
2005-02-10 15:58 ` Richard Earnshaw
2005-02-10 17:29 ` Paul Brook
2005-02-10 19:54 ` Richard Earnshaw [this message]
2005-02-11 15:15 Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1108051026.4376.47.camel@pc960.cambridge.arm.com \
--to=rearnsha@gcc.gnu.org \
--cc=binutils@sources.redhat.com \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).