From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23752 invoked by alias); 11 Feb 2005 00:33:34 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 23588 invoked from network); 11 Feb 2005 00:33:29 -0000 Received: from unknown (HELO bluesmobile.specifixinc.com) (64.220.152.98) by sourceware.org with SMTP; 11 Feb 2005 00:33:29 -0000 Received: from [127.0.0.1] (bluesmobile.corp.specifixinc.com [192.168.1.2]) by bluesmobile.specifixinc.com (Postfix) with ESMTP id 162F416792; Thu, 10 Feb 2005 16:33:29 -0800 (PST) Subject: Re: [PATCH] ia64: certain symbol names were unusable From: James E Wilson To: Jan Beulich Cc: binutils@sources.redhat.com In-Reply-To: References: Content-Type: text/plain Message-Id: <1108082008.24473.131.camel@aretha.corp.specifixinc.com> Mime-Version: 1.0 Date: Fri, 11 Feb 2005 03:46:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2005-02/txt/msg00223.txt.bz2 On Tue, 2005-02-08 at 03:16, Jan Beulich wrote: > + if (name[1] == 'n' && ISDIGIT (name[idx = 2])) > + dr = &md.in; Please don't hide assignments like this. It makes the code hard to read. This should be name[2] with "idx = 2;" on a separate line. > + if (name[1] == 'o' && name[2] == 'c' && ISDIGIT (name[idx = > 3])) > + dr = &md.loc; Likewise. > + if (name[1] == 'u' && name[2] == 't' && ISDIGIT (name[idx = > 3])) > + dr = &md.out; Likewise. > + if (dr && (name[idx] != '0' || name[idx + 1] == '\0')) This one puzzled me for a while. There should be a comment explaining what it is for, to ignore any number with a leading zero, other than zero itself. Otherwise this is OK. -- Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com