From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11525 invoked by alias); 11 Feb 2005 20:41:53 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 11497 invoked from network); 11 Feb 2005 20:41:49 -0000 Received: from unknown (HELO bluesmobile.specifixinc.com) (64.220.152.98) by sourceware.org with SMTP; 11 Feb 2005 20:41:49 -0000 Received: from [127.0.0.1] (bluesmobile.corp.specifixinc.com [192.168.1.2]) by bluesmobile.specifixinc.com (Postfix) with ESMTP id 017CF16797; Fri, 11 Feb 2005 12:41:48 -0800 (PST) Subject: Re: PATCH: Add -munwind-check=[none|warning|error] From: James E Wilson To: "H. J. Lu" Cc: binutils@sources.redhat.com In-Reply-To: <20050211190009.GA6759@lucon.org> References: <20050210172938.GA17132@lucon.org> <1108089017.24473.184.camel@aretha.corp.specifixinc.com> <20050211184511.GA6170@lucon.org> <20050211190009.GA6759@lucon.org> Content-Type: text/plain Message-Id: <1108154508.19527.47.camel@aretha.corp.specifixinc.com> Mime-Version: 1.0 Date: Fri, 11 Feb 2005 23:49:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2005-02/txt/msg00267.txt.bz2 On Fri, 2005-02-11 at 11:00, H. J. Lu wrote: > > Here is the new patch. I removed the -munwind-check=none option. I also > > included the patch for the .endp check. IAS does ignore the name > > after .endp. But checking it is a good idea. People will get a > > warning unless they fix the code. In case I wasn't clear, I am not opposed to having the -munwind-check=none option, just to the amount of ugly code that was used to implement it in the previous patch. I think it would be foolish to disable these checks now that we have them, but I can see that there might be unusual cases where this might be useful. About the .endp patch, I needed to take a closer look at that one as it confused me. Jan's comment said to change default name from NULL to "" to avoid a segfault, you thanked him for the bug report, but you didn't change this. And since I apparently didn't receive either your original patch or Jan's reply to it, it wasn't clear to me whether the problem was still broken or had been fixed a different way. I now suspect it was fixed a different way by adding the "&& default_name" line, as I don't see a problem. > * NEWS: Mention "-munwind-check=[warning|error]". > * config/tc-ia64.c (md): Add unwind_check. > (unwind_diagnostic): New. > ... OK. -- Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com