From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-38155-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 9353 invoked by alias); 22 Feb 2005 22:14:42 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 9326 invoked from network); 22 Feb 2005 22:14:39 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 22 Feb 2005 22:14:39 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1MMEdPO014435
	for <binutils@sources.redhat.com>; Tue, 22 Feb 2005 17:14:39 -0500
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1MMEaK01739;
	Tue, 22 Feb 2005 17:14:36 -0500
Received: from dhcp-172-16-25-252.sfbay.redhat.com (dhcp-172-16-25-252.sfbay.redhat.com [172.16.25.252])
	by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j1MMES5s016784;
	Tue, 22 Feb 2005 17:14:30 -0500
Subject: Re: [PATCH] MIPS gas/ld test suite portability fixes
From: Eric Christopher <echristo@redhat.com>
To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Cc: "Maciej W. Rozycki" <macro@mips.com>, binutils@sources.redhat.com,
        "Maciej W. Rozycki" <macro@linux-mips.org>
In-Reply-To: <20050222220154.GE7729@rembrandt.csv.ica.uni-stuttgart.de>
References: <Pine.LNX.4.61.0502221612240.20174@perivale.mips.com>
	 <20050222211319.GC7729@rembrandt.csv.ica.uni-stuttgart.de>
	 <Pine.LNX.4.61.0502222119110.20174@perivale.mips.com>
	 <20050222220154.GE7729@rembrandt.csv.ica.uni-stuttgart.de>
Content-Type: text/plain
Date: Wed, 23 Feb 2005 00:06:00 -0000
Message-Id: <1109110466.5032.25.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-02/txt/msg00527.txt.bz2


> I meant something like:
> 
> --- tc-mips.c   18 Feb 2005 22:12:50 -0000      1.284
> +++ tc-mips.c   22 Feb 2005 21:54:59 -0000
> @@ -10652,7 +10694,11 @@ mips_after_parse_args (void)
>      }
> 
>    if (arch_info == 0)
> -    arch_info = mips_parse_cpu ("default CPU", MIPS_CPU_STRING_DEFAULT);
> +    {
> +      arch_info = mips_parse_cpu ("default CPU", MIPS_CPU_STRING_DEFAULT);
> +      if (ABI_NEEDS_64BIT_REGS (mips_abi) && !ISA_HAS_64BIT_REGS (arch_info->isa))
> +       arch_info->isa = ISA_MIPS3;
> +    }
> 
>    if (ABI_NEEDS_64BIT_REGS (mips_abi) && !ISA_HAS_64BIT_REGS (arch_info->isa))
>      as_bad ("-march=%s is not compatible with the selected ABI",
> 
> 
> (This fails to compile because arch_info is a constant.)

No, I definitely don't like this. It's going back to the era when
gcc/gas "guessed" what you meant. If we're passing an abi and don't have
a required minimum ISA either passed or by default then we should error
out.

-eric