From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26633 invoked by alias); 19 Mar 2005 01:51:41 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 25970 invoked from network); 19 Mar 2005 01:51:37 -0000 Received: from unknown (HELO bluesmobile.specifixinc.com) (64.220.152.98) by sourceware.org with SMTP; 19 Mar 2005 01:51:37 -0000 Received: from [127.0.0.1] (bluesmobile.corp.specifixinc.com [192.168.1.2]) by bluesmobile.specifixinc.com (Postfix) with ESMTP id 0C5A2167EA; Fri, 18 Mar 2005 17:51:37 -0800 (PST) Subject: Re: build failure for ia64 (due to -Werror) From: James E Wilson To: Andreas Schwab Cc: Nick Clifton , Ben Elliston , binutils@sources.redhat.com In-Reply-To: References: <423A2ADB.6090807@au.ibm.com> <423ABA6A.4030409@redhat.com> <20050318122113.GY21148@bubble.modra.org> <1111177693.9897.18.camel@aretha.corp.specifixinc.com> <20050318234920.GE21148@bubble.modra.org> <1111194296.9897.158.camel@aretha.corp.specifixinc.com> Content-Type: text/plain Message-Id: <1111197096.9897.188.camel@aretha.corp.specifixinc.com> Mime-Version: 1.0 Date: Sat, 19 Mar 2005 09:44:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2005-03/txt/msg00568.txt.bz2 On Fri, 2005-03-18 at 17:23, Andreas Schwab wrote: > The cast was clearly bogus, because it violated the strict aliasing > rules. I agree the change did something useful. However, I disagree that the change was required to make the file work. It only violated strict aliasing rules because it was compiled with a 32-bit bfd_vma which is wrong. If it was compiled with a proper 64-bit bfd_vma, as required by the port, then there is no aliasing violation, and hence no serious bug. There was only a minor issue of the code not being as clean as possible. So the problem isn't that the code had a bogus cast. The problem is that it was compiled with the wrong bfd_vma type. That is the problem that I think should be fixed. -- Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com