* ARM: Don't make noise about R_ARM_NONE relocs
@ 2005-03-22 0:50 Daniel Jacobowitz
2005-03-22 16:59 ` Richard Earnshaw
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Jacobowitz @ 2005-03-22 0:50 UTC (permalink / raw)
To: binutils
This patch fixes a bug which was already present before my (pending) patch
for protected symbols; but that patch changes where to place the fix, so
this patch is dependent on it.
When we have an R_ARM_NONE relocation against a symbol, as the ARM assembler
uses for personality routines, we don't use the value of the symbol. So no
need to complain if it is unresolved. Relevant archive members will already
have been pulled in.
OK?
--
Daniel Jacobowitz
CodeSourcery, LLC
2005-03-21 Daniel Jacobowitz <dan@codesourcery.com>
* elf32-arm.c (elf32_arm_final_link_relocate): Don't fail for
unresolved symbols in R_ARM_NONE relocations.
Index: binutils/bfd/elf32-arm.c
===================================================================
--- binutils.orig/bfd/elf32-arm.c 2005-03-18 19:16:06.000000000 -0500
+++ binutils/bfd/elf32-arm.c 2005-03-18 20:12:45.000000000 -0500
@@ -2311,6 +2311,9 @@ elf32_arm_final_link_relocate (reloc_how
switch (r_type)
{
case R_ARM_NONE:
+ /* We don't need to find a value for this symbol. It's just a
+ marker. */
+ *unresolved_reloc_p = FALSE;
return bfd_reloc_ok;
case R_ARM_PC24:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ARM: Don't make noise about R_ARM_NONE relocs
2005-03-22 0:50 ARM: Don't make noise about R_ARM_NONE relocs Daniel Jacobowitz
@ 2005-03-22 16:59 ` Richard Earnshaw
0 siblings, 0 replies; 2+ messages in thread
From: Richard Earnshaw @ 2005-03-22 16:59 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: binutils
On Mon, 2005-03-21 at 20:53, Daniel Jacobowitz wrote:
> This patch fixes a bug which was already present before my (pending) patch
> for protected symbols; but that patch changes where to place the fix, so
> this patch is dependent on it.
>
> When we have an R_ARM_NONE relocation against a symbol, as the ARM assembler
> uses for personality routines, we don't use the value of the symbol. So no
> need to complain if it is unresolved. Relevant archive members will already
> have been pulled in.
>
> OK?
> 2005-03-21 Daniel Jacobowitz <dan@codesourcery.com>
* elf32-arm.c (elf32_arm_final_link_relocate): Don't fail for
unresolved symbols in R_ARM_NONE relocations.
OK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-22 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-22 0:50 ARM: Don't make noise about R_ARM_NONE relocs Daniel Jacobowitz
2005-03-22 16:59 ` Richard Earnshaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).