From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22870 invoked by alias); 23 Mar 2005 18:43:00 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 22815 invoked from network); 23 Mar 2005 18:42:52 -0000 Received: from unknown (64.192.52.5) by sourceware.org with QMTP; 23 Mar 2005 18:42:52 -0000 Received: (qmail 18105 invoked by uid 210); 23 Mar 2005 13:42:14 -0500 Received: from 10.10.10.188 by skinny (envelope-from , uid 201) with qmail-scanner-1.24st (clamdscan: 0.82/700. f-prot: 4.4.2/3.14.11. spamassassin: 3.0.2. perlscan: 1.24st. Clear:RC:1(10.10.10.188):. Processed in 0.062311 secs); 23 Mar 2005 18:42:14 -0000 Received: from unknown (HELO ?10.10.10.188?) (10.10.10.188) by 0 with RC4-MD5 encrypted SMTP; 23 Mar 2005 13:42:14 -0500 Subject: Re: [PATCH] Add --warn-shared-textrel option to ld From: Ned Ludd Reply-To: solar@gentoo.org To: Nick Clifton Cc: jbaker@qnx.com, binutils@sources.redhat.com In-Reply-To: <416557CA.3080803@redhat.com> References: <415C43A4.5070501@redhat.com> <415D6CC6.8040103@qnx.com> <416557CA.3080803@redhat.com> Content-Type: text/plain Date: Thu, 24 Mar 2005 03:50:00 -0000 Message-Id: <1111603325.15967.192.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2005-03/txt/msg00719.txt.bz2 Is the check for info->shared suitable for info->pie as well? Would there be anyway to perhaps make this check a little more verbose in it's diagnostic output in order to help aid in tracking down the offending relocations in object files. Suns link editor seems to behave this way when given a -z text option. http://docs.sun.com/app/docs/doc/816-1386/6m7qcobl6?a=view (Under PIC) On Thu, 2004-10-07 at 15:50 +0100, Nick Clifton wrote: > Hi Jeff, > > >> * The formatting of the code added to elflink.c does not follow the > >> GNU Coding Standards; (the opening curly brace should be on its own > >> line). > >> > >> * The patch adds a new command line switch to the linker, but it does > >> not add documentation on this switch to the ld.texinfo file, nor does it > >> add a line to the ld/NEWS file. > > > How about now? > > Better - thanks: > > > 2004-10-01 Jeff Baker > > * elflink.c (_bfd_elf_add_dynamic_entry): Add code to > > warn if adding a DT_TEXTREL to a shared object and > > --warn-shared-textrel was specified. > > > > 2004-10-01 Jeff Baker > > * bfdlink.h (bfd_link_info): Add boolean > > warn_shared_textrel. > > > > 2004-10-01 Jeff Baker > > * NEWS: Added mention of --warn-shared-textrel option. > > * ld.texinfo: Add documentation for --warn-shared-textrel. > > * lexsup.c: Handle --warn-shared-textrel option. > > Approved and applied. > > Cheers > Nick > -- Ned Ludd