From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27783 invoked by alias); 28 Mar 2005 22:54:10 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 27419 invoked from network); 28 Mar 2005 22:54:02 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 28 Mar 2005 22:54:02 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j2SMs21U028035 for ; Mon, 28 Mar 2005 17:54:02 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j2SMs1O01962; Mon, 28 Mar 2005 17:54:01 -0500 Received: from dhcp-172-16-25-252.sfbay.redhat.com (dhcp-172-16-25-252.sfbay.redhat.com [172.16.25.252]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j2SMs0gp022002; Mon, 28 Mar 2005 17:54:00 -0500 Subject: Re: [RFA] Fix compilation warnings in irix-core.c From: Eric Christopher To: Joel Brobecker Cc: binutils@sources.redhat.com In-Reply-To: <20050328224444.GS2295@adacore.com> References: <20050328224444.GS2295@adacore.com> Content-Type: text/plain Date: Tue, 29 Mar 2005 06:03:00 -0000 Message-Id: <1112050439.5223.11.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2005-03/txt/msg00832.txt.bz2 On Mon, 2005-03-28 at 14:44 -0800, Joel Brobecker wrote: > Hello, > > GDB currently fails to build on mips/irix due to warnings now being > turned into errors. I am unfortunately lacking the time to look deeply > into this at the moment (I have asked one of my coworkers to help me > with that), but there was one file where the fixes were I think obvious. > Here is a patch for it: > > 2005-03-28 Joel Brobecker > > * irix-core.c (do_sections): Add parenthesis in expression > to avoid a compiler warning. > (irix_core_core_file_matches_executable_p): Add ATTRIBUTE_UNUSED > to unused parameters to avoid a compiler warning. if (!make_bfd_asection (abfd, secname, - SEC_ALLOC | SEC_LOAD+SEC_HAS_CONTENTS, + SEC_ALLOC | (SEC_LOAD+SEC_HAS_CONTENTS), Spaces around the + please. irix_core_core_file_matches_executable_p (core_bfd, exec_bfd) - bfd *core_bfd, *exec_bfd; + bfd *core_bfd ATTRIBUTE_UNUSED, *exec_bfd ATTRIBUTE_UNUSED; Can you move this to: bfd *core_bfd ATTRIBUTE_UNUSED; bfd *exec_bfd ATTRIBUTE_UNUSED; please? OK with those changes. Though if you want to migrate the whole file to ISO I'd appreciate it. For style just look at, say, elfxx-mips.c :) -eric