From: Richard Earnshaw <rearnsha@gcc.gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: binutils@sources.redhat.com
Subject: Re: ARM: Fix DT_TEXTREL generation
Date: Tue, 29 Mar 2005 16:21:00 -0000 [thread overview]
Message-ID: <1112109728.12337.0.camel@pc960.cambridge.arm.com> (raw)
In-Reply-To: <20050325160121.GA16066@nevyn.them.org>
On Fri, 2005-03-25 at 16:01, Daniel Jacobowitz wrote:
> I posted this patch a couple days ago, but at the bottom of a thread ...
> tsk tsk.
>
> This patch prevents the incorrect generation of a DT_TEXTREL tag in ARM
> shared libraries. The problem was that p->count was correctly updated,
> but we would sometimes create new relocs_copied entries with a zero count;
> and when checking for text relocations, we don't look at the count, just
> whether the pointer is non-NULL. The cleanest fix is to avoid creating a
> new relocs_copied structure if we aren't going to increment it.
>
> OK for HEAD? Any objection to fixing this on 2.16 also?
This is OK for head. For the record, I'm happy for this to go into 2.16
too, but I'm not sure if that's my call.
R.
next prev parent reply other threads:[~2005-03-29 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-26 0:35 Daniel Jacobowitz
2005-03-29 16:21 ` Richard Earnshaw [this message]
2005-03-29 20:00 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1112109728.12337.0.camel@pc960.cambridge.arm.com \
--to=rearnsha@gcc.gnu.org \
--cc=binutils@sources.redhat.com \
--cc=drow@false.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).