From: Richard Earnshaw <rearnsha@gcc.gnu.org>
To: Julian Brown <julian@codesourcery.com>
Cc: Paul Brook <paul@codesourcery.com>, binutils@sources.redhat.com
Subject: Re: [PATCH] Fix type and alignment of ARM/Thumb EABI mapping symbols
Date: Thu, 31 Mar 2005 15:25:00 -0000 [thread overview]
Message-ID: <1112259316.1680.11.camel@pc960.cambridge.arm.com> (raw)
In-Reply-To: <424ADC3C.8080004@codesourcery.com>
On Wed, 2005-03-30 at 18:05, Julian Brown wrote:
> Richard Earnshaw wrote:
> > On Wed, 2005-03-30 at 17:34, Julian Brown wrote:
> >>Richard Earnshaw wrote:
> >>>This function isn't elf specific, which is one of the reasons I
> >>>suggested moving it to cpu-arm.c. So why have you put elf32 in the
> >>>name?
> >>
> >>Doh, sorry. I was confused by the mapping symbols being defined by the
> >>AAELF spec, and didn't realise they would be used elsewhere too.
> >
> > True, but we don't define a coff spec. However, I suspect that if we
> > did, we'd probably put mapping symbols in there too.
>
> OK, here is a further patch to rename the function.
>
> ChangeLog:
>
> bfd:
> * bfd-in.h (bfd_is_arm_mapping_symbol_name): Rename from
> bfd_elf32_is_arm_mapping_symbol_name.
> * bfd-in2.h: Regenerate.
> * cpu-arm.c (bfd_is_arm_mapping_symbol_name): Rename from
> bfd_elf32_is_arm_mapping_symbol_name.
> * elf32-arm.c (elf32_arm_is_target_special_symbol): Rename
> bfd_elf32_is_arm_mapping_symbol_name to bfd_is_arm_mapping_symbol_name.
> (arm_elf_find_function): Likewise.
> (elf32_arm_output_symbol_hook): Likewise.
>
> gas:
> * config/tc-arm.c (arm_adjust_symtab): Rename
> bfd_elf32_is_arm_mapping_symbol_name to bfd_is_arm_mapping_symbol_name.
This one counts as obvious :-)
R.
prev parent reply other threads:[~2005-03-31 8:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 8:41 Julian Brown
2005-03-28 10:17 ` Daniel Jacobowitz
2005-03-28 10:36 ` Julian Brown
2005-03-29 16:54 ` Richard Earnshaw
2005-03-29 17:25 ` Daniel Jacobowitz
2005-03-30 15:31 ` Julian Brown
2005-03-30 17:05 ` Richard Earnshaw
2005-03-30 21:08 ` Paul Brook
2005-03-30 21:11 ` Julian Brown
2005-03-31 0:27 ` Richard Earnshaw
2005-03-31 0:34 ` Julian Brown
2005-03-31 0:58 ` Richard Earnshaw
2005-03-31 2:17 ` Julian Brown
2005-03-31 15:25 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1112259316.1680.11.camel@pc960.cambridge.arm.com \
--to=rearnsha@gcc.gnu.org \
--cc=binutils@sources.redhat.com \
--cc=julian@codesourcery.com \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).