From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27553 invoked by alias); 31 Mar 2005 08:55:31 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 27449 invoked from network); 31 Mar 2005 08:55:20 -0000 Received: from unknown (HELO cam-admin0.cambridge.arm.com) (193.131.176.58) by sourceware.org with SMTP; 31 Mar 2005 08:55:20 -0000 Received: from pc960.cambridge.arm.com (pc960.cambridge.arm.com [10.1.205.4]) by cam-admin0.cambridge.arm.com (8.12.10/8.12.10) with ESMTP id j2V8t34G026688; Thu, 31 Mar 2005 09:55:03 +0100 (BST) Received: from pc960.cambridge.arm.com (localhost.localdomain [127.0.0.1]) by pc960.cambridge.arm.com (8.12.8/8.12.8) with ESMTP id j2V8tHIF023089; Thu, 31 Mar 2005 09:55:18 +0100 Received: (from rearnsha@localhost) by pc960.cambridge.arm.com (8.12.8/8.12.8/Submit) id j2V8tHvx023087; Thu, 31 Mar 2005 09:55:17 +0100 X-Authentication-Warning: pc960.cambridge.arm.com: rearnsha set sender to rearnsha@gcc.gnu.org using -f Subject: Re: [PATCH] Fix type and alignment of ARM/Thumb EABI mapping symbols From: Richard Earnshaw To: Julian Brown Cc: Paul Brook , binutils@sources.redhat.com In-Reply-To: <424ADC3C.8080004@codesourcery.com> References: <424716CD.5030909@codesourcery.com> <4249C7E9.8000100@codesourcery.com> <1112175967.12337.36.camel@pc960.cambridge.arm.com> <200503301527.50626.paul@codesourcery.com> <424AC63F.7000706@codesourcery.com> <1112200206.1680.6.camel@pc960.cambridge.arm.com> <424AD518.9000101@codesourcery.com> <1112200646.1680.9.camel@pc960.cambridge.arm.com> <424ADC3C.8080004@codesourcery.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: GNU Message-Id: <1112259316.1680.11.camel@pc960.cambridge.arm.com> Mime-Version: 1.0 Date: Thu, 31 Mar 2005 15:25:00 -0000 X-SW-Source: 2005-03/txt/msg00920.txt.bz2 On Wed, 2005-03-30 at 18:05, Julian Brown wrote: > Richard Earnshaw wrote: > > On Wed, 2005-03-30 at 17:34, Julian Brown wrote: > >>Richard Earnshaw wrote: > >>>This function isn't elf specific, which is one of the reasons I > >>>suggested moving it to cpu-arm.c. So why have you put elf32 in the > >>>name? > >> > >>Doh, sorry. I was confused by the mapping symbols being defined by the > >>AAELF spec, and didn't realise they would be used elsewhere too. > > > > True, but we don't define a coff spec. However, I suspect that if we > > did, we'd probably put mapping symbols in there too. > > OK, here is a further patch to rename the function. > > ChangeLog: > > bfd: > * bfd-in.h (bfd_is_arm_mapping_symbol_name): Rename from > bfd_elf32_is_arm_mapping_symbol_name. > * bfd-in2.h: Regenerate. > * cpu-arm.c (bfd_is_arm_mapping_symbol_name): Rename from > bfd_elf32_is_arm_mapping_symbol_name. > * elf32-arm.c (elf32_arm_is_target_special_symbol): Rename > bfd_elf32_is_arm_mapping_symbol_name to bfd_is_arm_mapping_symbol_name. > (arm_elf_find_function): Likewise. > (elf32_arm_output_symbol_hook): Likewise. > > gas: > * config/tc-arm.c (arm_adjust_symtab): Rename > bfd_elf32_is_arm_mapping_symbol_name to bfd_is_arm_mapping_symbol_name. This one counts as obvious :-) R.