From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17333 invoked by alias); 5 May 2005 18:10:43 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 17219 invoked from network); 5 May 2005 18:10:31 -0000 Received: from unknown (HELO bluesmobile.specifixinc.com) (64.220.152.98) by sourceware.org with SMTP; 5 May 2005 18:10:31 -0000 Received: from [127.0.0.1] (bluesmobile.corp.specifix.com [192.168.1.2]) by bluesmobile.specifixinc.com (Postfix) with ESMTP id 069E1169E1; Thu, 5 May 2005 12:25:00 -0700 (PDT) Subject: Re: Another HP-UX IA64 Build patch From: James E Wilson To: Steve Ellcey Cc: drow@false.org, binutils@sources.redhat.com In-Reply-To: <200505051751.KAA17543@hpsje.cup.hp.com> References: <200505051751.KAA17543@hpsje.cup.hp.com> Content-Type: text/plain Message-Id: <1115316630.8413.20.camel@aretha.corp.specifixinc.com> Mime-Version: 1.0 Date: Thu, 05 May 2005 18:12:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2005-05/txt/msg00193.txt.bz2 On Thu, 2005-05-05 at 10:51, Steve Ellcey wrote: > I see it doesn't have the const modifier that libiberty has. I didn't > get a warning or error presumbably because the build didn't include > libgen.h. This is a libiberty bug. Try "man basename" on a linux system, and it will tell you that there are two versions of basename. The posix one which takes a char * argument, and a glibc _GNU_SOURCE one which takes a const char * argument. So this probably should be something like #if defined(_GNU_SOURCE) extern char *basename (const char *); #elif defined... extern char *basename (char *); #else extern char *basename (); #endif But it appears that nobody is including libgen.h anywhere, or we would have caught this before. For now, I think just adding __hpux__ to the list is fine, and we can worry about the wrong prototype later, when and if it causes a problem. -- Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com