From: Richard Earnshaw <rearnsha@gcc.gnu.org>
To: Zack Weinberg <zack@codesourcery.com>
Cc: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: Fix some of the ARM GAS failures
Date: Wed, 25 May 2005 13:42:00 -0000 [thread overview]
Message-ID: <1117010314.7618.15.camel@pc960.cambridge.arm.com> (raw)
In-Reply-To: <1116965825.7031.16.camel@localhost.localdomain>
On Tue, 2005-05-24 at 21:17, Zack Weinberg wrote:
> This patch should improve the ARM-GAS situation somewhat. md_apply_fix3
> needs to truncate the relocation to 32 signed bits manually; if the host
> is 64-bit, fx_addnumber and fx_offset are 64-bit, and may generate
> spurious overflows. Also, we need a double cast on both sides of the
> hack to pass an integer around in tc_fix_data.
>
AFAICT tc_fix_data is a private type to the ARM-specific parts of the
assembler. Since storing the thumbness is the only use, and the type of
tc_fix_data is defined in tc-arm.h (TC_FIX_TYPE), it would make much
more sense to just change TC_FIX_TYPE to 'int' and get rid of all those
nasty casts.
Otherwise OK.
R.
> zw
> * config/tc-arm.c (fix_new_arm): Cast thumb_mode to size_t
> before casting it to PTR.
> (md_apply_fix3): Truncate value, *valP, fixP->fx_addnumber,
> and fixP->fx_offset to 32 signed bits.
next prev parent reply other threads:[~2005-05-25 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-24 21:24 Zack Weinberg
2005-05-25 13:42 ` Richard Earnshaw [this message]
2005-05-27 11:42 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117010314.7618.15.camel@pc960.cambridge.arm.com \
--to=rearnsha@gcc.gnu.org \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=zack@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).