public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Eric Christopher <echristo@redhat.com>
To: Paul Koning <pkoning@equallogic.com>
Cc: binutils@sources.redhat.com
Subject: Re: PATCH: fix dwarf2 handling of signed addresses
Date: Fri, 08 Jul 2005 16:02:00 -0000	[thread overview]
Message-ID: <1120838529.9164.6.camel@dzur.sfbay.redhat.com> (raw)
In-Reply-To: <17102.41161.857750.187469@gargle.gargle.HOWL>


> The attached patch fixes that problem.  I can't apply it (no write
> privs -- but I do have a copyright assignment in place).
> 

This is enough to sponsor you for write approval. You've done work in
the past and appear to want to continue doing so. Go ahead and put in
the request with me as the sponsor.

> 2005-07-08  Paul Koning  <pkoning@equallogic.com>
> 
> 	* dwarf2.c (read_address): Check sign_extend_vma to handle targets
> 	where addresses are sign extended.

My only reservation for this is that we should be sign extending every
address no matter what and that this points to a bug in our code
elsewhere.

-eric

  reply	other threads:[~2005-07-08 16:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-07 21:57 Why mips32 addr2line doesn't work Paul Koning
2005-07-08 15:51 ` PATCH: fix dwarf2 handling of signed addresses Paul Koning
2005-07-08 16:02   ` Eric Christopher [this message]
2005-07-08 16:06     ` Daniel Jacobowitz
2005-07-08 16:15       ` Eric Christopher
2005-07-08 21:42       ` Paul Koning

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1120838529.9164.6.camel@dzur.sfbay.redhat.com \
    --to=echristo@redhat.com \
    --cc=binutils@sources.redhat.com \
    --cc=pkoning@equallogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).