* PATCH: ld/1247: IA64: Linker crashes with undefined hidden symbols
@ 2005-08-26 20:40 H. J. Lu
2005-08-29 19:14 ` James E Wilson
0 siblings, 1 reply; 2+ messages in thread
From: H. J. Lu @ 2005-08-26 20:40 UTC (permalink / raw)
To: binutils
allocate_fptr doesn't check if a hidden symbol is undefined, which
leads to crash later. This patch fixes it.
H.J.
----
2005-08-26 H.J. Lu <hongjiu.lu@intel.com>
PR ld/1247
* elfxx-ia64.c (allocate_fptr): Check undefined symbol.
--- bfd/elfxx-ia64.c.hidden 2005-08-26 10:14:04.000000000 -0700
+++ bfd/elfxx-ia64.c 2005-08-26 13:34:06.000000000 -0700
@@ -2776,7 +2776,8 @@ allocate_fptr (dyn_i, data)
if (!x->info->executable
&& (!h
|| ELF_ST_VISIBILITY (h->other) == STV_DEFAULT
- || h->root.type != bfd_link_hash_undefweak))
+ || (h->root.type != bfd_link_hash_undefweak
+ && h->root.type != bfd_link_hash_undefined)))
{
if (h && h->dynindx == -1)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH: ld/1247: IA64: Linker crashes with undefined hidden symbols
2005-08-26 20:40 PATCH: ld/1247: IA64: Linker crashes with undefined hidden symbols H. J. Lu
@ 2005-08-29 19:14 ` James E Wilson
0 siblings, 0 replies; 2+ messages in thread
From: James E Wilson @ 2005-08-29 19:14 UTC (permalink / raw)
To: H. J. Lu; +Cc: binutils
On Fri, 2005-08-26 at 13:40, H. J. Lu wrote:
> PR ld/1247
> * elfxx-ia64.c (allocate_fptr): Check undefined symbol.
Thanks. Looks like this was accidentally broken when the visibility
support was added.
I didn't see the bugzilla mail for this bug appear on the bug-binutils
list. It seems that the mail feed from bugzilla to bug-binutils is
broken. I haven't gotten anything since July 15.
--
Jim Wilson, GNU Tools Support, http://www.specifix.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-08-29 19:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-08-26 20:40 PATCH: ld/1247: IA64: Linker crashes with undefined hidden symbols H. J. Lu
2005-08-29 19:14 ` James E Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).