* [PATCH][Binutils] aarch64: Fix the hyphenated disassembly comment.
@ 2024-05-21 10:56 srinath
2024-05-21 12:24 ` Nick Clifton
0 siblings, 1 reply; 4+ messages in thread
From: srinath @ 2024-05-21 10:56 UTC (permalink / raw)
To: binutils; +Cc: richard.earnshaw, nickc, Srinath Parvathaneni
From: Srinath Parvathaneni <srinath.parvathaneni@arm.com>
Hi,
This patch fixes the following comment.
- /* The hyphenated form is preferred for disassembly if there are
- more than two registers in the list, and the register numbers
are monotonically increasing in increments of one. */
+ /* The hyphenated form is preferred for disassembly if there is
+ more than one register in the list, and the register numbers
are monotonically increasing in increments of one. */
Ok for binutils-master? and backport to binutils-2_42-branch ?
Regards,
Srinath.
---
opcodes/aarch64-opc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/opcodes/aarch64-opc.c b/opcodes/aarch64-opc.c
index 4a7a6ae784b..032ab17e250 100644
--- a/opcodes/aarch64-opc.c
+++ b/opcodes/aarch64-opc.c
@@ -3700,8 +3700,8 @@ print_register_list (char *buf, size_t size, const aarch64_opnd_info *opnd,
else
tb[0] = '\0';
- /* The hyphenated form is preferred for disassembly if there are
- more than two registers in the list, and the register numbers
+ /* The hyphenated form is preferred for disassembly if there is
+ more than one register in the list, and the register numbers
are monotonically increasing in increments of one. */
if (stride == 1 && num_regs > 1
&& ((opnd->type != AARCH64_OPND_SME_Zt2)
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][Binutils] aarch64: Fix the hyphenated disassembly comment.
2024-05-21 10:56 [PATCH][Binutils] aarch64: Fix the hyphenated disassembly comment srinath
@ 2024-05-21 12:24 ` Nick Clifton
2024-05-21 13:49 ` Richard Earnshaw (lists)
2024-05-21 14:03 ` Srinath Parvathaneni
0 siblings, 2 replies; 4+ messages in thread
From: Nick Clifton @ 2024-05-21 12:24 UTC (permalink / raw)
To: srinath, binutils; +Cc: richard.earnshaw
Hi Srinath,
> Ok for binutils-master?
Approved - please apply.
> and backport to binutils-2_42-branch ?
You really want to backport an update to a comment ? Well,
far be it from me to stop you - approved, please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][Binutils] aarch64: Fix the hyphenated disassembly comment.
2024-05-21 12:24 ` Nick Clifton
@ 2024-05-21 13:49 ` Richard Earnshaw (lists)
2024-05-21 14:03 ` Srinath Parvathaneni
1 sibling, 0 replies; 4+ messages in thread
From: Richard Earnshaw (lists) @ 2024-05-21 13:49 UTC (permalink / raw)
To: Nick Clifton, srinath, binutils
On 21/05/2024 13:24, Nick Clifton wrote:
> Hi Srinath,
>
>> and backport to binutils-2_42-branch ?
>
> You really want to backport an update to a comment ? Well,
> far be it from me to stop you - approved, please apply.
>
> Cheers
> Nick
>
Seems like overkill to me.
R.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][Binutils] aarch64: Fix the hyphenated disassembly comment.
2024-05-21 12:24 ` Nick Clifton
2024-05-21 13:49 ` Richard Earnshaw (lists)
@ 2024-05-21 14:03 ` Srinath Parvathaneni
1 sibling, 0 replies; 4+ messages in thread
From: Srinath Parvathaneni @ 2024-05-21 14:03 UTC (permalink / raw)
To: nickc, binutils; +Cc: Richard Earnshaw
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
Thanks, applied to master.
Please disregard my backport request.
________________________________
From: Nick Clifton <nickc@redhat.com>
Sent: 21 May 2024 13:24
To: Srinath Parvathaneni <Srinath.Parvathaneni@arm.com>; binutils@sourceware.org <binutils@sourceware.org>
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][Binutils] aarch64: Fix the hyphenated disassembly comment.
Hi Srinath,
> Ok for binutils-master?
Approved - please apply.
> and backport to binutils-2_42-branch ?
You really want to backport an update to a comment ? Well,
far be it from me to stop you - approved, please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-21 14:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-21 10:56 [PATCH][Binutils] aarch64: Fix the hyphenated disassembly comment srinath
2024-05-21 12:24 ` Nick Clifton
2024-05-21 13:49 ` Richard Earnshaw (lists)
2024-05-21 14:03 ` Srinath Parvathaneni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).