From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 524EB3858D3C for ; Thu, 24 Mar 2022 17:08:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 524EB3858D3C Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-64-KfNXhIvKPFuUzSEnqQjvqQ-1; Thu, 24 Mar 2022 13:08:28 -0400 X-MC-Unique: KfNXhIvKPFuUzSEnqQjvqQ-1 Received: by mail-wm1-f72.google.com with SMTP id v67-20020a1cac46000000b00383e71bb26fso1790070wme.1 for ; Thu, 24 Mar 2022 10:08:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=2u+yG5CCUukUwGSXuMR4gcy1FvIWjvBU6zZBPmUSF+M=; b=VEBGpufJIlxByy0qMBZT5C6KfKxuzcV5UyidKCUcMByoG/YDffwzyTKtFEYqi/TJ9B bx+v3eSGsUJAe+d5WxybX1Kpn4k6j/1im//RKhKaTj4xA798hYNJAcv6rHNB7gf8AQk9 +7fMMPiqY/qOXwcrH3fKynGRaNf1LVEtS5ZZ4iq131L5m7xCt9L43UuhKvL55WImQmrR YdXT8F7rV19rUZ96fTrpWLtWdrf3U5nYRlGdtXioUtgWZ0OXCSQ18pUiNCq3pHVF7JyG wzkCXB4VPmHwr5oY+k1xTy2No/Nfk5Ojl3la07Xn9/Tew5Cm6jzjxW1tkojCI1UsYbAS DUHw== X-Gm-Message-State: AOAM532iYjbwSualRpVn/WVUspFrKFfyXZ+PBmO1qmawEuxgltOEM1XX P8hQrB/425ma5GHqPHaGLHNA45XgItVoMosmcj+ud5DWCCq9XF2ej1I3/Hec/jZ8fkC/6LZmqgL BU/eFFF/FDG+Jkvhmag== X-Received: by 2002:a1c:cc06:0:b0:389:79c7:aee6 with SMTP id h6-20020a1ccc06000000b0038979c7aee6mr5734038wmb.47.1648141707182; Thu, 24 Mar 2022 10:08:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWvUJyXbhZaF2bAYEQrqUNY3b0Kukvw657swttX71KM3GcyAgGPuNnNsAQCQZ1gchUQNZVkA== X-Received: by 2002:a1c:cc06:0:b0:389:79c7:aee6 with SMTP id h6-20020a1ccc06000000b0038979c7aee6mr5734020wmb.47.1648141706961; Thu, 24 Mar 2022 10:08:26 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-173-39.claranet.co.uk. [80.168.173.39]) by smtp.gmail.com with ESMTPSA id u11-20020a056000038b00b00203e5c9aa09sm4372582wrf.27.2022.03.24.10.08.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Mar 2022 10:08:26 -0700 (PDT) Message-ID: <1138d18c-00b9-5f24-5f28-506fe2298e65@redhat.com> Date: Thu, 24 Mar 2022 17:08:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCHv2 0/3] disassembler syntax highlighting in objdump (via libopcodes) To: Andrew Burgess , binutils@sourceware.org References: From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 17:08:31 -0000 Hi Andrew, > This series changes libopcodes so that this disassemblers can supply > styling information with every piece of disassembly output, e.g. is > this a register? an address? a mnemonic? etc. I like it! > objdump/opcodes: add syntax highlighting to disassembler output > opcodes/riscv: implement style support in the disassembler > opcodes/i386: partially implement disassembler style support > > binutils/NEWS | 4 + > binutils/doc/binutils.texi | 11 ++ > binutils/objdump.c | 249 ++++++++++++++++++++++++++++++++----- > gdb/disasm.c | 34 ++++- > gdb/disasm.h | 7 ++ > include/dis-asm.h | 88 ++++++++++++- > opcodes/dis-init.c | 5 +- > opcodes/disassemble.c | 23 +++- > opcodes/i386-dis.c | 63 ++++++---- > opcodes/riscv-dis.c | 193 +++++++++++++++++----------- > 10 files changed, 541 insertions(+), 136 deletions(-) > Patch series approved - please apply them all. Cheers Nick