From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 78EF03858D32 for ; Tue, 12 Mar 2024 10:50:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 78EF03858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 78EF03858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710240628; cv=none; b=CNH6ghJLGxZbbSQ233W4yylCVet+TRXSAaaDbYe5KkJ653b3HWK/6QA4JxAVZPMQlZEubLylxZFPH2EL06zq3vYQLjB/LJBb6DNQju8Zfo37d3iUDqvkYYJZvByDN0Bnzu0fnJuc7whL5herTe0M+RLz4zmeLtFp0wdB34OKtWA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710240628; c=relaxed/simple; bh=7ph9mkRR2fEFB805i5eo43+1w9ub3eqBaB1mDbETqSM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=jordtnY6PDWwJEEwokmA2CrREZhEbI/EfVA1/oqvxsYl1PIe+aMaPnSULVS55GSMLRaLvS2z5YVLtyJtAWws5K6SAWwklg/uKvKxjMVyw4KkYyjM//SmVDccv+HvxahcFvBvtYZn+2oXtqb6JDH0RhcEepvb03a+D/yuYFAk7Gc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710240627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q43eOQ+VVLxDLU/5HMZ2rYEEKhN0nBEuoEQ3gBmDJK8=; b=P55tTBDLpuqZoGQsLiOU4VNB6fpPMpnHM/V0cwKt8C25vI6CCP2ynEmgXI9jjAGiwYDuVd 0JzABsDpijNiq5DCPsytCmvBkFBhSZxLXHAv6IhEDP9dhXyIILTao/QN+mphBVXOj9084l /6D7g9qnX0u8ospBvsYwwFskRg9CEaQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-0CCnxskiOoOoXSP2Eu4Fjw-1; Tue, 12 Mar 2024 06:50:25 -0400 X-MC-Unique: 0CCnxskiOoOoXSP2Eu4Fjw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-412de861228so21999265e9.0 for ; Tue, 12 Mar 2024 03:50:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710240624; x=1710845424; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q43eOQ+VVLxDLU/5HMZ2rYEEKhN0nBEuoEQ3gBmDJK8=; b=wH44T4t29TbfWrYD6XzXZIghxuATQuBKTW5dFFpthigGM4qFQ9FSw6Cy6jpOQOIOVE XWvVmk2/dzuJw2v3LAlxa7Xe0P4plTyPdQ2WjKXVfsLPSue+ZyN+S3ZmQmyBYeCxAdby zbTG6MozmPw9/5OJnu1FXNODSUDKLC+8Kpiu9Dp3LFmZim4mb+BoLv2cxy5G8gZgqHaV SdzflyNeVnShgwBf+5b7hXcyxLrsLgYhUF3KAdgRKpH7esLeHioBybZBGtGGLe/KiAw9 Tnc6e3WUUmED4czQHDM+cxzGMRZZlxVQo34wimz0D6SitMDXFA8bZ5Cn2rTKNuavCtO9 NJHQ== X-Gm-Message-State: AOJu0YwzV8amIv4AVtzQ+ITHpGwUD1DQHrcWHqGmhKk8DhFDvOG8Aljb KrWBBGplfsoX6k8JyGIaaTlZY+RB+40i3fU/tXKFtcURU6yNj1fEsFlvoNILeawNXBq9geZtgXK Ib1AOxBuwUVbsbXml0r2oWccg7aLpShFzn26xba07eJ1ki1ooi90Qr3Y= X-Received: by 2002:a05:600c:5101:b0:413:2958:d145 with SMTP id o1-20020a05600c510100b004132958d145mr4266544wms.4.1710240624755; Tue, 12 Mar 2024 03:50:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHeFQ/WMWi1uDBaY/rKtDAZCxrsbxZ6O91Sn8TSLKrkxo12VMkvMBjq3THsQxh2hse+w1j76A== X-Received: by 2002:a05:600c:5101:b0:413:2958:d145 with SMTP id o1-20020a05600c510100b004132958d145mr4266532wms.4.1710240624336; Tue, 12 Mar 2024 03:50:24 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id r11-20020a05600c35cb00b004127057d6b9sm18644052wmq.35.2024.03.12.03.50.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Mar 2024 03:50:23 -0700 (PDT) Message-ID: <113f5f06-680f-415a-bbff-117ff71afaf7@redhat.com> Date: Tue, 12 Mar 2024 11:50:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: add .pre-commit-config.yaml To: Simon Marchi , gdb-patches@sourceware.org Cc: binutils@sourceware.org References: <20240311150947.71762-1-simon.marchi@efficios.com> From: Guinevere Larsen In-Reply-To: <20240311150947.71762-1-simon.marchi@efficios.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I have no real opinion on pre-commit, one way or another, but I like the idea of automating easily-forgotten things. could even be upgraded to rerunning gdbarch.py at some point! On 11/03/2024 16:09, Simon Marchi wrote: > I will add these instructions to the wiki if this patch gets merged, so > they are easy to find. We could perhaps think of having a > gdb/CONTRIBUTING document of some sort checked in the repo with that > kind of information. I have positive opinions on this, however! I don't find the contribution checklist on the wiki to be a good description of the contribution process of GDB. I'm not sure what I know from there and what is essential tribal knowledge that I got from internal talks and incorrect submissions that were corrected. The maintainers file is the closest we have to describing the process, and someone who doesn't know the project would not think of looking there, I don't think (I know I didn't). So I would be very happy to see a contributing file, where the process as a whole is described in order, before going down to the minutiae of how to make a good contribution. One and done things like pre-commit, choosing a way to send email, copyright attribution, can be easily viewed by prospecting contributors, and previous contributors can refresh their minds or quickly check some recent process change. -- Cheers, Guinevere Larsen She/Her/Hers