From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17945 invoked by alias); 5 Apr 2006 20:30:46 -0000 Received: (qmail 17931 invoked by uid 22791); 5 Apr 2006 20:30:45 -0000 X-Spam-Check-By: sourceware.org Received: from w099.z064220152.sjc-ca.dsl.cnc.net (HELO duck.specifix.com) (64.220.152.99) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Apr 2006 20:30:44 +0000 Received: from [127.0.0.1] (duck.corp.specifix.com [192.168.1.1]) by duck.specifix.com (Postfix) with ESMTP id 43274FC54; Wed, 5 Apr 2006 13:30:38 -0700 (PDT) Subject: Re: PATCH: ld/2442: ia64 ld slow with many local relocs (O(N^2) in get_dyn_sym_info) From: James E Wilson To: "H. J. Lu" Cc: binutils@sources.redhat.com In-Reply-To: <20060405200437.GA492@lucon.org> References: <20060331001552.GA11432@lucon.org> <20060331155712.GA17583@lucon.org> <20060402183340.GA4574@lucon.org> <1144177304.9086.31.camel@aretha.corp.specifix.com> <20060405200437.GA492@lucon.org> Content-Type: text/plain Message-Id: <1144269038.14807.63.camel@aretha.corp.specifix.com> Mime-Version: 1.0 Date: Wed, 05 Apr 2006 21:01:00 -0000 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00076.txt.bz2 On Wed, 2006-04-05 at 13:04, H. J. Lu wrote: > Thanks for your review. When you spent so much time on the problem, > you forgot that it wasn't as clear as what you though. I incorporated > your comments in the patch. Does it look OK? Yes, it looks OK. As for the long comment you added before the sort_dyn_sym_info call, I would put it before the get_dyn_sym_info function, since it describes the whole function, and why we have this extra complexity. -- Jim Wilson, GNU Tools Support, http://www.specifix.com