Re: [patch] Arm BE8 mode and mapping sybols

[Richard Earnshaw <rearnsha@arm.com>]

On Sun, 2006-05-07 at 15:45, Nick Clifton wrote:
> Hi Paul,
> 
> > +  /* We only want 'a', 't' and 'd' mapping symbols.  */
> > +  if (! bfd_is_arm_mapping_symbol_name (name)
> > +      || (name[1] != 'a' && name[1] != 't' && name[1] != 'd'))
> >      return TRUE;
> 
> Actually I think that it would be cleaner if 
> bfd_is_arm_mapping_symbol_name() took a second argument which 
> distinguishes between a request for any mapping symbol versus a request 
> for only-valid-for-modern-ABIs mapping symbol.  That way the knowledge 
> about which symbols are valid can be kept in one place, with the code 
> that actually detects them.
> 
> Cheers
>    Nick

There have only ever been three mapping symbols: $a, $t and $d.  The
remainder have always been 'tagging' symbols.  Maybe the routine should
be renamed to bfd_is_arm_special_symbol name and then given an argument
TYPE_MAP, TYPE_TAG or TYPE_ANY.

R.