From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-45820-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 1304 invoked by alias); 8 May 2006 12:15:15 -0000
Received: (qmail 1294 invoked by uid 22791); 8 May 2006 12:15:13 -0000
X-Spam-Check-By: sourceware.org
Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (193.131.176.58)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 08 May 2006 12:15:07 +0000
Received: from cam-owa1.Emea.Arm.com (cam-owa1.emea.arm.com [10.1.255.62]) 	by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id k48CEqZ8014743; 	Mon, 8 May 2006 13:14:52 +0100 (BST)
Received: from pc960.cambridge.arm.com ([10.1.255.211]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); 	 Mon, 8 May 2006 13:14:53 +0100
Subject: Re: [patch] Arm BE8 mode and mapping sybols
From: Richard Earnshaw <rearnsha@arm.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, binutils@sourceware.org
In-Reply-To: <445E0813.9030005@redhat.com>
References: <200605052247.59076.paul@codesourcery.com> 	 <445E0813.9030005@redhat.com>
Content-Type: text/plain
Message-Id: <1147090486.16332.18.camel@pc960.cambridge.arm.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6
Date: Mon, 08 May 2006 18:20:00 -0000
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2006-05/txt/msg00146.txt.bz2

On Sun, 2006-05-07 at 15:45, Nick Clifton wrote:
> Hi Paul,
> 
> > +  /* We only want 'a', 't' and 'd' mapping symbols.  */
> > +  if (! bfd_is_arm_mapping_symbol_name (name)
> > +      || (name[1] != 'a' && name[1] != 't' && name[1] != 'd'))
> >      return TRUE;
> 
> Actually I think that it would be cleaner if 
> bfd_is_arm_mapping_symbol_name() took a second argument which 
> distinguishes between a request for any mapping symbol versus a request 
> for only-valid-for-modern-ABIs mapping symbol.  That way the knowledge 
> about which symbols are valid can be kept in one place, with the code 
> that actually detects them.
> 
> Cheers
>    Nick

There have only ever been three mapping symbols: $a, $t and $d.  The
remainder have always been 'tagging' symbols.  Maybe the routine should
be renamed to bfd_is_arm_special_symbol name and then given an argument
TYPE_MAP, TYPE_TAG or TYPE_ANY.

R.