From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22298 invoked by alias); 10 May 2006 20:13:15 -0000 Received: (qmail 22103 invoked by uid 22791); 10 May 2006 20:13:14 -0000 X-Spam-Check-By: sourceware.org Received: from guri.is.scarlet.be (HELO guri.is.scarlet.be) (193.74.71.22) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 10 May 2006 20:13:11 +0000 Received: from ([62.235.231.160]) by guri.is.scarlet.be with ESMTP id k4AKD6W02723; Wed, 10 May 2006 22:13:06 +0200 Received: from dannypc (dannypc [10.1.1.2]) by firewall.scarlet.be (8.12.2/8.12.3/SuSE Linux 0.6) with ESMTP id k4AKD0fN005457; Wed, 10 May 2006 22:13:00 +0200 Subject: Re: Binutils on arm : pls advice me how to proceed From: Danny Backx To: Nick Clifton Cc: pedro_alves@portugalmail.pt, binutils@sourceware.org In-Reply-To: <4461C504.6050208@redhat.com> References: <1146765307.4177.16.camel@dannypc> <20060504180348.GA5785@nevyn.them.org> <445A4FF9.2020903@portugalmail.pt> <4461C504.6050208@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-HMhFSBmhv7qvC5fwJdmd" Date: Thu, 11 May 2006 04:32:00 -0000 Message-Id: <1147291981.3774.28.camel@dannypc> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3-10mdk X-DCC-scarlet.be-Metrics: guri 2020; Body=4 Fuz1=4 Fuz2=4 X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00207.txt.bz2 --=-HMhFSBmhv7qvC5fwJdmd Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 3841 I am having problems applying them to the current CVS version. Almost all the diffs fail to apply, I've copied an excerpt below. Am I using the wrong version ? |RCS file: /cvs/src/src/bfd/coff-arm.c,v |retrieving revision 1.63 |diff -c -3 -p -r1.63 coff-arm.c |*** bfd/coff-arm.c 16 Mar 2006 12:20:15 -0000 1.63 |--- bfd/coff-arm.c 10 May 2006 10:05:35 -0000 -------------------------- File to patch: bfd/coff-arm.c patching file bfd/coff-arm.c Hunk #1 FAILED at 220. Hunk #2 FAILED at 233. Hunk #3 FAILED at 246. Hunk #4 FAILED at 294. Hunk #5 FAILED at 307. Hunk #6 FAILED at 1209. 6 out of 6 hunks FAILED -- saving rejects to file bfd/coff-arm.c.rej The versions of the relevant files I see in CVS are : bfd/coff-arm.c 1.63 2006/03/16 gas/config/tc-arm.c 1.267 2006/05/09 ld/pe-dll.c 1.83 2006/01/31 ld/emultempl/pe.em 1.113 2005/11/24 I also tried your patch against binutils-2.16.1 - that only produced patch failures in one file (tc-arm.c). Danny On Wed, 2006-05-10 at 11:48 +0100, Nick Clifton wrote: > Hi Pedro, Hi Danny, >=20 > Please accept my apologies in taking so long to reply to your emails.= =20 > I have now had a chance to go over them and the patches that they=20 > contained and then seemed quite reasonable to me. I have applied them=20 > to my local source tree and checked to see if there were any regressions= =20 > - there were not. >=20 > Unfortunately I do not have an arm-wince system at my disposal, so I=20 > cannot check that the (slightly revised) versions of the patches that I=20 > applied allow working binaries to be created, so please can I ask for=20 > your help ? >=20 > I am attaching a unified patch which I think contains all of the=20 > changes that you suggested, along with a little bit of code tidying.=20 > Please could you try applying them to a set of binutils sources (from=20 > the mainline of the CVS repository) and testing them to see if they=20 > produce working binaries ? >=20 > One thing I am quite worried about is whether partial linking will=20 > work. (ie using the "ld -r ...." file to create an object file that is=20 > an amalgam of several other object files). I suspect that there might=20 > be problems with the -8 bias to branch relocations, but without a test=20 > environment I cannot tell for sure. >=20 > Thanks very much for perserving with your work, and assuming that you= =20 > can confirm that the patch works, I will be happy to check it in with=20 > the ChangeLogs below. >=20 > Cheers > Nick >=20 > bfd/ChangeLog > 2006-05-10 Pedro Alves >=20 > * coff-arm.c (ARM_26D, ARM_32, ARM_RVA_32, ARM_SECTION, > ARM_SECREL): Mark WinCE versions of these relocs as partial > inplace. > (coff_arm_relocate_section): Adjust addend for WinCE. >=20 > gas/ChangeLog > 2006-05-10 Pedro Alves >=20 > * config/tc-arm.c (md_pcrel_from_section): Force a bias for relocs=20 > against external symbols for WinCE targets. > (md_apply_fix): Likewise. >=20 > ld/ChangeLog > 2006-05-10 Pedro Alves >=20 > * pe-dll.c (autofilter_symbollist): Add Dllmain,=20=09=09 > DllMainCRTStartup, _DllMainCRTStartup and .text. > (autofilter_liblist): Add libcegcc. > (autofilter_symbolprefixlist): Add __imp_ and .idata$. > (generate_reloc): Do not skip sections without a SEC_LOAD flag,=20=09 > they can still contain relocs that need processing. > Skip the .idata$6 section. > (jmp_arm_bytes): New array: Contains byte codes for an ARM jump. > (make_one): Use the new array. > (make_import_fixup_entry): Use .idata$2 instead of .idata$3. > * emultempl/pe.em (MajorSubsystemVersion): Set to 3 for armpe. >=20 >=20 --=20 Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info --=-HMhFSBmhv7qvC5fwJdmd Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part Content-length: 191 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQBEYklMNEE+KCROU2kRApAFAJ9L51MQ+VTJSkMpOoLYjhbTgLRedwCfeop6 sAb02BBnIJf2lJnTavz4Yzw= =QvCF -----END PGP SIGNATURE----- --=-HMhFSBmhv7qvC5fwJdmd--