From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-71699-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 17110 invoked by alias); 17 May 2011 13:10:32 -0000
Received: (qmail 17006 invoked by uid 22791); 17 May 2011 13:10:31 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,TW_FN,TW_FX
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 May 2011 13:10:18 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 181A0CB0284;	Tue, 17 May 2011 15:10:17 +0200 (CEST)
Received: from mel.act-europe.fr ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id n7gypqtooFWK; Tue, 17 May 2011 15:10:14 +0200 (CEST)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67])	(using TLSv1 with cipher AES128-SHA (128/128 bits))	(No client certificate requested)	by mel.act-europe.fr (Postfix) with ESMTP id 18197CB0261;	Tue, 17 May 2011 15:10:14 +0200 (CEST)
Subject: Re: [Patch] bfd elfxx-ia64: share code between elf32 and elf64
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <BANLkTi=Ms6fs_HVZtR5fG4x2e-AKXD5W8g@mail.gmail.com>
Date: Tue, 17 May 2011 13:10:00 -0000
Cc: binutils Development <binutils@sourceware.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1149AB82-D754-4792-98C1-C677ABE5E712@adacore.com>
References: <EEEC6C47-1379-4F53-B7C9-C1C539E7A2AB@adacore.com> <BANLkTi=Ms6fs_HVZtR5fG4x2e-AKXD5W8g@mail.gmail.com>
To: H.J. Lu <hjl.tools@gmail.com>
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2011-05/txt/msg00238.txt.bz2


On May 17, 2011, at 3:04 PM, H.J. Lu wrote:

> On Tue, May 17, 2011 at 5:56 AM, Tristan Gingold <gingold@adacore.com> wr=
ote:
>> Hi,
>>=20
>> some functions of elfxx-ia64.c are in fact the same when compiled for el=
f32 and for elf64.  This patch adds a new file,
>> elfxx-ia64.h which declares these functions and compiles them only for e=
lf64.
>>=20
>> No regression for linux/gnu ia64 and hpux ia64.
>>=20
>> This work is in fact preliminary work to support gnu ld on vms/ia64.  Al=
though VMS uses elf64, it doesn't use the same shared library
>> model.  Its DSO model is derived from the previous vms one (vector based=
). This made code reuse difficult.
>>=20
>> Ok for trunk ?
>>=20
>=20
> Why not do something similar to SPARC/MIPS to put common codes in
> a new .c file?

That's fine with me.  My proposal would be:

size specific code to elfnn-ia64.c
common code to elfxx-ia64.c (to match mips and sparc).

Do you agree with this proposal ?

Tristan.