From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from t01.bc.larksuite.com (t01.bc.larksuite.com [209.127.231.19]) by sourceware.org (Postfix) with UTF8SMTPS id 890D53858401 for ; Fri, 18 Aug 2023 10:10:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 890D53858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=oss.cipunited.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2303200042; d=oss.cipunited.com; t=1692353403; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=EoxIAvpR7zJn/0y1dAkkufzRRDdEV8kjoeB15qwwxUc=; b=qxGELTg+wPTTafEmazIJf22nGirP37fpuI8bbZ1SjkQaW7q5uQpDbT6TlVUVVuZrXaqNCo 08yNMrxoOusWKUHFED9ar/kVp62Q8SqdQO1NZuSIDWN9OodwzjSVlikEBRTCDSsnNfjD+a /Ow87YJgHzQ8/YNjO+2A2MjspRG+rpquj2xV3G/bTiex4MUhRBk5GuHQhSVG868WvGTHHB 7P/UaggqjfXn3mA3vIBNIskBZ3LRIbs5Tl+TAAVpkanl/RCrfakZZr4bev7JOZLGKuGhq4 yq/nFCj8eAdSpaDi+DIxfU6XARQTx2rg91dLhuLOgEND6yC2Ryd5cLIoGJGL5Q== Date: Fri, 18 Aug 2023 18:10:02 +0800 Message-Id: <114fe517229b8cc0e504238f0d8553dd3528f5e9.568cb3db.66b5.4ad3.826b.3b027f1ea47e@feishu.cn> In-Reply-To: X-Lms-Return-Path: Content-Type: multipart/alternative; boundary=e71f548ea23d238f14fca0bc6f2bfaa97cbabd45930c356b3fa5ac41624d To: "Maciej W. Rozycki" , "libc-alpha" Cc: , "binutils" Subject: Re: [PATCH v7] MIPS: Sync elf.h from binutils From: =?utf-8?q?=E9=BB=84=E8=8E=BA?= Mime-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,SPF_HELO_NONE,SPF_PASS,TXREP,T_KAM_HTML_FONT_INVALID autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --e71f548ea23d238f14fca0bc6f2bfaa97cbabd45930c356b3fa5ac41624d Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Maciej, I have submitted pacth v10 including changing all E_MIPS_* to EF_MIPS_, and= also update binutils & submit patch. Thanks, Ying > From: "Maciej W. Rozycki" > Date: Sat, Aug 12, 2023, 01:43 > Subject: Re: [PATCH v7] MIPS: Sync elf.h from binutils > To: "Florian Weimer" > Cc: "Richard Sandiford", "Ying Huang", "libc-alpha", , > Hi Florian, >=20 > Cc-ing binutils now, to get a record of this discussion there. >=20 > > > The EF_* definitions were added on top of preexisting E_* macros bac= k in=20 > > > 1998 by Ulrich Drepper with commit c3966b88eeb ("Update.") and only t= his: > > > > > > * elf/elf.h: Add lots of new symbols from Irix and Solaris. > >=20 > > My concern was adding EF_* constants to glibc that duplicate E_* > > constants that are used in binutils. I think we should either change > > binutils to use the EF_* constants, too, or for these legacy constants, > > use the E_* prefix in glibc as well. >=20 > It's not a problem: as long as we reach consensus I can update binutils= =20 > accordingly, and we can discard E_* constants from there at any time if=20 > needed as they are for BFD use only and we don't offer any stable BFD API. >=20 > > Not sure if this a reasonable position, though. >=20 > So I did a little more research on this topic and came across this threa= d=20 > of mine from decades ago, and specifically this message coming from the=20 > lost world: .=20 > Clearly IRIX used to use EF_* macros, just as I thought and just as has=20 > used the Linux kernel (and MTI never came to finishing their promised=20 > psABI spec, where it only says "To be supplied" in the relevant part[1]). >=20 > So while we may have to keep the few already existing in , just=20 > because we were unfortunate enough to make them a part of our API back in= =20 > 1996: >=20 > * elf/elf.h: Add some new constants from recent Cygnus ELF > header files. >=20 > having likely taken them as a Cygnus invention without due consideration,= =20 > I think we ought to refrain from adding new E_* macros and stick to EF_*= =20 > instead. >=20 > NB the whole thread referred above might be worth reviewing for anyone=20 > interested in these matters. Here's a reference for the earlier part: > > as the discussion started on the old MIPS/Linux mailing lists first and=20 > then was carried over to binutils as well. >=20 > References: >=20 > [1] "MIPS ABIs Described", MIPS Technologies, Inc., Document Number:=20 > MD00305, Revision 1.3, 2002/12/02, Chapter 7. "ELF object code", p. 24 > >=20 > Maciej --e71f548ea23d238f14fca0bc6f2bfaa97cbabd45930c356b3fa5ac41624d--