From: James E Wilson <wilson@specifix.com>
To: "H. J. Lu" <hjl@lucon.org>
Cc: binutils@sources.redhat.com
Subject: Re: PATCH: PR ld/2884: Crash in elf64_ia64_relocate_section
Date: Mon, 10 Jul 2006 20:11:00 -0000 [thread overview]
Message-ID: <1152562259.9105.37.camel@aretha.corp.specifix.com> (raw)
In-Reply-To: <20060706232756.GA20456@lucon.org>
On Thu, 2006-07-06 at 16:27, H. J. Lu wrote:
> * elflink.c (_bfd_elf_merge_symbol): Set ref_dynamic to 0 for
> hidden and internal visibility. Copy the symbol info from the
> old versioned dynamic definition to the new one with
> non-default visibility.
This is an area I don't understand well, but this does look reasonable
to me.
> + /* Handle the case where the old dynamic definition is
> + versioned. We need to copy the symbol info from the
> + versioned symbol to the normal one if it is referenced
> + before. */
The only thing I noticed is that the second sentence here does not look
right to me. I think that should be "if it was referenced before".
--
Jim Wilson, GNU Tools Support, http://www.specifix.com
next prev parent reply other threads:[~2006-07-10 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-06 23:28 H. J. Lu
2006-07-10 20:11 ` James E Wilson [this message]
2006-07-11 14:05 ` Nick Clifton
2006-07-11 17:41 ` H. J. Lu
2006-07-12 4:03 ` H. J. Lu
2006-07-12 9:08 ` Nick Clifton
2006-07-12 17:19 ` H. J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152562259.9105.37.camel@aretha.corp.specifix.com \
--to=wilson@specifix.com \
--cc=binutils@sources.redhat.com \
--cc=hjl@lucon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).