public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Richard Earnshaw <rearnsha@arm.com>
To: Mark Shinwell <shinwell@codesourcery.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] PREL_11_0 and PC12 Thumb-2 relocations
Date: Fri, 01 Sep 2006 15:42:00 -0000	[thread overview]
Message-ID: <1157125318.1429.16.camel@pc960.cambridge.arm.com> (raw)
In-Reply-To: <44F6FADC.9090102@codesourcery.com>

On Thu, 2006-08-31 at 16:06, Mark Shinwell wrote:
> Here is bfd support for the ARM Thumb-2 PREL_11_0 and PC12 relocs.
> At this stage gas support is not provided, but that is a QoI issue
> rather than an EABI-compliance issue.
> 
> Since gas support is lacking, this patch has been tested manually.
> Anyone who is interested can see the details of that testing below.
> 
> OK?
> 
Yes; however, is there some reason why this


> @@ -848,12 +848,12 @@ static reloc_howto_type elf32_arm_howto_
>  	 13,			/* bitsize */
>  	 TRUE,			/* pc_relative */
>  	 0,			/* bitpos */
> -	 complain_overflow_signed,/* complain_on_overflow */
> +	 complain_overflow_dont,/* complain_on_overflow */
>  	 bfd_elf_generic_reloc,	/* special_function */
>  	 "R_ARM_THM_PC12",	/* name */
>  	 FALSE,			/* partial_inplace */
> -	 0x040070ff,		/* src_mask */
> -	 0x040070ff,		/* dst_mask */
> +	 0x0fffffff,		/* src_mask */
> +	 0x0fffffff,		/* dst_mask */
>  	 TRUE),			/* pcrel_offset */

uses 0x_0_fffffff rather than 0x_f_fffffff ?

R.

       reply	other threads:[~2006-09-01 15:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <44F6FADC.9090102@codesourcery.com>
2006-09-01 15:42 ` Richard Earnshaw [this message]
2006-09-01 15:52   ` Mark Shinwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1157125318.1429.16.camel@pc960.cambridge.arm.com \
    --to=rearnsha@arm.com \
    --cc=binutils@sourceware.org \
    --cc=shinwell@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).