* Re: Patch: fix parens in tc-hppa.c
[not found] <199909221907.MAA25706@cygnus.com>
@ 1999-09-23 7:45 ` Jeffrey A Law
0 siblings, 0 replies; 3+ messages in thread
From: Jeffrey A Law @ 1999-09-23 7:45 UTC (permalink / raw)
To: Jerry Quinn; +Cc: binutils
In message <199909221907.MAA25706@cygnus.com>you write:
> tc-hppa.c was a bit broken here. This patch fixes it so things compile.
>
> Jerry
>
> Wed Sep 22 15:03:11 EDT 1999 Jerry Quinn <jerry.quinn.adv91@alum.dartmouth
> .org>
>
> * gas/config/tc-hppa.c (pa_ip): Fix mismatched parentheses.
!?! The ChangeLog has no correlation to the patch itself. The patch zapped
the
'e' operand (used by some of the FP loads/stores). I'm not sure what you
were really trying to do here.
>
>
> *** orig/gas/config/tc-hppa.c Wed Sep 22 11:50:54 1999
> --- gas-src/gas/config/tc-hppa.c Wed Sep 22 14:28:28 1999
> ***************
> *** 3700,3734 ****
> opcode |= (result.l_r_select & 1) << 1;
> }
> continue;
> default:
> abort ();
> }
> break;
>
> ! /* Handle L/R register halves like 'x'. */
> ! case 'e':
> ! {
> ! struct pa_11_fp_reg_struct result;
> !
> ! /* This should be more strict. Small steps. */
> ! if (strict && *s != '%')
> ! break;
> ! pa_parse_number (&s, &result);
> ! CHECK_FIELD (result.number_part, 31, 0, 0);
> ! opcode |= (result.number_part & 0x1f) << 16;
> ! if (need_pa11_opcode (&the_insn, &result))
> ! {
> ! opcode |= (result.l_r_select & 1) << 1;
> ! }
> ! continue;
> ! }
> !
> default:
> abort ();
> }
> break;
> }
> !
> failed:
> /* Check if the args matched. */
> if (match == FALSE)
> --- 3700,3720 ----
> opcode |= (result.l_r_select & 1) << 1;
> }
> continue;
> + }
> +
> + /* Error case for float registers. */
> default:
> abort ();
> }
> break;
>
> ! /* Error case for all codes. */
> default:
> abort ();
> }
> break;
> }
> !
> failed:
> /* Check if the args matched. */
> if (match == FALSE)
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Patch: fix parens in tc-hppa.c
@ 1999-09-22 12:07 Jerry Quinn
0 siblings, 0 replies; 3+ messages in thread
From: Jerry Quinn @ 1999-09-22 12:07 UTC (permalink / raw)
To: binutils
tc-hppa.c was a bit broken here. This patch fixes it so things compile.
Jerry
Wed Sep 22 15:03:11 EDT 1999 Jerry Quinn <jerry.quinn.adv91@alum.dartmouth.org>
* gas/config/tc-hppa.c (pa_ip): Fix mismatched parentheses.
*** orig/gas/config/tc-hppa.c Wed Sep 22 11:50:54 1999
--- gas-src/gas/config/tc-hppa.c Wed Sep 22 14:28:28 1999
***************
*** 3700,3734 ****
opcode |= (result.l_r_select & 1) << 1;
}
continue;
default:
abort ();
}
break;
! /* Handle L/R register halves like 'x'. */
! case 'e':
! {
! struct pa_11_fp_reg_struct result;
!
! /* This should be more strict. Small steps. */
! if (strict && *s != '%')
! break;
! pa_parse_number (&s, &result);
! CHECK_FIELD (result.number_part, 31, 0, 0);
! opcode |= (result.number_part & 0x1f) << 16;
! if (need_pa11_opcode (&the_insn, &result))
! {
! opcode |= (result.l_r_select & 1) << 1;
! }
! continue;
! }
!
default:
abort ();
}
break;
}
!
failed:
/* Check if the args matched. */
if (match == FALSE)
--- 3700,3720 ----
opcode |= (result.l_r_select & 1) << 1;
}
continue;
+ }
+
+ /* Error case for float registers. */
default:
abort ();
}
break;
! /* Error case for all codes. */
default:
abort ();
}
break;
}
!
failed:
/* Check if the args matched. */
if (match == FALSE)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Patch: fix parens in tc-hppa.c
@ 1999-09-22 12:07 Jerry Quinn
0 siblings, 0 replies; 3+ messages in thread
From: Jerry Quinn @ 1999-09-22 12:07 UTC (permalink / raw)
To: binutils
tc-hppa.c was a bit broken here. This patch fixes it so things compile.
Jerry
Wed Sep 22 15:03:11 EDT 1999 Jerry Quinn <jerry.quinn.adv91@alum.dartmouth.org>
* gas/config/tc-hppa.c (pa_ip): Fix mismatched parentheses.
*** orig/gas/config/tc-hppa.c Wed Sep 22 11:50:54 1999
--- gas-src/gas/config/tc-hppa.c Wed Sep 22 14:28:28 1999
***************
*** 3700,3734 ****
opcode |= (result.l_r_select & 1) << 1;
}
continue;
default:
abort ();
}
break;
! /* Handle L/R register halves like 'x'. */
! case 'e':
! {
! struct pa_11_fp_reg_struct result;
!
! /* This should be more strict. Small steps. */
! if (strict && *s != '%')
! break;
! pa_parse_number (&s, &result);
! CHECK_FIELD (result.number_part, 31, 0, 0);
! opcode |= (result.number_part & 0x1f) << 16;
! if (need_pa11_opcode (&the_insn, &result))
! {
! opcode |= (result.l_r_select & 1) << 1;
! }
! continue;
! }
!
default:
abort ();
}
break;
}
!
failed:
/* Check if the args matched. */
if (match == FALSE)
--- 3700,3720 ----
opcode |= (result.l_r_select & 1) << 1;
}
continue;
+ }
+
+ /* Error case for float registers. */
default:
abort ();
}
break;
! /* Error case for all codes. */
default:
abort ();
}
break;
}
!
failed:
/* Check if the args matched. */
if (match == FALSE)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~1999-09-23 7:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <199909221907.MAA25706@cygnus.com>
1999-09-23 7:45 ` Patch: fix parens in tc-hppa.c Jeffrey A Law
1999-09-22 12:07 Jerry Quinn
-- strict thread matches above, loose matches on Subject: below --
1999-09-22 12:07 Jerry Quinn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).