From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeffrey A Law To: "Jerry Quinn" Cc: binutils@sourceware.cygnus.com Subject: Re: Patch: fix parens in tc-hppa.c Date: Thu, 23 Sep 1999 07:45:00 -0000 Message-id: <11704.938097735@upchuck.cygnus.com> References: <199909221907.MAA25706@cygnus.com> X-SW-Source: 1999-09/msg00161.html In message <199909221907.MAA25706@cygnus.com>you write: > tc-hppa.c was a bit broken here. This patch fixes it so things compile. > > Jerry > > Wed Sep 22 15:03:11 EDT 1999 Jerry Quinn .org> > > * gas/config/tc-hppa.c (pa_ip): Fix mismatched parentheses. !?! The ChangeLog has no correlation to the patch itself. The patch zapped the 'e' operand (used by some of the FP loads/stores). I'm not sure what you were really trying to do here. > > > *** orig/gas/config/tc-hppa.c Wed Sep 22 11:50:54 1999 > --- gas-src/gas/config/tc-hppa.c Wed Sep 22 14:28:28 1999 > *************** > *** 3700,3734 **** > opcode |= (result.l_r_select & 1) << 1; > } > continue; > default: > abort (); > } > break; > > ! /* Handle L/R register halves like 'x'. */ > ! case 'e': > ! { > ! struct pa_11_fp_reg_struct result; > ! > ! /* This should be more strict. Small steps. */ > ! if (strict && *s != '%') > ! break; > ! pa_parse_number (&s, &result); > ! CHECK_FIELD (result.number_part, 31, 0, 0); > ! opcode |= (result.number_part & 0x1f) << 16; > ! if (need_pa11_opcode (&the_insn, &result)) > ! { > ! opcode |= (result.l_r_select & 1) << 1; > ! } > ! continue; > ! } > ! > default: > abort (); > } > break; > } > ! > failed: > /* Check if the args matched. */ > if (match == FALSE) > --- 3700,3720 ---- > opcode |= (result.l_r_select & 1) << 1; > } > continue; > + } > + > + /* Error case for float registers. */ > default: > abort (); > } > break; > > ! /* Error case for all codes. */ > default: > abort (); > } > break; > } > ! > failed: > /* Check if the args matched. */ > if (match == FALSE) > >