* bfd/elf32-bfin.c: Possible typo or cut/paste error?
@ 2007-09-05 0:53 msnyder
2007-09-05 1:29 ` msnyder
0 siblings, 1 reply; 6+ messages in thread
From: msnyder @ 2007-09-05 0:53 UTC (permalink / raw)
To: binutils
As far as I can tell, there is no such thing as R_BFIN_GOT12...
2007-09-04 Michael Snyder <msnyder@access-company.com>
* elf32-bfin.c (howto_table): Cut and paste error?
Name field of reloc is wrong.
Index: elf32-bfin.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-bfin.c,v
retrieving revision 1.22
diff -c -8 -r1.22 elf32-bfin.c
*** elf32-bfin.c 3 Jul 2007 14:26:40 -0000 1.22
--- elf32-bfin.c 5 Sep 2007 00:50:15 -0000
***************
*** 711,727 ****
HOWTO (R_BFIN_GOT17M4, /* type */
2, /* rightshift */
1, /* size (0 = byte, 1 = short, 2 = long) */
16, /* bitsize */
FALSE, /* pc_relative */
0, /* bitpos */
complain_overflow_signed, /* complain_on_overflow */
bfd_elf_generic_reloc, /* special_function */
! "R_BFIN_GOT12", /* name */
FALSE, /* partial_inplace */
0xffff, /* src_mask */
0xffff, /* dst_mask */
FALSE), /* pcrel_offset */
/* The upper 16 bits of the GOT offset for the address of the
symbol. */
HOWTO (R_BFIN_GOTHI, /* type */
--- 711,727 ----
HOWTO (R_BFIN_GOT17M4, /* type */
2, /* rightshift */
1, /* size (0 = byte, 1 = short, 2 = long) */
16, /* bitsize */
FALSE, /* pc_relative */
0, /* bitpos */
complain_overflow_signed, /* complain_on_overflow */
bfd_elf_generic_reloc, /* special_function */
! "R_BFIN_GOT17M4", /* name */
FALSE, /* partial_inplace */
0xffff, /* src_mask */
0xffff, /* dst_mask */
FALSE), /* pcrel_offset */
/* The upper 16 bits of the GOT offset for the address of the
symbol. */
HOWTO (R_BFIN_GOTHI, /* type */
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?
2007-09-05 0:53 bfd/elf32-bfin.c: Possible typo or cut/paste error? msnyder
@ 2007-09-05 1:29 ` msnyder
2007-09-05 9:16 ` Andreas Schwab
0 siblings, 1 reply; 6+ messages in thread
From: msnyder @ 2007-09-05 1:29 UTC (permalink / raw)
To: binutils
> As far as I can tell, there is no such thing as R_BFIN_GOT12...
>
> 2007-09-04 Michael Snyder <msnyder@access-company.com>
>
> * elf32-bfin.c (howto_table): Cut and paste error?
> Name field of reloc is wrong.
And now that I think about it -- isn't the "bitsize" field
wrong too? Shouldn't it be 18?
And how about the "size" field? 1 = short? Isn't this field
supposed to be 18 bits? And isn't that too big for a short?
> Index: elf32-bfin.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf32-bfin.c,v
> retrieving revision 1.22
> diff -c -8 -r1.22 elf32-bfin.c
> *** elf32-bfin.c 3 Jul 2007 14:26:40 -0000 1.22
> --- elf32-bfin.c 5 Sep 2007 00:50:15 -0000
> ***************
> *** 711,727 ****
> HOWTO (R_BFIN_GOT17M4, /* type */
> 2, /* rightshift */
> 1, /* size (0 = byte, 1 = short, 2 = long) */
> 16, /* bitsize */
> FALSE, /* pc_relative */
> 0, /* bitpos */
> complain_overflow_signed, /* complain_on_overflow */
> bfd_elf_generic_reloc, /* special_function */
> ! "R_BFIN_GOT12", /* name */
> FALSE, /* partial_inplace */
> 0xffff, /* src_mask */
> 0xffff, /* dst_mask */
> FALSE), /* pcrel_offset */
>
> /* The upper 16 bits of the GOT offset for the address of the
> symbol. */
> HOWTO (R_BFIN_GOTHI, /* type */
> --- 711,727 ----
> HOWTO (R_BFIN_GOT17M4, /* type */
> 2, /* rightshift */
> 1, /* size (0 = byte, 1 = short, 2 = long) */
> 16, /* bitsize */
> FALSE, /* pc_relative */
> 0, /* bitpos */
> complain_overflow_signed, /* complain_on_overflow */
> bfd_elf_generic_reloc, /* special_function */
> ! "R_BFIN_GOT17M4", /* name */
> FALSE, /* partial_inplace */
> 0xffff, /* src_mask */
> 0xffff, /* dst_mask */
> FALSE), /* pcrel_offset */
>
> /* The upper 16 bits of the GOT offset for the address of the
> symbol. */
> HOWTO (R_BFIN_GOTHI, /* type */
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?
2007-09-05 1:29 ` msnyder
@ 2007-09-05 9:16 ` Andreas Schwab
2007-09-05 14:42 ` Michael Snyder
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2007-09-05 9:16 UTC (permalink / raw)
To: msnyder; +Cc: binutils
msnyder@sonic.net writes:
>> As far as I can tell, there is no such thing as R_BFIN_GOT12...
>>
>> 2007-09-04 Michael Snyder <msnyder@access-company.com>
>>
>> * elf32-bfin.c (howto_table): Cut and paste error?
>> Name field of reloc is wrong.
>
> And now that I think about it -- isn't the "bitsize" field
> wrong too? Shouldn't it be 18?
bitsize is the size after shifting.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?
2007-09-05 9:16 ` Andreas Schwab
@ 2007-09-05 14:42 ` Michael Snyder
2007-09-05 16:32 ` Jie Zhang
0 siblings, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2007-09-05 14:42 UTC (permalink / raw)
To: Andreas Schwab; +Cc: binutils
> msnyder@sonic.net writes:
>
> >> As far as I can tell, there is no such thing as R_BFIN_GOT12...
> >>
> >> 2007-09-04 Michael Snyder <msnyder@access-company.com>
> >>
> >> * elf32-bfin.c (howto_table): Cut and paste error?
> >> Name field of reloc is wrong.
> >
> > And now that I think about it -- isn't the "bitsize" field
> > wrong too? Shouldn't it be 18?
>
> bitsize is the size after shifting.
Fair enough. And what about the actual patch?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?
2007-09-05 14:42 ` Michael Snyder
@ 2007-09-05 16:32 ` Jie Zhang
2007-09-05 18:50 ` msnyder
0 siblings, 1 reply; 6+ messages in thread
From: Jie Zhang @ 2007-09-05 16:32 UTC (permalink / raw)
To: Michael Snyder; +Cc: Andreas Schwab, binutils
Michael Snyder wrote:
>> msnyder@sonic.net writes:
>>
>>>> As far as I can tell, there is no such thing as R_BFIN_GOT12...
>>>>
>>>> 2007-09-04 Michael Snyder <msnyder@access-company.com>
>>>>
>>>> * elf32-bfin.c (howto_table): Cut and paste error?
>>>> Name field of reloc is wrong.
>>> And now that I think about it -- isn't the "bitsize" field
>>> wrong too? Shouldn't it be 18?
>> bitsize is the size after shifting.
>
> Fair enough. And what about the actual patch?
>
The patch is OK. I'm sure it's a cut and paste error. Thanks!
Jie
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?
2007-09-05 16:32 ` Jie Zhang
@ 2007-09-05 18:50 ` msnyder
0 siblings, 0 replies; 6+ messages in thread
From: msnyder @ 2007-09-05 18:50 UTC (permalink / raw)
To: Jie Zhang; +Cc: Michael Snyder, Andreas Schwab, binutils
> Michael Snyder wrote:
>>> msnyder@sonic.net writes:
>>>
>>>>> As far as I can tell, there is no such thing as R_BFIN_GOT12...
>>>>>
>>>>> 2007-09-04 Michael Snyder <msnyder@access-company.com>
>>>>>
>>>>> * elf32-bfin.c (howto_table): Cut and paste error?
>>>>> Name field of reloc is wrong.
>>>> And now that I think about it -- isn't the "bitsize" field
>>>> wrong too? Shouldn't it be 18?
>>> bitsize is the size after shifting.
>>
>> Fair enough. And what about the actual patch?
>>
> The patch is OK. I'm sure it's a cut and paste error. Thanks!
Thanks, committed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-09-05 18:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-05 0:53 bfd/elf32-bfin.c: Possible typo or cut/paste error? msnyder
2007-09-05 1:29 ` msnyder
2007-09-05 9:16 ` Andreas Schwab
2007-09-05 14:42 ` Michael Snyder
2007-09-05 16:32 ` Jie Zhang
2007-09-05 18:50 ` msnyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).